Skip to content

Conversation

@Apache9
Copy link
Contributor

@Apache9 Apache9 commented Apr 9, 2024

No description provided.

@Apache9 Apache9 self-assigned this Apr 9, 2024
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 45s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗 mvndep 0m 20s Maven dependency ordering for branch
+1 💚 mvninstall 0m 42s master passed
+1 💚 compile 0m 25s master passed
+1 💚 javadoc 0m 12s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 6s Maven dependency ordering for patch
+1 💚 mvninstall 0m 48s the patch passed
+1 💚 compile 0m 23s the patch passed
+1 💚 javac 0m 23s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
+1 💚 javadoc 0m 11s the patch passed
_ Other Tests _
+1 💚 unit 0m 10s hbase-shaded-protobuf in the patch passed.
+1 💚 unit 0m 34s root in the patch passed.
+1 💚 asflicense 0m 10s The patch does not generate ASF License warnings.
5m 5s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-117/1/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR #117
Optional Tests dupname asflicense javac javadoc unit xml compile
uname Linux ad424a5fdee1 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
git revision master / 59dd9e3
Default Java Temurin-1.8.0_402-b06
Test Results https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-117/1/testReport/
Max. process+thread count 370 (vs. ulimit of 1000)
modules C: hbase-shaded-protobuf . U: .
Console output https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-117/1/console
versions git=2.34.1 maven=3.9.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Member

@ndimiduk ndimiduk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it time to re-engage with the protobuf team about accepting some version of these patches?

@Apache9
Copy link
Contributor Author

Apache9 commented Apr 9, 2024

Is it time to re-engage with the protobuf team about accepting some version of these patches?

I think first we need to check whether protobuf has already provided these abilities in newer versions. If not, we could try to contact with the protobuf team again.

@Apache9 Apache9 merged commit d7883b5 into apache:master Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants