Skip to content

Conversation

@pankaj72981
Copy link
Contributor

This PR contains following changes,

Bump protobuf version from 4.26.1 to 4.27.3
Recreate the patch HBASE-15789_V2.patch with private constructor of ByteString.LeafByteString
Recreate the patch HBASE-17087.patch & HBASE-17239.patch

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 25s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗 mvndep 0m 6s Maven dependency ordering for branch
+1 💚 mvninstall 0m 37s master passed
+1 💚 compile 0m 22s master passed
+1 💚 javadoc 0m 12s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 6s Maven dependency ordering for patch
+1 💚 mvninstall 0m 46s the patch passed
+1 💚 compile 0m 22s the patch passed
+1 💚 javac 0m 22s the patch passed
-1 ❌ whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚 xml 0m 0s The patch has no ill-formed XML file.
+1 💚 javadoc 0m 12s the patch passed
_ Other Tests _
+1 💚 unit 0m 9s hbase-shaded-protobuf in the patch passed.
+1 💚 unit 0m 34s root in the patch passed.
+1 💚 asflicense 0m 10s The patch does not generate ASF License warnings.
4m 13s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-120/2/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR #120
Optional Tests dupname asflicense javac javadoc unit xml compile
uname Linux 09bb9b01221f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
git revision master / 3a80d8d
Default Java Temurin-1.8.0_422-b05
whitespace https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-120/2/artifact/yetus-precommit-check/output/whitespace-eol.txt
Test Results https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-120/2/testReport/
Max. process+thread count 387 (vs. ulimit of 1000)
modules C: hbase-shaded-protobuf . U: .
Console output https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-120/2/console
versions git=2.43.0 maven=3.9.8
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 26s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗 mvndep 0m 5s Maven dependency ordering for branch
+1 💚 mvninstall 0m 36s master passed
+1 💚 compile 0m 23s master passed
+1 💚 javadoc 0m 12s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 5s Maven dependency ordering for patch
+1 💚 mvninstall 0m 47s the patch passed
+1 💚 compile 0m 22s the patch passed
+1 💚 javac 0m 22s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 0s The patch has no ill-formed XML file.
+1 💚 javadoc 0m 11s the patch passed
_ Other Tests _
+1 💚 unit 0m 10s hbase-shaded-protobuf in the patch passed.
+1 💚 unit 0m 31s root in the patch passed.
+1 💚 asflicense 0m 9s The patch does not generate ASF License warnings.
4m 11s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-120/3/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR #120
Optional Tests dupname asflicense javac javadoc unit xml compile
uname Linux 2146422a592b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
git revision master / 3a80d8d
Default Java Temurin-1.8.0_422-b05
Test Results https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-120/3/testReport/
Max. process+thread count 386 (vs. ulimit of 1000)
modules C: hbase-shaded-protobuf . U: .
Console output https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-120/3/console
versions git=2.43.0 maven=3.9.8
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@pankaj72981
Copy link
Contributor Author

@Apache9 Please review the PR. Thanks

@pankaj72981 pankaj72981 merged commit 937552c into apache:master Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants