-
Notifications
You must be signed in to change notification settings - Fork 52
HBASE-29685 [hbase-thirdparty] Bump netty4 to 4.1.127.Final #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-29685 [hbase-thirdparty] Bump netty4 to 4.1.127.Final #150
Conversation
bump netty and tcnative
|
🎊 +1 overall
This message was automatically generated. |
|
regarding test4tests, theres no code updates so no new tests required |
|
@CHarrod283 , please create a JIRA issue for this and use the same in the PR description |
|
needed to request an account on hbase jira, waiting for that to create an issue |
|
🎊 +1 overall
This message was automatically generated. |
chandrasekhar-188k
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
updated desc with linked jira ticket |
|
@chandrasekhar-188k it looks like all checks are ok and got approval, but im unable to merge. Is there a person who specifically merges the pr? |
@CHarrod283 , members with committer previleges only can merge the PRs.. I will check and merge this PR. |
|
Hi @CHarrod283 thanks for your PR. I assume you are new to the project, welcome to the team. Few nits: please ensure to keep PR title in sync with the JIRA title. We usually follow a simple format We usually don't need to ref jira link in commit message as it is redundant since github handle this mapping. I have update the message and title for you. |
|
@chandrasekhar-188k Feel free to commit this. |
|
hi @chandrasekhar-188k request you to revert the commit, the commit message is incorrect, please revert and apply again with fix |
i have used rebase and merge option, it didn't ask for the commit message... i have reverted those commits.. |
|
Ah no worries thank you! |
what is the process to apply changes again? can we reopen existing PR or create a new PR? |
I have opened a new PR: #152 |
Fixes following CVEs: