Skip to content

Conversation

@CHarrod283
Copy link
Contributor

@CHarrod283 CHarrod283 commented Oct 6, 2025

Fixes following CVEs:

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 2m 7s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 1m 10s master passed
+1 💚 compile 0m 16s master passed
+1 💚 javadoc 0m 7s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 41s the patch passed
+1 💚 compile 0m 17s the patch passed
+1 💚 javac 0m 17s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 xmllint 0m 1s No new issues.
+1 💚 javadoc 0m 6s the patch passed
_ Other Tests _
+1 💚 unit 0m 47s root in the patch passed.
+1 💚 asflicense 0m 8s The patch does not generate ASF License warnings.
5m 49s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-150/1/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR #150
Optional Tests dupname asflicense javac javadoc unit codespell detsecrets xmllint compile
uname Linux db543745fa15 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-home/workspace/Base-Thirdparty-PreCommit_PR-150/yetus-precommit-check/src/.yetus/personality.sh
git revision master / f4300ee
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-150/1/testReport/
Max. process+thread count 415 (vs. ulimit of 2000)
modules C: . U: .
Console output https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-150/1/console
versions git=2.34.1 maven=called xmllint=20913
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@CHarrod283
Copy link
Contributor Author

regarding test4tests, theres no code updates so no new tests required

@chandrasekhar-188k
Copy link
Contributor

@CHarrod283 , please create a JIRA issue for this and use the same in the PR description

@CHarrod283
Copy link
Contributor Author

needed to request an account on hbase jira, waiting for that to create an issue

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 2m 4s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 1m 3s master passed
+1 💚 compile 0m 16s master passed
+1 💚 javadoc 0m 6s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 40s the patch passed
+1 💚 compile 0m 16s the patch passed
+1 💚 javac 0m 16s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 xmllint 0m 0s No new issues.
+1 💚 javadoc 0m 6s the patch passed
_ Other Tests _
+1 💚 unit 0m 56s root in the patch passed.
+1 💚 asflicense 0m 6s The patch does not generate ASF License warnings.
5m 41s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-150/2/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR #150
Optional Tests dupname asflicense javac javadoc unit codespell detsecrets xmllint compile
uname Linux 18c11522cd1b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-home/workspace/Base-Thirdparty-PreCommit_PR-150/yetus-precommit-check/src/.yetus/personality.sh
git revision master / 69014a2
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-150/2/testReport/
Max. process+thread count 417 (vs. ulimit of 2000)
modules C: . U: .
Console output https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-150/2/console
versions git=2.34.1 maven=called xmllint=20913
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@chandrasekhar-188k chandrasekhar-188k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CHarrod283
Copy link
Contributor Author

@CHarrod283 , please create a JIRA issue for this and use the same in the PR description

updated desc with linked jira ticket

@CHarrod283 CHarrod283 changed the title Update Netty and Netty TCNative versions HBASE-29685 Update Netty and Netty TCNative versions Oct 27, 2025
@CHarrod283 CHarrod283 changed the title HBASE-29685 Update Netty and Netty TCNative versions HBASE-29685 Update Netty to address github advisory Oct 27, 2025
@CHarrod283
Copy link
Contributor Author

@chandrasekhar-188k it looks like all checks are ok and got approval, but im unable to merge. Is there a person who specifically merges the pr?

@chandrasekhar-188k
Copy link
Contributor

@chandrasekhar-188k it looks like all checks are ok and got approval, but im unable to merge. Is there a person who specifically merges the pr?

@CHarrod283 , members with committer previleges only can merge the PRs.. I will check and merge this PR.

@NihalJain NihalJain changed the title HBASE-29685 Update Netty to address github advisory HBASE-29685 Bump netty4 to 4.1.127.Final Oct 30, 2025
@NihalJain NihalJain changed the title HBASE-29685 Bump netty4 to 4.1.127.Final HBASE-29685 [hbase-thirdparty] Bump netty4 to 4.1.127.Final Oct 30, 2025
@NihalJain
Copy link
Contributor

Hi @CHarrod283 thanks for your PR. I assume you are new to the project, welcome to the team. Few nits: please ensure to keep PR title in sync with the JIRA title. We usually follow a simple format <jira-id> <jira-title> i.e. HBASE-12345 Fix All The Things
Ref https://hbase.apache.org/book.html#_commit_message_format

We usually don't need to ref jira link in commit message as it is redundant since github handle this mapping. I have update the message and title for you.

@NihalJain
Copy link
Contributor

@chandrasekhar-188k Feel free to commit this.

@chandrasekhar-188k chandrasekhar-188k merged commit 57b0338 into apache:master Oct 31, 2025
1 check passed
@NihalJain
Copy link
Contributor

hi @chandrasekhar-188k request you to revert the commit, the commit message is incorrect, please revert and apply again with fix

@chandrasekhar-188k
Copy link
Contributor

hi @chandrasekhar-188k request you to revert the commit, the commit message is incorrect, please revert and apply again with fix

i have used rebase and merge option, it didn't ask for the commit message... i have reverted those commits..

@NihalJain
Copy link
Contributor

Ah no worries thank you!

@chandrasekhar-188k
Copy link
Contributor

hi @chandrasekhar-188k request you to revert the commit, the commit message is incorrect, please revert and apply again with fix

what is the process to apply changes again? can we reopen existing PR or create a new PR?

@chandrasekhar-188k
Copy link
Contributor

hi @chandrasekhar-188k request you to revert the commit, the commit message is incorrect, please revert and apply again with fix

what is the process to apply changes again? can we reopen existing PR or create a new PR?

I have opened a new PR: #152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants