HBASE-24798 [hbase-thirdparty] Ignore module-info and SubmissionPubl… #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
busbey
requested changes
Jul 30, 2020
| <enforceBytecodeVersion> | ||
| <maxJdkVersion>${compileSource}</maxJdkVersion> | ||
| <ignoreClasses> | ||
| <ignoreClass>module-info</ignoreClass> |
Contributor
There was a problem hiding this comment.
Note the jira key for the bug that means we have to exclude module info
Contributor
Author
There was a problem hiding this comment.
Changed to 'Ignore module-info and SubmissionPublisher in enforceBytecodeVersion rule'
pom.xml
Outdated
| <maxJdkVersion>${compileSource}</maxJdkVersion> | ||
| <ignoreClasses> | ||
| <ignoreClass>module-info</ignoreClass> | ||
| <ignoreClass>**.SubmissionPublisher*</ignoreClass> |
Contributor
There was a problem hiding this comment.
Can we scope this to specifically from Jersey? With a note that it has a multi-release jar?
Contributor
Author
There was a problem hiding this comment.
I renamed the pattern to *.glassfish.jersey.internal.jsr166.SubmissionPublisher, I think it is enough to show that this is for jersey?
…sher in enforceBytecodeVersion rule
Apache9
changed the title
busbey
approved these changes
Jul 30, 2020
This was referenced Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…isher in enforceBytecodeVersion rule