-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
HBASE-22539 WAL corruption due to early DBBs re-use when Durability.A…
…SYNC_WAL is used (#437) Signed-off-by: Zheng Hu <openinx@gmail.com>
- Loading branch information
Showing
11 changed files
with
377 additions
and
31 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
111 changes: 111 additions & 0 deletions
111
...est/java/org/apache/hadoop/hbase/wal/TestAsyncFSWALCorruptionDueToDanglingByteBuffer.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,111 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.hadoop.hbase.wal; | ||
|
|
||
| import java.io.IOException; | ||
| import java.util.List; | ||
| import org.apache.hadoop.conf.Configuration; | ||
| import org.apache.hadoop.fs.FileSystem; | ||
| import org.apache.hadoop.fs.Path; | ||
| import org.apache.hadoop.hbase.HBaseClassTestRule; | ||
| import org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL; | ||
| import org.apache.hadoop.hbase.regionserver.wal.FailedLogCloseException; | ||
| import org.apache.hadoop.hbase.regionserver.wal.WALActionsListener; | ||
| import org.apache.hadoop.hbase.testclassification.MediumTests; | ||
| import org.apache.hadoop.hbase.testclassification.RegionServerTests; | ||
| import org.apache.hadoop.hbase.util.CommonFSUtils; | ||
| import org.apache.hadoop.hbase.util.Pair; | ||
| import org.junit.AfterClass; | ||
| import org.junit.BeforeClass; | ||
| import org.junit.ClassRule; | ||
| import org.junit.experimental.categories.Category; | ||
|
|
||
| import org.apache.hbase.thirdparty.io.netty.channel.Channel; | ||
| import org.apache.hbase.thirdparty.io.netty.channel.EventLoopGroup; | ||
|
|
||
| /** | ||
| * Testcase for HBASE-22539 | ||
| */ | ||
| @Category({ RegionServerTests.class, MediumTests.class }) | ||
| public class TestAsyncFSWALCorruptionDueToDanglingByteBuffer | ||
| extends WALCorruptionDueToDanglingByteBufferTestBase { | ||
|
|
||
| @ClassRule | ||
| public static final HBaseClassTestRule CLASS_RULE = | ||
| HBaseClassTestRule.forClass(TestAsyncFSWALCorruptionDueToDanglingByteBuffer.class); | ||
|
|
||
| public static final class PauseWAL extends AsyncFSWAL { | ||
|
|
||
| public PauseWAL(FileSystem fs, Path rootDir, String logDir, String archiveDir, | ||
| Configuration conf, List<WALActionsListener> listeners, boolean failIfWALExists, | ||
| String prefix, String suffix, EventLoopGroup eventLoopGroup, | ||
| Class<? extends Channel> channelClass) throws FailedLogCloseException, IOException { | ||
| super(fs, rootDir, logDir, archiveDir, conf, listeners, failIfWALExists, prefix, suffix, | ||
| eventLoopGroup, channelClass); | ||
| } | ||
|
|
||
| @Override | ||
| protected void atHeadOfRingBufferEventHandlerAppend() { | ||
| if (ARRIVE != null) { | ||
| ARRIVE.countDown(); | ||
| try { | ||
| RESUME.await(); | ||
| } catch (InterruptedException e) { | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| public static final class PauseWALProvider extends AbstractFSWALProvider<PauseWAL> { | ||
|
|
||
| private EventLoopGroup eventLoopGroup; | ||
|
|
||
| private Class<? extends Channel> channelClass; | ||
|
|
||
| @Override | ||
| protected PauseWAL createWAL() throws IOException { | ||
| return new PauseWAL(CommonFSUtils.getWALFileSystem(conf), CommonFSUtils.getWALRootDir(conf), | ||
| getWALDirectoryName(factory.factoryId), getWALArchiveDirectoryName(conf, factory.factoryId), | ||
| conf, listeners, true, logPrefix, | ||
| META_WAL_PROVIDER_ID.equals(providerId) ? META_WAL_PROVIDER_ID : null, eventLoopGroup, | ||
| channelClass); | ||
| } | ||
|
|
||
| @Override | ||
| protected void doInit(Configuration conf) throws IOException { | ||
| Pair<EventLoopGroup, Class<? extends Channel>> eventLoopGroupAndChannelClass = | ||
| NettyAsyncFSWALConfigHelper.getEventLoopConfig(conf); | ||
| eventLoopGroup = eventLoopGroupAndChannelClass.getFirst(); | ||
| channelClass = eventLoopGroupAndChannelClass.getSecond(); | ||
| } | ||
| } | ||
|
|
||
| @BeforeClass | ||
| public static void setUp() throws Exception { | ||
| UTIL.getConfiguration().setClass(WALFactory.WAL_PROVIDER, PauseWALProvider.class, | ||
| WALProvider.class); | ||
| UTIL.startMiniCluster(1); | ||
| UTIL.createTable(TABLE_NAME, CF); | ||
| UTIL.waitTableAvailable(TABLE_NAME); | ||
| } | ||
|
|
||
| @AfterClass | ||
| public static void tearDown() throws Exception { | ||
| UTIL.shutdownMiniCluster(); | ||
| } | ||
| } |
Oops, something went wrong.