silly mistake

apache · Jul 18, 2024 · 6caf25e · 6caf25e
1 parent 80dd227
commit 6caf25e
Showing 1 changed file with 14 additions and 16 deletions.
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/SnapshotQuotaObserverChore.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/SnapshotQuotaObserverChore.java
@@ -166,23 +166,21 @@ Multimap<TableName, String> getSnapshotsToComputeSize() throws IOException {
     Set<TableName> tablesToFetchSnapshotsFrom = new HashSet<>();
     QuotaFilter filter = new QuotaFilter();
     filter.addTypeFilter(QuotaType.SPACE);
-    try (Admin admin = conn.getAdmin()) {
+    try (Admin admin = conn.getAdmin(); QuotaRetriever qr = new QuotaRetriever(conn, filter)) {
       // Pull all of the tables that have quotas (direct, or from namespace)
-      try (QuotaRetriever qr = new QuotaRetriever(conn, filter)) {
-        for (QuotaSettings qs : qr) {
-          if (qs.getQuotaType() == QuotaType.SPACE) {
-            String ns = qs.getNamespace();
-            TableName tn = qs.getTableName();
-            if ((null == ns && null == tn) || (null != ns && null != tn)) {
-              throw new IllegalStateException(
-                "Expected either one of namespace and tablename to be null but not both");
-            }
-            // Collect either the table name itself, or all of the tables in the namespace
-            if (null != ns) {
-              tablesToFetchSnapshotsFrom.addAll(Arrays.asList(admin.listTableNamesByNamespace(ns)));
-            } else {
-              tablesToFetchSnapshotsFrom.add(tn);
-            }
+      for (QuotaSettings qs : qr) {
+        if (qs.getQuotaType() == QuotaType.SPACE) {
+          String ns = qs.getNamespace();
+          TableName tn = qs.getTableName();
+          if ((null == ns && null == tn) || (null != ns && null != tn)) {
+            throw new IllegalStateException(
+              "Expected either one of namespace and tablename to be null but not both");
+          }
+          // Collect either the table name itself, or all of the tables in the namespace
+          if (null != ns) {
+            tablesToFetchSnapshotsFrom.addAll(Arrays.asList(admin.listTableNamesByNamespace(ns)));
+          } else {
+            tablesToFetchSnapshotsFrom.add(tn);
           }
         }
       }