HBASE-21905 (addendum): Address compaction races in TestFIFOCompactio…

…nPolicy (#2203)

Looped through the test 100 times and it passes. Without the patch it fails
every ~10 runs or so.

Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Michael Stack <stack@apache.org>

hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestFIFOCompactionPolicy.java

@@ -115,6 +115,11 @@ public static void setEnvironmentEdge() throws Exception {
     EnvironmentEdgeManager.injectEdge(ee);
     Configuration conf = TEST_UTIL.getConfiguration();
     conf.setInt(HStore.BLOCKING_STOREFILES_KEY, 10000);
+    // Expired store file deletion during compaction optimization interferes with the FIFO
+    // compaction policy. The race causes changes to in-flight-compaction files resulting in a
+    // non-deterministic number of files selected by compaction policy. Disables that optimization
+    // for this test run.
+    conf.setBoolean("hbase.store.delete.expired.storefile", false);
     TEST_UTIL.startMiniCluster(1);
   }