Address review feedback. Fix checkstyle, javadoc, and whitespace warn…

…ings
apache · Feb 16, 2022 · 9d0b028 · 9d0b028
1 parent 818b32c
commit 9d0b028
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 4 deletions.
diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/ServerTask.java b/hbase-client/src/main/java/org/apache/hadoop/hbase/ServerTask.java
@@ -32,26 +32,31 @@ enum State {
   }
 
   /**
+   * Get the task's description.
    * @return the task's description, typically a name
    */
   String getDescription();
 
   /**
+   * Get the current status of the task.
    * @return the task's current status
    */
   String getStatus();
 
   /**
+   * Get the current state of the task.
    * @return the task's current state
    */
   State getState();
 
   /**
+   * Get the task start time.
    * @return the time when the task started, or 0 if it has not started yet
    */
   long getStartTime();
 
   /**
+   * Get the task completion time.
    * @return the time when the task completed, or 0 if it has not completed yet
    */
   long getCompletionTime();

diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/ServerTaskBuilder.java b/hbase-client/src/main/java/org/apache/hadoop/hbase/ServerTaskBuilder.java
@@ -35,7 +35,7 @@ public static ServerTaskBuilder newBuilder() {
 
   private ServerTaskBuilder() { }
 
-  private static class ServerTaskImpl implements ServerTask {
+  private static final class ServerTaskImpl implements ServerTask {
 
     private final String description;
     private final String status;

diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
@@ -105,7 +105,6 @@
 import org.apache.hadoop.hbase.ipc.ServerRpcController;
 import org.apache.hadoop.hbase.log.HBaseMarkers;
 import org.apache.hadoop.hbase.mob.MobFileCache;
-import org.apache.hadoop.hbase.monitoring.MonitoredTask;
 import org.apache.hadoop.hbase.monitoring.TaskMonitor;
 import org.apache.hadoop.hbase.namequeues.NamedQueueRecorder;
 import org.apache.hadoop.hbase.namequeues.SlowLogTableOpsChore;

diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/TestClientClusterMetrics.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/TestClientClusterMetrics.java
@@ -83,7 +83,7 @@ public class TestClientClusterMetrics {
   private static final byte[] CF = Bytes.toBytes("cf");
 
   // We need to promote the visibility of tryRegionServerReport for this test
-  public static class MyRegionServer 
+  public static class MyRegionServer
       extends SingleProcessHBaseCluster.MiniHBaseClusterRegionServer {
     public MyRegionServer(Configuration conf) throws IOException, InterruptedException {
       super(conf);

diff --git a/hbase-shell/src/main/ruby/hbase/admin.rb b/hbase-shell/src/main/ruby/hbase/admin.rb
@@ -934,7 +934,7 @@ def status(format, type)
         for server in cluster_metrics.getBackupMasters
           puts(format('    %s:%d %d', server.getHostname, server.getPort, server.getStartcode))
         end
-        master_coprocs = java.util.Arrays.toString(@admin.getMasterCoprocessors)
+        master_coprocs = @admin.getMasterCoprocessorNames.toString
         unless master_coprocs.nil?
           puts(format('master coprocessors: %s', master_coprocs))
         end