Skip to content

Commit

Permalink
HBASE-27951 Use ADMIN_QOS in MasterRpcServices for regionserver opera…
Browse files Browse the repository at this point in the history
…tional dependencies (#5309)

It seems not correct to have the MasterRpcServices methods for direct
regionserver<->master communication (regionServerStartup, regionServerReport,
and reportFatalRSError) contending with normal priority requests. They
should be made ADMIN_QOS priority to avoid potential operational deadlocks.

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Reviewed-by: Aman Poonia <aman.poonia.29@gmail.com>
  • Loading branch information
apurtell authored Jun 28, 2023
1 parent 0637bbc commit 9e8e438
Showing 1 changed file with 3 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -618,6 +618,7 @@ public GetLastFlushedSequenceIdResponse getLastFlushedSequenceId(RpcController c
}

@Override
@QosPriority(priority = HConstants.ADMIN_QOS)
public RegionServerReportResponse regionServerReport(RpcController controller,
RegionServerReportRequest request) throws ServiceException {
try {
Expand Down Expand Up @@ -653,6 +654,7 @@ public RegionServerReportResponse regionServerReport(RpcController controller,
}

@Override
@QosPriority(priority = HConstants.ADMIN_QOS)
public RegionServerStartupResponse regionServerStartup(RpcController controller,
RegionServerStartupRequest request) throws ServiceException {
// Register with server manager
Expand Down Expand Up @@ -684,6 +686,7 @@ public RegionServerStartupResponse regionServerStartup(RpcController controller,
}

@Override
@QosPriority(priority = HConstants.ADMIN_QOS)
public ReportRSFatalErrorResponse reportRSFatalError(RpcController controller,
ReportRSFatalErrorRequest request) throws ServiceException {
String errorText = request.getErrorMessage();
Expand Down

0 comments on commit 9e8e438

Please sign in to comment.