Skip to content

Commit

Permalink
HBASE-26976 Update related comments after HMaster can load the live R…
Browse files Browse the repository at this point in the history
…S infos from local region (#4375)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Yu Li <liyu@apache.org>
  • Loading branch information
2005hithlj authored Apr 30, 2022
1 parent da37896 commit b0c2832
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -865,8 +865,8 @@ private void tryMigrateMetaLocationsFromZooKeeper() throws IOException, KeeperEx
* from meta region</li>
* <li>Start region server tracker, construct the online servers set and find out dead servers and
* schedule SCP for them. The online servers will be constructed by scanning zk, and we will also
* scan the wal directory to find out possible live region servers, and the differences between
* these two sets are the dead servers</li>
* scan the wal directory and load from master local region to find out possible live region servers,
* and the differences between these two sets are the dead servers</li>
* </ol>
* </li>
* <li>If this is a new deploy, schedule a InitMetaProcedure to initialize meta</li>
Expand Down Expand Up @@ -941,8 +941,6 @@ private void finishActiveMasterInitialization(MonitoredTask status) throws IOExc
this.splitWALManager = new SplitWALManager(this);
}



tryMigrateMetaLocationsFromZooKeeper();

createProcedureExecutor();
Expand All @@ -963,8 +961,8 @@ private void finishActiveMasterInitialization(MonitoredTask status) throws IOExc
this.assignmentManager.setupRIT(ritList);

// Start RegionServerTracker with listing of servers found with exiting SCPs -- these should
// be registered in the deadServers set -- and with the list of servernames out on the
// filesystem that COULD BE 'alive' (we'll schedule SCPs for each and let SCP figure it out).
// be registered in the deadServers set -- and the servernames loaded from the WAL directory
// and master local region that COULD BE 'alive'(we'll schedule SCPs for each and let SCP figure it out).
// We also pass dirs that are already 'splitting'... so we can do some checks down in tracker.
// TODO: Generate the splitting and live Set in one pass instead of two as we currently do.
this.regionServerTracker.upgrade(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ public void upgrade(Set<ServerName> deadServersFromPE, Set<ServerName> liveServe
// '-SPLITTING'. Each splitting server should have a corresponding SCP. Log if not.
splittingServersFromWALDir.stream().filter(s -> !deadServersFromPE.contains(s)).
forEach(s -> LOG.error("{} has no matching ServerCrashProcedure", s));
// create ServerNode for all possible live servers from wal directory
// create ServerNode for all possible live servers from wal directory and master local region
liveServersBeforeRestart
.forEach(sn -> server.getAssignmentManager().getRegionStates().getOrCreateServer(sn));
ServerManager serverManager = server.getServerManager();
Expand Down

0 comments on commit b0c2832

Please sign in to comment.