-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
HBASE-27666 Allow preCompact hooks to return scanners whose cells can…
… be shipped (#5056) Signed-off-by: Duo Zhang <zhangduo@apache.org>
- Loading branch information
1 parent
43aa9b3
commit d2b0074
Showing
4 changed files
with
162 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
146 changes: 146 additions & 0 deletions
146
...test/java/org/apache/hadoop/hbase/regionserver/TestCompactionWithShippingCoprocessor.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,146 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.hadoop.hbase.regionserver; | ||
|
|
||
| import static org.hamcrest.MatcherAssert.assertThat; | ||
|
|
||
| import java.io.IOException; | ||
| import java.util.List; | ||
| import java.util.Optional; | ||
| import java.util.concurrent.atomic.AtomicInteger; | ||
| import org.apache.hadoop.conf.Configuration; | ||
| import org.apache.hadoop.hbase.Cell; | ||
| import org.apache.hadoop.hbase.HBaseClassTestRule; | ||
| import org.apache.hadoop.hbase.HBaseTestingUtil; | ||
| import org.apache.hadoop.hbase.HConstants; | ||
| import org.apache.hadoop.hbase.TableName; | ||
| import org.apache.hadoop.hbase.client.RegionLocator; | ||
| import org.apache.hadoop.hbase.client.Table; | ||
| import org.apache.hadoop.hbase.coprocessor.ObserverContext; | ||
| import org.apache.hadoop.hbase.coprocessor.RegionCoprocessor; | ||
| import org.apache.hadoop.hbase.coprocessor.RegionCoprocessorEnvironment; | ||
| import org.apache.hadoop.hbase.coprocessor.RegionObserver; | ||
| import org.apache.hadoop.hbase.regionserver.compactions.CompactionLifeCycleTracker; | ||
| import org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest; | ||
| import org.apache.hadoop.hbase.testclassification.CoprocessorTests; | ||
| import org.apache.hadoop.hbase.testclassification.MediumTests; | ||
| import org.apache.hadoop.hbase.util.Bytes; | ||
| import org.hamcrest.Matchers; | ||
| import org.junit.AfterClass; | ||
| import org.junit.BeforeClass; | ||
| import org.junit.ClassRule; | ||
| import org.junit.Rule; | ||
| import org.junit.Test; | ||
| import org.junit.experimental.categories.Category; | ||
| import org.junit.rules.TestName; | ||
|
|
||
| @Category({ MediumTests.class, CoprocessorTests.class }) | ||
| public class TestCompactionWithShippingCoprocessor { | ||
|
|
||
| private static final AtomicInteger SHIPPED_COUNT = new AtomicInteger(); | ||
|
|
||
| @ClassRule | ||
| public static final HBaseClassTestRule CLASS_RULE = | ||
| HBaseClassTestRule.forClass(TestCompactionWithShippingCoprocessor.class); | ||
|
|
||
| protected final static HBaseTestingUtil TEST_UTIL = new HBaseTestingUtil(); | ||
| private static final byte[] FAMILY = Bytes.toBytes("testFamily"); | ||
|
|
||
| @Rule | ||
| public TestName name = new TestName(); | ||
|
|
||
| @BeforeClass | ||
| public static void setUpBeforeClass() throws Exception { | ||
| Configuration conf = TEST_UTIL.getConfiguration(); | ||
| conf.setInt(HConstants.HBASE_CLIENT_RETRIES_NUMBER, 0);// do not retry | ||
| TEST_UTIL.startMiniCluster(1); | ||
| } | ||
|
|
||
| @AfterClass | ||
| public static void tearDownAfterClass() throws Exception { | ||
| TEST_UTIL.shutdownMiniCluster(); | ||
| } | ||
|
|
||
| /** | ||
| * Verifies that if a coproc returns an InternalScanner which implements Shipper, the shippped | ||
| * method is appropriately called in Compactor. | ||
| */ | ||
| @Test | ||
| public void testCoprocScannersExtendingShipperGetShipped() throws Exception { | ||
| int shippedCountBefore = SHIPPED_COUNT.get(); | ||
| final TableName tableName = TableName.valueOf(name.getMethodName()); | ||
| // Create a table with block size as 1024 | ||
| final Table table = TEST_UTIL.createTable(tableName, new byte[][] { FAMILY }, 1, 1024, | ||
| CompactionObserver.class.getName()); | ||
| TEST_UTIL.loadTable(table, FAMILY); | ||
| TEST_UTIL.flush(); | ||
| try { | ||
| // get the block cache and region | ||
| RegionLocator locator = TEST_UTIL.getConnection().getRegionLocator(tableName); | ||
| String regionName = locator.getAllRegionLocations().get(0).getRegion().getEncodedName(); | ||
| HRegion region = TEST_UTIL.getRSForFirstRegionInTable(tableName).getRegion(regionName); | ||
| // trigger a major compaction | ||
| TEST_UTIL.compact(true); | ||
| assertThat(SHIPPED_COUNT.get(), Matchers.greaterThan(shippedCountBefore)); | ||
| } finally { | ||
| table.close(); | ||
| } | ||
| } | ||
|
|
||
| public static class CompactionObserver implements RegionCoprocessor, RegionObserver { | ||
|
|
||
| @Override | ||
| public Optional<RegionObserver> getRegionObserver() { | ||
| return Optional.of(this); | ||
| } | ||
|
|
||
| @Override | ||
| public InternalScanner preCompact(ObserverContext<RegionCoprocessorEnvironment> c, Store store, | ||
| InternalScanner scanner, ScanType scanType, CompactionLifeCycleTracker tracker, | ||
| CompactionRequest request) throws IOException { | ||
| return new ShippedObservingScanner(scanner); | ||
| } | ||
| } | ||
|
|
||
| public static class ShippedObservingScanner implements InternalScanner, Shipper { | ||
|
|
||
| protected final InternalScanner scanner; | ||
|
|
||
| public ShippedObservingScanner(InternalScanner scanner) { | ||
| this.scanner = scanner; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean next(List<Cell> result, ScannerContext scannerContext) throws IOException { | ||
| return scanner.next(result, scannerContext); | ||
| } | ||
|
|
||
| @Override | ||
| public void close() throws IOException { | ||
| scanner.close(); | ||
| } | ||
|
|
||
| @Override | ||
| public void shipped() throws IOException { | ||
| if (scanner instanceof Shipper) { | ||
| SHIPPED_COUNT.incrementAndGet(); | ||
| ((Shipper) scanner).shipped(); | ||
| } | ||
| } | ||
| } | ||
| } |