Address precommit static analysis nits

apache · Jan 6, 2022 · e85eba6 · e85eba6
1 parent 486eb4d
commit e85eba6
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 5 deletions.
diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/trace/ConnectionSpanBuilder.java b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/trace/ConnectionSpanBuilder.java
@@ -32,7 +32,6 @@
 import java.util.function.Supplier;
 import org.apache.hadoop.hbase.client.AsyncConnectionImpl;
 import org.apache.hadoop.hbase.client.ClusterConnection;
-import org.apache.hadoop.hbase.client.ConnectionImplementation;
 import org.apache.hadoop.hbase.trace.TraceUtil;
 import org.apache.yetus.audience.InterfaceAudience;
 

diff --git a/...-client/src/main/java/org/apache/hadoop/hbase/client/trace/TableOperationSpanBuilder.java b/...-client/src/main/java/org/apache/hadoop/hbase/client/trace/TableOperationSpanBuilder.java
@@ -32,7 +32,6 @@
 import org.apache.hadoop.hbase.client.AsyncConnectionImpl;
 import org.apache.hadoop.hbase.client.CheckAndMutate;
 import org.apache.hadoop.hbase.client.ClusterConnection;
-import org.apache.hadoop.hbase.client.ConnectionImplementation;
 import org.apache.hadoop.hbase.client.Delete;
 import org.apache.hadoop.hbase.client.Get;
 import org.apache.hadoop.hbase.client.Increment;

diff --git a/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncTableTracing.java b/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncTableTracing.java
@@ -17,8 +17,6 @@
  */
 package org.apache.hadoop.hbase.client;
 
-import static org.apache.hadoop.hbase.client.trace.hamcrest.AttributesMatchers.containsEntry;
-import static org.apache.hadoop.hbase.client.trace.hamcrest.SpanDataMatchers.hasAttributes;
 import static org.apache.hadoop.hbase.client.trace.hamcrest.SpanDataMatchers.hasEnded;
 import static org.apache.hadoop.hbase.client.trace.hamcrest.SpanDataMatchers.hasKind;
 import static org.apache.hadoop.hbase.client.trace.hamcrest.SpanDataMatchers.hasName;
@@ -35,7 +33,6 @@
 import static org.mockito.ArgumentMatchers.anyLong;
 import static org.mockito.Mockito.doAnswer;
 import static org.mockito.Mockito.mock;
-import io.opentelemetry.api.trace.Span;
 import io.opentelemetry.api.trace.SpanKind;
 import io.opentelemetry.api.trace.StatusCode;
 import io.opentelemetry.sdk.testing.junit4.OpenTelemetryRule;

diff --git a/hbase-client/src/test/java/org/apache/hadoop/hbase/client/trace/hamcrest/TraceTestUtil.java b/hbase-client/src/test/java/org/apache/hadoop/hbase/client/trace/hamcrest/TraceTestUtil.java
@@ -43,6 +43,7 @@ public static Matcher<SpanData> buildConnectionAttributesMatcher(AsyncConnection
   }
 
   /**
+   * All {@link Span}s involving {@code conn} should include these attributes.
    * @see #buildConnectionAttributesMatcher(AsyncConnectionImpl)
    */
   public static Matcher<SpanData> buildConnectionAttributesMatcher(ConnectionImplementation conn) {
-Original file line number
+Diff line change
@@ Expand Up @@
       }
       /**
+       * All {@link Span}s involving {@code conn} should include these attributes.
        * @see #buildConnectionAttributesMatcher(AsyncConnectionImpl)
        */
       public static Matcher<SpanData> buildConnectionAttributesMatcher(ConnectionImplementation conn) {
@@ Expand Down @@