Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-22207 Fix flakey TestAssignmentManager.testAssignSocketTimeout #138

Merged
merged 1 commit into from
Apr 12, 2019
Merged

HBASE-22207 Fix flakey TestAssignmentManager.testAssignSocketTimeout #138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestAssignmentManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,9 @@ public void testAssignSocketTimeout() throws Exception {
rsDispatcher.setMockRsExecutor(new SocketTimeoutRsExecutor(20));
waitOnFuture(submitProcedure(createAssignProcedure(hri)));

assertEquals(assignSubmittedCount + 1, assignProcMetrics.getSubmittedCounter().getCount());
// we crashed a rs, so it is possible that there are other regions on the rs which will also be
// reassigned, so here we just assert greater than, not the exact number.
assertTrue(assignProcMetrics.getSubmittedCounter().getCount() > assignSubmittedCount);
assertEquals(assignFailedCount, assignProcMetrics.getFailedCounter().getCount());
}

Expand Down