HBASE-24051 Allows indirect inheritance to CanUnbuffer #1415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
ndimiduk
reviewed
Apr 9, 2020
There was a problem hiding this comment.
It's not clear to me why this class uses reflection to access CanUnbuffer. That class has been in Hadoop at least since 2.8, and continues to be available on trunk. However, it's marked as Public/Evolving. Since it's a public class, I think it's fine to import the class directly instead of locating it via reflection.
I have the same question about looking for the presence of the method unbuffer, unless we're protecting against the method disappearing in a future release.
I don't think any of the above is the case; I think this is an artifact of hadoop1 compat. So basically, I think you can get rid of all this reflection and replace all this with something like
import org.apache.hadoop.fs.CanUnbuffer;
...
this.instanceOfCanUnbuffer = wrappedStream instanced CanUnbuffer;| + "left open in CLOSE_WAIT state.", e); | ||
| } | ||
| return; | ||
| if(wrappedStream instanceof CanUnbuffer){ |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
@shenshengli have you seen the @ndimiduk comment above? Any response? Thank you. |
|
I closed this issue that has gone 28 days w/o response. Please open new PR to make progress again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have an inherited parent class that implements CanUnbuffer instead of directly implementing CanUnbuffer. Modify unit tests.