Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-24185: Junit tests do not behave well with System.exit or Runti… #1540

Merged
merged 1 commit into from
Apr 21, 2020
Merged

HBASE-24185: Junit tests do not behave well with System.exit or Runti… #1540

merged 1 commit into from
Apr 21, 2020

Conversation

markrmiller
Copy link
Member

…me.halt or JVM exits in general.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 4m 39s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚 mvninstall 3m 41s branch-2 passed
+1 💚 compile 0m 24s branch-2 passed
+1 💚 shadedjars 4m 34s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 23s branch-2 passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 15s the patch passed
+1 💚 compile 0m 22s the patch passed
+1 💚 javac 0m 22s the patch passed
+1 💚 shadedjars 4m 27s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 21s the patch passed
_ Other Tests _
+1 💚 unit 1m 21s hbase-common in the patch passed.
24m 44s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1540/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #1540
JIRA Issue HBASE-24185
Optional Tests javac javadoc unit shadedjars compile
uname Linux 2810cf62a071 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 361e81e
Default Java 1.8.0_232
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1540/1/testReport/
Max. process+thread count 340 (vs. ulimit of 12500)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1540/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 3m 10s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚 mvninstall 4m 31s branch-2 passed
+1 💚 compile 0m 24s branch-2 passed
+1 💚 shadedjars 5m 41s branch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 17s hbase-common in branch-2 failed.
_ Patch Compile Tests _
+1 💚 mvninstall 4m 13s the patch passed
+1 💚 compile 0m 25s the patch passed
+1 💚 javac 0m 25s the patch passed
+1 💚 shadedjars 5m 44s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 16s hbase-common in the patch failed.
_ Other Tests _
+1 💚 unit 1m 51s hbase-common in the patch passed.
27m 44s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1540/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #1540
JIRA Issue HBASE-24185
Optional Tests javac javadoc unit shadedjars compile
uname Linux d3737d1c54a5 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 361e81e
Default Java 2020-01-14
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1540/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1540/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1540/1/testReport/
Max. process+thread count 292 (vs. ulimit of 12500)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1540/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 4m 41s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+1 💚 mvninstall 3m 40s branch-2 passed
+1 💚 checkstyle 0m 25s branch-2 passed
+1 💚 spotbugs 0m 46s branch-2 passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 7s the patch passed
+1 💚 checkstyle 0m 24s the patch passed
+1 💚 whitespace 0m 1s The patch has no whitespace issues.
+1 💚 hadoopcheck 11m 12s Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
+1 💚 spotbugs 0m 51s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 14s The patch does not generate ASF License warnings.
32m 23s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1540/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1540
JIRA Issue HBASE-24185
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux 187b02725d5a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 361e81e
Max. process+thread count 94 (vs. ulimit of 12500)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1540/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

saintstack
saintstack reviewed Apr 17, 2020
View reviewed changes
Copy link
Contributor

@saintstack saintstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Will help loads.

hbase-common/src/test/java/org/apache/hadoop/hbase/SystemExitRule.java Show resolved Hide resolved
hbase-common/src/test/java/org/apache/hadoop/hbase/SystemExitRule.java Outdated

public class SystemExitRule implements TestRule {

public SystemExitRule() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add this constructor?

hbase-common/src/test/java/org/apache/hadoop/hbase/SystemExitRule.java Outdated Show resolved Hide resolved
hbase-common/src/test/java/org/apache/hadoop/hbase/TestSystemExitInTest.java Outdated Show resolved Hide resolved
hbase-common/src/test/java/org/apache/hadoop/hbase/SystemExitRule.java Outdated Show resolved Hide resolved
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 13s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚 mvninstall 3m 50s branch-2 passed
+1 💚 compile 0m 21s branch-2 passed
+1 💚 shadedjars 4m 44s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 21s branch-2 passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 29s the patch passed
+1 💚 compile 0m 22s the patch passed
+1 💚 javac 0m 22s the patch passed
+1 💚 shadedjars 4m 48s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 19s the patch passed
_ Other Tests _
+1 💚 unit 1m 20s hbase-common in the patch passed.
21m 56s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1540/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #1540
JIRA Issue HBASE-24185
Optional Tests javac javadoc unit shadedjars compile
uname Linux 8bed800d3166 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 2762ddc
Default Java 1.8.0_232
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1540/2/testReport/
Max. process+thread count 279 (vs. ulimit of 12500)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1540/2/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 13s Docker mode activated.
-0 ⚠️ yetus 0m 7s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚 mvninstall 4m 27s branch-2 passed
+1 💚 compile 0m 27s branch-2 passed
+1 💚 shadedjars 5m 52s branch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 16s hbase-common in branch-2 failed.
_ Patch Compile Tests _
+1 💚 mvninstall 4m 16s the patch passed
+1 💚 compile 0m 25s the patch passed
+1 💚 javac 0m 25s the patch passed
+1 💚 shadedjars 5m 44s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 16s hbase-common in the patch failed.
_ Other Tests _
+1 💚 unit 1m 44s hbase-common in the patch passed.
25m 54s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1540/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #1540
JIRA Issue HBASE-24185
Optional Tests javac javadoc unit shadedjars compile
uname Linux 5a63e9f95525 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 2762ddc
Default Java 2020-01-14
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1540/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1540/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1540/2/testReport/
Max. process+thread count 271 (vs. ulimit of 12500)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1540/2/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 24s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+1 💚 mvninstall 3m 52s branch-2 passed
+1 💚 checkstyle 0m 25s branch-2 passed
+1 💚 spotbugs 0m 45s branch-2 passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 32s the patch passed
+1 💚 checkstyle 0m 23s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 12m 6s Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
+1 💚 spotbugs 0m 51s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 11s The patch does not generate ASF License warnings.
31m 5s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1540/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1540
JIRA Issue HBASE-24185
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux 0079fd5ba1c2 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 2762ddc
Max. process+thread count 84 (vs. ulimit of 12500)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1540/2/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

saintstack
saintstack approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@saintstack saintstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Running it locally first to make sure it ok... will then merge.

@saintstack saintstack merged commit 8a7aa89 into apache:branch-2 Apr 21, 2020
asfgit pushed a commit that referenced this pull request Apr 21, 2020
@markrmiller @saintstack
HBASE-24185: Junit tests do not behave well with System.exit or Runti…
f48b509 
…me.halt or JVM exits in general. (#1540)


Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: stack <stack@apache.org>
asfgit pushed a commit that referenced this pull request Apr 21, 2020
@markrmiller @saintstack
HBASE-24185: Junit tests do not behave well with System.exit or Runti…
8cf7bba 
…me.halt or JVM exits in general. (#1540)


Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: stack <stack@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@virajjasani virajjasani virajjasani left review comments

@saintstack saintstack saintstack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@markrmiller @Apache-HBase @saintstack @virajjasani