Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: HBASE-24369 Provide more information about merged child regions in Hb… #1769

Merged
merged 1 commit into from
May 25, 2020
Merged

Backport: HBASE-24369 Provide more information about merged child regions in Hb… #1769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions hbase-server/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,6 +476,10 @@ public List<Pair<RegionInfo, RegionInfo>> getOverlaps() {
return this.overlaps;
}

public Map<RegionInfo, Result> getMergedRegions() {
return this.mergedRegions;
}

public List<Pair<RegionInfo, ServerName>> getUnknownServers() {
return unknownServers;
}
Expand Down
18 changes: 16 additions & 2 deletions hbase-server/src/main/resources/hbase-webapps/master/hbck.jsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,12 @@
<div class="row inner_header">
<div class="page-header">
<h2>Overlaps</h2>
<p>
<span>
Regions highlighted in <font color="blue">blue</font> are recently merged regions, HBase is still doing cleanup for them. Overlaps involving these regions cannot be fixed by <em>hbck2 fixMeta</em> at this moment.
Please wait some time, run <i>catalogjanitor_run</i> in hbase shell, refresh ‘HBCK Report’ page, make sure these regions are not highlighted to start the fix.
</span>
</p>
</div>
</div>
<table class="table table-striped">
Expand All @@ -245,8 +251,16 @@
</tr>
<% for (Pair<RegionInfo, RegionInfo> p : report.getOverlaps()) { %>
<tr>
<td><span title="<%= p.getFirst() %>"><%= p.getFirst().getEncodedName() %></span></td>
<td><span title="<%= p.getSecond() %>"><%= p.getSecond().getEncodedName() %></span></td>
<% if (report.getMergedRegions().containsKey(p.getFirst())) { %>
<td><span style="color:blue;" title="<%= p.getFirst() %>"><%= p.getFirst().getEncodedName() %></span></td>
<% } else { %>
<td><span title="<%= p.getFirst() %>"><%= p.getFirst().getEncodedName() %></span></td>
<% } %>
<% if (report.getMergedRegions().containsKey(p.getSecond())) { %>
<td><span style="color:blue;" title="<%= p.getSecond() %>"><%= p.getSecond().getEncodedName() %></span></td>
<% } else { %>
<td><span title="<%= p.getSecond() %>"><%= p.getSecond().getEncodedName() %></span></td>
<% } %>
</tr>
<% } %>

Expand Down