-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-24940: runCatalogJanitor() API should return -1 to indicate already running status #2331
Conversation
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per the current behaviour, runCatalogJanitor returns 0 if previous run is in progress. By making it return -1, do we want client to wait for certain duration before retrying? Is that the purpose behind this change?
Please resolve build issue.
Thanks
…eady running status
79732e1
to
101f2c1
Compare
When previous scan is progress return value is 0. This 0 indicates that no items are garbage collected. This is wrong because in actual there was not attempt to garbage collect any item. Purpose of this change is to correct this wrong behavior to inform the user properly so they take correct actions.
It is up to the API user how they want to handle it. yes, running after time could be one of the options |
Re based the PR to resolve build issue |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
Failed test cases not related to PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
TestRSGroupsFallback is failing consistently, can you check locally? In the meanwhile, let me trigger another build. |
I run TestRSGroupsFallback locally three times. Every time it passed. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
It's fine, these are flaky tests. If we can get one more approval, it would be really great. |
…eady running status Closes #2331 Signed-off-by: Viraj Jasani <vjasani@apache.org>
…eady running status Closes #2331 Signed-off-by: Viraj Jasani <vjasani@apache.org>
…eady running status Closes #2331 Co-authored-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org>
…eady running status Closes apache#2331 Signed-off-by: Viraj Jasani <vjasani@apache.org>
No description provided.