Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-25037 Lots of thread pool are changed to non daemon after HBASE… #2407

Merged
merged 1 commit into from
Sep 16, 2020
Merged

HBASE-25037 Lots of thread pool are changed to non daemon after HBASE… #2407

merged 1 commit into from
Sep 16, 2020

Conversation

Apache9
Copy link
Contributor

@Apache9 Apache9 commented Sep 16, 2020

…-24750 which causes trouble when shutting down

@Apache9
HBASE-25037 Lots of thread pool are changed to non daemon after HBASE…
450c006 
…-24750 which causes trouble when shutting down
@Apache9 Apache9 self-assigned this Sep 16, 2020
@Apache9 Apache9 requested a review from virajjasani September 16, 2020 10:23
virajjasani
virajjasani approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 33s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 22s Maven dependency ordering for branch
+1 💚 mvninstall 3m 47s master passed
+1 💚 checkstyle 3m 27s master passed
+1 💚 spotbugs 6m 14s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 3m 37s the patch passed
+1 💚 checkstyle 3m 10s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 11m 22s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotbugs 9m 7s the patch passed
_ Other Tests _
+1 💚 asflicense 1m 32s The patch does not generate ASF License warnings.
53m 11s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2407/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #2407
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux eb16d87b5b7f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / c5ca191
Max. process+thread count 94 (vs. ulimit of 12500)
modules C: hbase-client hbase-procedure hbase-server hbase-thrift hbase-backup hbase-it hbase-examples U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2407/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 8s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 22s Maven dependency ordering for branch
+1 💚 mvninstall 4m 9s master passed
+1 💚 compile 3m 55s master passed
+1 💚 shadedjars 6m 37s branch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 22s hbase-backup in master failed.
-0 ⚠️ javadoc 0m 26s hbase-client in master failed.
-0 ⚠️ javadoc 0m 23s hbase-examples in master failed.
-0 ⚠️ javadoc 0m 18s hbase-procedure in master failed.
-0 ⚠️ javadoc 0m 40s hbase-server in master failed.
-0 ⚠️ javadoc 0m 50s hbase-thrift in master failed.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
+1 💚 mvninstall 4m 0s the patch passed
+1 💚 compile 3m 55s the patch passed
+1 💚 javac 3m 55s the patch passed
+1 💚 shadedjars 6m 33s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 27s hbase-client in the patch failed.
-0 ⚠️ javadoc 0m 18s hbase-procedure in the patch failed.
-0 ⚠️ javadoc 0m 40s hbase-server in the patch failed.
-0 ⚠️ javadoc 0m 52s hbase-thrift in the patch failed.
-0 ⚠️ javadoc 0m 20s hbase-backup in the patch failed.
-0 ⚠️ javadoc 0m 24s hbase-examples in the patch failed.
_ Other Tests _
+1 💚 unit 1m 8s hbase-client in the patch passed.
+1 💚 unit 1m 37s hbase-procedure in the patch passed.
+1 💚 unit 134m 45s hbase-server in the patch passed.
+1 💚 unit 4m 40s hbase-thrift in the patch passed.
+1 💚 unit 11m 23s hbase-backup in the patch passed.
+1 💚 unit 1m 14s hbase-it in the patch passed.
+1 💚 unit 1m 45s hbase-examples in the patch passed.
197m 27s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2407/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #2407
Optional Tests javac javadoc unit shadedjars compile
uname Linux 350fc860f0c5 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / c5ca191
Default Java 2020-01-14
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2407/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-backup.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2407/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2407/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-examples.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2407/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-procedure.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2407/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2407/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2407/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2407/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-procedure.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2407/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2407/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2407/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-backup.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2407/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-examples.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2407/1/testReport/
Max. process+thread count 5152 (vs. ulimit of 12500)
modules C: hbase-client hbase-procedure hbase-server hbase-thrift hbase-backup hbase-it hbase-examples U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2407/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 33s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 22s Maven dependency ordering for branch
+1 💚 mvninstall 3m 46s master passed
+1 💚 compile 3m 39s master passed
+1 💚 shadedjars 6m 46s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 43s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
+1 💚 mvninstall 3m 35s the patch passed
+1 💚 compile 3m 32s the patch passed
+1 💚 javac 3m 32s the patch passed
+1 💚 shadedjars 6m 31s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 38s the patch passed
_ Other Tests _
+1 💚 unit 1m 5s hbase-client in the patch passed.
+1 💚 unit 1m 44s hbase-procedure in the patch passed.
-1 ❌ unit 140m 48s hbase-server in the patch failed.
+1 💚 unit 4m 13s hbase-thrift in the patch passed.
+1 💚 unit 10m 36s hbase-backup in the patch passed.
+1 💚 unit 1m 12s hbase-it in the patch passed.
+1 💚 unit 1m 58s hbase-examples in the patch passed.
199m 24s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2407/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #2407
Optional Tests javac javadoc unit shadedjars compile
uname Linux 4d26deb3b18d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / c5ca191
Default Java 1.8.0_232
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2407/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2407/1/testReport/
Max. process+thread count 4811 (vs. ulimit of 12500)
modules C: hbase-client hbase-procedure hbase-server hbase-thrift hbase-backup hbase-it hbase-examples U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2407/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache9 Apache9 merged commit 1bb19e0 into apache:master Sep 16, 2020
asfgit pushed a commit that referenced this pull request Sep 16, 2020
@Apache9
HBASE-25037 Lots of thread pool are changed to non daemon after HBASE…
7a3bb8a 
…-24750 which causes trouble when shutting down (#2407)

Signed-off-by: Viraj Jasani <vjasani@apache.org>
clarax pushed a commit to clarax/hbase that referenced this pull request Nov 15, 2020
@Apache9 @clarax
HBASE-25037 Lots of thread pool are changed to non daemon after HBASE…
228402c 
…-24750 which causes trouble when shutting down (apache#2407)

Signed-off-by: Viraj Jasani <vjasani@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@virajjasani virajjasani virajjasani approved these changes

Assignees

@Apache9 Apache9

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Apache9 @Apache-HBase @virajjasani