Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-22449 https everywhere in Maven metadata #247

Merged
merged 1 commit into from
May 21, 2019

Conversation

apurtell
Copy link
Contributor

@apurtell apurtell commented May 21, 2019

There will be some attention paid to insecure URLs used for retrieval of build dependencies. While our build does not have direct exposure to this we do have some insecure URLs pointing to secondary resources like JIRA, mailing list archives, hbase.apache.org, and the online book. Make these https too.

I left the license header text alone, although there is a URL to the ASL 2 license embedded there. If we are going to update that, let's do that as a separate task because just about every file is going to be touched.

@apurtell apurtell requested a review from busbey May 21, 2019 17:27
@apurtell apurtell merged commit a30b186 into apache:master May 21, 2019
@apurtell apurtell deleted the HBASE-22449 branch May 21, 2019 19:34
@apurtell
Copy link
Contributor Author

Picking this back everywhere too

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 165 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
0 mvndep 29 Maven dependency ordering for branch
+1 mvninstall 257 master passed
+1 compile 170 master passed
+1 checkstyle 132 master passed
+1 shadedjars 272 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 700 master passed
_ Patch Compile Tests _
0 mvndep 13 Maven dependency ordering for patch
+1 mvninstall 250 the patch passed
+1 compile 171 the patch passed
+1 javac 171 the patch passed
+1 checkstyle 130 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 xml 53 The patch has no ill-formed XML file.
+1 shadedjars 278 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1019 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.0.3 3.1.2.
+1 javadoc 712 the patch passed
_ Other Tests _
-1 unit 17494 root in the patch failed.
+1 asflicense 1158 The patch does not generate ASF License warnings.
23379
Reason Tests
Failed junit tests hadoop.hbase.client.TestFromClientSide
hadoop.hbase.client.TestFromClientSideWithCoprocessor
hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
hadoop.hbase.master.procedure.TestSCPWithReplicas
hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated
hadoop.hbase.client.TestAdmin1
hadoop.hbase.util.TestFromClientSide3WoUnsafe
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-247/1/artifact/out/Dockerfile
GITHUB PR #247
Optional Tests dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile checkstyle
uname Linux fa2c5f58f985 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 91ccb22
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-247/1/artifact/out/patch-unit-root.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-247/1/testReport/
Max. process+thread count 5078 (vs. ulimit of 10000)
modules C: hbase-checkstyle hbase-annotations hbase-build-configuration hbase-protocol-shaded hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-protocol hbase-client hbase-zookeeper hbase-replication hbase-resource-bundle hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-external-blockcache hbase-assembly hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project hbase-archetypes/hbase-archetype-builder . U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-247/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

apurtell added a commit to apurtell/hbase that referenced this pull request May 22, 2019
symat pushed a commit to symat/hbase that referenced this pull request Feb 17, 2021
(cherry picked from commit b4bdf39)

Change-Id: Ia8772e0283ac4f67a452ce3492e048b159a132ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants