Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-24813 ReplicationSource should clear buffer usage on Replicatio… #2849

Merged
merged 1 commit into from
Jan 12, 2021
Merged

HBASE-24813 ReplicationSource should clear buffer usage on Replicatio… #2849

merged 1 commit into from
Jan 12, 2021

Conversation

wchevreuil
Copy link
Contributor

This a backport for PR #2546 merged into master. The cherry-pick into branch-2 required some conflicts resolution.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 13s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+1 💚 mvninstall 4m 10s branch-2 passed
+1 💚 checkstyle 1m 29s branch-2 passed
+1 💚 spotbugs 2m 44s branch-2 passed
_ Patch Compile Tests _
+1 💚 mvninstall 4m 23s the patch passed
-0 ⚠️ checkstyle 1m 27s hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 15m 37s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotbugs 2m 47s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 16s The patch does not generate ASF License warnings.
43m 30s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2849/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #2849
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux 3e177a1c62b0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / cec9f18
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2849/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count 95 (vs. ulimit of 12500)
modules C: hbase-server U: hbase-server
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2849/1/console
versions git=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 22s Docker mode activated.
-0 ⚠️ yetus 0m 7s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚 mvninstall 4m 29s branch-2 passed
+1 💚 compile 1m 10s branch-2 passed
+1 💚 shadedjars 7m 8s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 45s branch-2 passed
_ Patch Compile Tests _
+1 💚 mvninstall 4m 26s the patch passed
+1 💚 compile 1m 16s the patch passed
+1 💚 javac 1m 16s the patch passed
+1 💚 shadedjars 7m 24s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 43s the patch passed
_ Other Tests _
+1 💚 unit 138m 37s hbase-server in the patch passed.
169m 40s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2849/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #2849
Optional Tests javac javadoc unit shadedjars compile
uname Linux e385bb1f7404 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / cec9f18
Default Java AdoptOpenJDK-11.0.6+10
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2849/1/testReport/
Max. process+thread count 4373 (vs. ulimit of 12500)
modules C: hbase-server U: hbase-server
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2849/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 29s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚 mvninstall 4m 40s branch-2 passed
+1 💚 compile 1m 18s branch-2 passed
+1 💚 shadedjars 7m 13s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 41s branch-2 passed
_ Patch Compile Tests _
+1 💚 mvninstall 4m 22s the patch passed
+1 💚 compile 1m 11s the patch passed
+1 💚 javac 1m 11s the patch passed
+1 💚 shadedjars 7m 59s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 47s the patch passed
_ Other Tests _
+1 💚 unit 209m 25s hbase-server in the patch passed.
241m 3s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2849/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #2849
Optional Tests javac javadoc unit shadedjars compile
uname Linux 1536ea91ae89 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / cec9f18
Default Java AdoptOpenJDK-1.8.0_232-b09
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2849/1/testReport/
Max. process+thread count 2887 (vs. ulimit of 12500)
modules C: hbase-server U: hbase-server
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2849/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

joshelser
joshelser reviewed Jan 8, 2021
View reviewed changes
Copy link
Member

@joshelser joshelser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment. Running tests locally to make sure we don't have a similar problem to last time :)

...src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceShipper.java Show resolved Hide resolved
@joshelser
Copy link
Member

Running tests locally to make sure we don't have a similar problem to last time :)

Not observing any run-away logging for replication tests in hbase-server. 👍🏼

ankitsinghal
ankitsinghal approved these changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@ankitsinghal ankitsinghal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@wchevreuil wchevreuil merged commit fdae12d into apache:branch-2 Jan 12, 2021
wchevreuil added a commit that referenced this pull request Jan 12, 2021
@wchevreuil
HBASE-24813 ReplicationSource should clear buffer usage on Replicatio… (
cc12edb 
#2546) (#2849)

Signed-off-by: Ankit Singhal <ankit@apache.org>
Signed-off-by: Josh Elser <elserj@apache.org>
wchevreuil added a commit that referenced this pull request Jan 12, 2021
@wchevreuil
HBASE-24813 ReplicationSource should clear buffer usage on Replicatio… (
3242c8a 
#2546) (#2849)

Signed-off-by: Ankit Singhal <ankit@apache.org>
Signed-off-by: Josh Elser <elserj@apache.org>
(cherry picked from commit fdae12d)
wchevreuil added a commit to wchevreuil/hbase that referenced this pull request May 24, 2021
@wchevreuil
HBASE-24813 ReplicationSource should clear buffer usage on Replicatio… (
0a8d066 
apache#2546) (apache#2849)

Signed-off-by: Ankit Singhal <ankit@apache.org>
Signed-off-by: Josh Elser <elserj@apache.org>
(cherry picked from commit fdae12d)
(cherry picked from commit 3242c8a)

Change-Id: I8552da6cb7b37271204e255a6ca96a8af544da48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitsinghal ankitsinghal ankitsinghal approved these changes

@joshelser joshelser joshelser approved these changes

@Apache9 Apache9 Awaiting requested review from Apache9

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wchevreuil @Apache-HBase @joshelser @ankitsinghal