HBASE-25750 Upgrade RpcControllerFactory and HBaseRpcController from Private to LimitedPrivate(COPROC,PHOENIX) #3136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjacoby126
reviewed
Apr 8, 2021
| @@ -37,7 +39,8 @@ | |||
| * RegionInfo we're making the call against if relevant (useful adding info to exceptions and logs). | |||
| * Used by client and server ipc'ing. | |||
| */ | |||
| @InterfaceAudience.Private | |||
| @InterfaceAudience.LimitedPrivate({HBaseInterfaceAudience.COPROC, HBaseInterfaceAudience.PHOENIX}) | |||
There was a problem hiding this comment.
@apurtell - we may want to also add HBaseInterfaceAudience.REPLICATION to the LimitedPrivate annotation. @bharathv and I recently tried to make a custom replication sink implementing the replication API (which I assume counts as Public?), but found we had to downcast RpcController to HBaseRpcController to get at the actual replicated Cells.
There was a problem hiding this comment.
@gjacoby126 Updated
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
…Private to LimitedPrivate(COPROC,PHOENIX)
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
asfgit
pushed a commit
that referenced
this pull request
Apr 9, 2021
…Private to LimitedPrivate(COPROC,PHOENIX) (#3136) Signed-off-by: Bharath Vissapragada <bharathv@apache.org>
asfgit
pushed a commit
that referenced
this pull request
Apr 9, 2021
…Private to LimitedPrivate(COPROC,PHOENIX) (#3136) Signed-off-by: Bharath Vissapragada <bharathv@apache.org> Conflicts: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcControllerFactory.java
asfgit
pushed a commit
that referenced
this pull request
Apr 9, 2021
…Private to LimitedPrivate(COPROC,PHOENIX) (#3136) Signed-off-by: Bharath Vissapragada <bharathv@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apache Phoenix has had an unrecognized dependency on RpcControllerFactory and HBaseRpcController. These interfaces are used to override setPriority for appropriate dispatch of requests for Phoenix system or index tables to separate pools. This is a reasonable use of these interfaces but the audience annotations were never updated to reflect this usage. Also seems reasonable to do so as there has been no issue here for four years. (Phoenix commit was made in 2017.)