Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-22616 responseTooXXX logging for Multi should characterize the component ops #329

Merged
merged 1 commit into from
Jun 25, 2019

Conversation

apurtell
Copy link
Contributor

Multi RPC can be a mix of gets and mutations. The responseTooXXX logging for Multi ops should characterize the operations within the request so we have some clue about whether read or write dispatch was involved.

@apurtell apurtell changed the title HBASE-22616 responseTooSlow logging for Multi should characterize the component ops HBASE-22616 responseTooXXX logging for Multi should characterize the component ops Jun 21, 2019
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 25 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 248 master passed
+1 compile 50 master passed
+1 checkstyle 64 master passed
+1 shadedjars 249 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 209 master passed
+1 javadoc 33 master passed
_ Patch Compile Tests _
+1 mvninstall 231 the patch passed
+1 compile 49 the patch passed
+1 javac 49 the patch passed
+1 checkstyle 63 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 247 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 705 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 findbugs 233 the patch passed
+1 javadoc 34 the patch passed
_ Other Tests _
+1 unit 9116 hbase-server in the patch passed.
+1 asflicense 31 The patch does not generate ASF License warnings.
11887
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-329/1/artifact/out/Dockerfile
GITHUB PR #329
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux b483751bfa24 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 6d08ffc
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-329/1/testReport/
Max. process+thread count 4635 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-329/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 23 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 230 master passed
+1 compile 50 master passed
+1 checkstyle 66 master passed
+1 shadedjars 249 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 214 master passed
+1 javadoc 32 master passed
_ Patch Compile Tests _
+1 mvninstall 231 the patch passed
+1 compile 50 the patch passed
+1 javac 50 the patch passed
+1 checkstyle 63 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 251 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 689 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 findbugs 223 the patch passed
+1 javadoc 30 the patch passed
_ Other Tests _
+1 unit 9111 hbase-server in the patch passed.
+1 asflicense 28 The patch does not generate ASF License warnings.
11848
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-329/2/artifact/out/Dockerfile
GITHUB PR #329
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 7723fcd7548b 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 6d08ffc
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-329/2/testReport/
Max. process+thread count 4771 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-329/2/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@Reidddddd Reidddddd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member

@the-sakthi the-sakthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@apurtell apurtell merged commit 15ac781 into apache:master Jun 25, 2019
@apurtell apurtell deleted the HBASE-22616 branch June 25, 2019 01:03
asfgit pushed a commit that referenced this pull request Jun 25, 2019
…component ops (#329)

Signed-off-by: Reid Chan <reidchan@apache.org>
Signed-off-by: Michael Stack <stack@apache.org>
asfgit pushed a commit that referenced this pull request Jun 25, 2019
…component ops (#329)

Signed-off-by: Reid Chan <reidchan@apache.org>
Signed-off-by: Michael Stack <stack@apache.org>
asfgit pushed a commit that referenced this pull request Jun 25, 2019
…component ops (#329)

Signed-off-by: Reid Chan <reidchan@apache.org>
Signed-off-by: Michael Stack <stack@apache.org>
wchevreuil pushed a commit to wchevreuil/hbase that referenced this pull request Jul 3, 2019
…component ops (apache#329)

Signed-off-by: Reid Chan <reidchan@apache.org>
Signed-off-by: Michael Stack <stack@apache.org>
symat pushed a commit to symat/hbase that referenced this pull request Feb 17, 2021
…component ops (apache#329)

Signed-off-by: Reid Chan <reidchan@apache.org>
Signed-off-by: Michael Stack <stack@apache.org>
(cherry picked from commit 8b22700)

Change-Id: I5128202557dd618be2c9d8c7e5bb27f53ce09d62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants