HBASE-26045 Master control the global throughput of all compaction servers #3538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
saintstack
reviewed
Aug 10, 2021
| @@ -2256,6 +2256,17 @@ void cloneTableSchema(TableName tableName, TableName newTableName, boolean prese | |||
| */ | |||
| boolean isCompactionOffloadEnabled() throws IOException; | |||
|
|
|||
| /** | |||
| * update compaction server total throughput bound | |||
| * @param upperBound the total throughput upper bound of all compaction servers | |||
There was a problem hiding this comment.
When we talk of compaction servers here, are we talking about the new compaction server facility or are we talking about regionservers?
There was a problem hiding this comment.
we can control compaction throughtput on compactionServers, can not control regionservers
There was a problem hiding this comment.
Most deploys will not use a compaction server suite. Is it correct then to talk of compaction servers in our Admin API? Should there be another channel for interacting with compaction servers? A CompactionServersAdmin ?
There was a problem hiding this comment.
This method talk to master only, compaction servers get throughput control message through periodic heartbeat report
|
@Apache9 @saintstack Mind help take a look at your convenience. |
Apache9
reviewed
Aug 20, 2021
There was a problem hiding this comment.
So the algorithm here does not count for ongoing compactions, instead, just divide the quota evenly across different compaction servers? If there are 10 compaction server, but only one compaction server has ongoing compactions, it still can only use 1/10 of the quota?
| * @return the now total throughput of all compaction servers | ||
| * @throws IOException if a remote or network exception occurs | ||
| */ | ||
| Map<String, Long> updateCompactionServerTotalThroughput(Long upperBound, Long lowerBound, |
There was a problem hiding this comment.
We have 'CompactionServer' in the method name, so this global control is only for compaction server? Region server can not have the same limit? And why Long, not long?
There was a problem hiding this comment.
Yes, We do not control regionserver's compaction throughtput in this PR (it is OK?), For HRegionserver can adjust their compaction throughtput via update_config shell commend, no need restart server. They implement ConfigurationObserver interface.
OK, let me promote the algorithm according to ongoing compactions |
nyl3532016
changed the title
|
💔 -1 overall
This message was automatically generated. |
2 similar comments
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compaction servers report compaction tasks to master via heartbeat report.
The report response has throughput control message and compaction server use this message to adjust compaction throughtput.
We can set total throughtput of all compaction servers via hbase shell commands.