Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-26386 Refactor StoreFileTracker implementations to expose the s… #3774

Merged
merged 1 commit into from
Oct 21, 2021
Merged

HBASE-26386 Refactor StoreFileTracker implementations to expose the s… #3774

merged 1 commit into from
Oct 21, 2021

Conversation

Apache9
Copy link
Contributor

@Apache9 Apache9 commented Oct 20, 2021

…et method

@Apache9 Apache9 requested a review from wchevreuil October 20, 2021 13:31
@Apache9 Apache9 self-assigned this Oct 20, 2021
@Apache9
Copy link
Contributor Author

Apache9 commented Oct 20, 2021

It turns out that we still need to use StoreFileTrackerBase in MigrationStoreFileTracker so the refactoring is just a small one...

PTAL @wchevreuil

Thanks.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 58s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 1s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ HBASE-26067 Compile Tests _
+1 💚 mvninstall 4m 12s HBASE-26067 passed
+1 💚 compile 3m 16s HBASE-26067 passed
+1 💚 checkstyle 1m 11s HBASE-26067 passed
+1 💚 spotbugs 2m 28s HBASE-26067 passed
_ Patch Compile Tests _
+1 💚 mvninstall 4m 32s the patch passed
+1 💚 compile 3m 37s the patch passed
+1 💚 javac 3m 37s the patch passed
+1 💚 checkstyle 1m 13s hbase-server: The patch generated 0 new + 0 unchanged - 5 fixed = 0 total (was 5)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 21m 23s Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚 spotbugs 2m 25s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 14s The patch does not generate ASF License warnings.
53m 47s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3774/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3774
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname Linux a7830994ee6a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision HBASE-26067 / d3556bf
Default Java AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count 96 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3774/1/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 28s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-26067 Compile Tests _
+1 💚 mvninstall 4m 44s HBASE-26067 passed
+1 💚 compile 1m 12s HBASE-26067 passed
+1 💚 shadedjars 8m 37s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 45s HBASE-26067 passed
_ Patch Compile Tests _
+1 💚 mvninstall 4m 33s the patch passed
+1 💚 compile 1m 13s the patch passed
+1 💚 javac 1m 13s the patch passed
+1 💚 shadedjars 8m 58s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 45s the patch passed
_ Other Tests _
+1 💚 unit 146m 19s hbase-server in the patch passed.
179m 45s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3774/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3774
Optional Tests javac javadoc unit shadedjars compile
uname Linux 2709254d0c08 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision HBASE-26067 / d3556bf
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3774/1/testReport/
Max. process+thread count 4094 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3774/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 30s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-26067 Compile Tests _
+1 💚 mvninstall 4m 25s HBASE-26067 passed
+1 💚 compile 1m 5s HBASE-26067 passed
+1 💚 shadedjars 8m 48s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 42s HBASE-26067 passed
_ Patch Compile Tests _
+1 💚 mvninstall 4m 1s the patch passed
+1 💚 compile 1m 6s the patch passed
+1 💚 javac 1m 6s the patch passed
+1 💚 shadedjars 8m 38s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 36s the patch passed
_ Other Tests _
+1 💚 unit 157m 51s hbase-server in the patch passed.
189m 52s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3774/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #3774
Optional Tests javac javadoc unit shadedjars compile
uname Linux b47852496c92 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision HBASE-26067 / d3556bf
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3774/1/testReport/
Max. process+thread count 5090 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3774/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9 Apache9 merged commit 86836d4 into apache:HBASE-26067 Oct 21, 2021
Apache9 added a commit that referenced this pull request Oct 21, 2021
@Apache9
HBASE-26386 Refactor StoreFileTracker implementations to expose the s…
29fb33b 
…et method (#3774)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Apache9 added a commit that referenced this pull request Nov 6, 2021
@Apache9
HBASE-26386 Refactor StoreFileTracker implementations to expose the s…
6b6caa0 
…et method (#3774)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Apache9 added a commit that referenced this pull request Nov 9, 2021
@Apache9
HBASE-26386 Refactor StoreFileTracker implementations to expose the s…
5c93fc9 
…et method (#3774)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Apache9 added a commit that referenced this pull request Nov 27, 2021
@Apache9
HBASE-26386 Refactor StoreFileTracker implementations to expose the s…
201fadc 
…et method (#3774)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Apache9 added a commit that referenced this pull request Dec 6, 2021
@Apache9
HBASE-26386 Refactor StoreFileTracker implementations to expose the s…
0be4424 
…et method (#3774)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Apache9 added a commit that referenced this pull request Dec 17, 2021
@Apache9
HBASE-26386 Refactor StoreFileTracker implementations to expose the s…
5af5c5e 
…et method (#3774)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
asfgit pushed a commit that referenced this pull request Dec 22, 2021
@Apache9 @joshelser
HBASE-26386 Refactor StoreFileTracker implementations to expose the s…
e4e7cf8 
…et method (#3774)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Apache9 added a commit that referenced this pull request Jan 1, 2022
@Apache9
HBASE-26386 Refactor StoreFileTracker implementations to expose the s…
9627a8a 
…et method (#3774)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Apache9 added a commit that referenced this pull request Jan 2, 2022
@Apache9
HBASE-26386 Refactor StoreFileTracker implementations to expose the s…
1dd3f9d 
…et method (#3774)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Apache9 added a commit that referenced this pull request Jan 2, 2022
@Apache9
HBASE-26386 Refactor StoreFileTracker implementations to expose the s…
d1ca261 
…et method (#3774)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Apache9 added a commit that referenced this pull request Jan 4, 2022
@Apache9
HBASE-26386 Refactor StoreFileTracker implementations to expose the s…
ca07fb8 
…et method (#3774)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
apurtell pushed a commit to apurtell/hbase that referenced this pull request Mar 18, 2022
@Apache9 @apurtell
HBASE-26386 Refactor StoreFileTracker implementations to expose the s…
436c592 
…et method (apache#3774)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
@apurtell apurtell mentioned this pull request Mar 18, 2022
Merged
apurtell pushed a commit to apurtell/hbase that referenced this pull request Mar 19, 2022
@Apache9 @apurtell
HBASE-26386 Refactor StoreFileTracker implementations to expose the s…
10d26dd 
…et method (apache#3774)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
apurtell pushed a commit to apurtell/hbase that referenced this pull request Mar 25, 2022
@Apache9 @apurtell
HBASE-26386 Refactor StoreFileTracker implementations to expose the s…
ba81d8e 
…et method (apache#3774)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
apurtell pushed a commit to apurtell/hbase that referenced this pull request Mar 26, 2022
@Apache9 @apurtell
HBASE-26386 Refactor StoreFileTracker implementations to expose the s…
9287a37 
…et method (apache#3774)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
apurtell added a commit to apurtell/hbase that referenced this pull request Mar 26, 2022
@apurtell
HBASE-26826 Backport StoreFileTracker (HBASE-26067, HBASE-26584, and …
4e80f0e 
…others) to branch-2.5

Previous cherry picks:

commit 6aaef89 HBASE-26064 Introduce a StoreFileTracker to abstract the store file tracking logic
commit 43b40e9 HBASE-25988 Store the store file list by a file apache#3578)
commit 6e05376 HBASE-26079 Use StoreFileTracker when splitting and merging apache#3617)
commit 090b2fe HBASE-26224 HBASE-26224 Introduce a MigrationStoreFileTracker to support migratin… apache#3656)
commit 0ee1689 HBASE-26246 Persist the StoreFileTracker configurations to TableDescriptor when creating table apache#3666)
commit 2052e80 HBASE-26248 Should find a suitable way to let users specify the store… apache#3665)
commit 5ff0f98 HBASE-26264 Add more checks to prevent misconfiguration on store file… apache#3681)
commit fc4f6d1 HBASE-26280 HBASE-26280 Use store file tracker when snapshoting apache#3685)
commit 06db852 HBASE-26326 CreateTableProcedure fails when FileBasedStoreFileTracker… apache#3721)
commit e4e7cf8 HBASE-26386 Refactor StoreFileTracker implementations to expose the s… apache#3774)
commit 08d1171 HBASE-26328 Clone snapshot doesn't load reference files into FILE SFT impl apache#3749)
commit 8bec26e HBASE-26263 [Rolling Upgrading] Persist the StoreFileTracker configur… apache#3700)
commit a288365 HBASE-26271: Cleanup the broken store files under data directory apache#3786)
commit d00b5fa HBASE-26454 CreateTableProcedure still relies on temp dir and renames… apache#3845)
commit 771e552 HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot
commit f16b7b1 HBASE-26265 Update ref guide to mention the new store file tracker im… apache#3942)
commit 755b3b4 HBASE-26585 Add SFT configuration to META table descriptor when creating META apache#3998)
commit 39c42c7 HBASE-26639 The implementation of TestMergesSplitsAddToTracker is pro… apache#4010)
commit 6e1f5b7 HBASE-26586 Should not rely on the global config when setting SFT implementation for a table while upgrading apache#4006)
commit f1dd865 HBASE-26654 ModifyTableDescriptorProcedure shoud load TableDescriptor… apache#4034)
commit 8fbc9a2 HBASE-26674 Should modify filesCompacting under storeWriteLock apache#4040)
commit 5aa0fd2 HBASE-26675 Data race on Compactor.writer apache#4035)
commit 3021c58 HBASE-26700 The way we bypass broken track file is not enough in Stor… apache#4055)
commit a8b68c9 HBASE-26690 Modify FSTableDescriptors to not rely on renaming when wr… apache#4054)
commit dffeb8e HBASE-26587 Introduce a new Admin API to change SFT implementation (#… apache#4080)
commit b265fe5 HBASE-26673 Implement a shell command for change SFT implementation apache#4113)
commit 4cdb380 HBASE-26640 Reimplement master local region initialization to better … apache#4111)
commit 77bb153 HBASE-26707: Reduce number of renames during bulkload (apache#4066) apache#4122)
commit a4b192e HBASE-26611 Changing SFT implementation on disabled table is dangerous apache#4082)
commit d3629bb HBASE-26837 Set SFT config when creating TableDescriptor in TestClone… apache#4226)
commit 541d748 HBASE-26881 Backport HBASE-25368 to branch-2 (apache#4267)

Fixups for precommit error prone, checkstyle, and javadoc warnings after applying cherry picks.

Signed-off-by: Josh Elser <elserj@apache.org>
Reviewed-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>
apurtell pushed a commit that referenced this pull request Mar 26, 2022
@Apache9 @apurtell
HBASE-26386 Refactor StoreFileTracker implementations to expose the s…
08d108d 
…et method (#3774)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
apurtell added a commit that referenced this pull request Mar 26, 2022
@apurtell
HBASE-26826 Backport StoreFileTracker (HBASE-26067, HBASE-26584, and …
6902cb2 
…others) to branch-2.5

Previous cherry picks:

commit 6aaef89 HBASE-26064 Introduce a StoreFileTracker to abstract the store file tracking logic
commit 43b40e9 HBASE-25988 Store the store file list by a file #3578)
commit 6e05376 HBASE-26079 Use StoreFileTracker when splitting and merging #3617)
commit 090b2fe HBASE-26224 HBASE-26224 Introduce a MigrationStoreFileTracker to support migratin… #3656)
commit 0ee1689 HBASE-26246 Persist the StoreFileTracker configurations to TableDescriptor when creating table #3666)
commit 2052e80 HBASE-26248 Should find a suitable way to let users specify the store… #3665)
commit 5ff0f98 HBASE-26264 Add more checks to prevent misconfiguration on store file… #3681)
commit fc4f6d1 HBASE-26280 HBASE-26280 Use store file tracker when snapshoting #3685)
commit 06db852 HBASE-26326 CreateTableProcedure fails when FileBasedStoreFileTracker… #3721)
commit e4e7cf8 HBASE-26386 Refactor StoreFileTracker implementations to expose the s… #3774)
commit 08d1171 HBASE-26328 Clone snapshot doesn't load reference files into FILE SFT impl #3749)
commit 8bec26e HBASE-26263 [Rolling Upgrading] Persist the StoreFileTracker configur… #3700)
commit a288365 HBASE-26271: Cleanup the broken store files under data directory #3786)
commit d00b5fa HBASE-26454 CreateTableProcedure still relies on temp dir and renames… #3845)
commit 771e552 HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot
commit f16b7b1 HBASE-26265 Update ref guide to mention the new store file tracker im… #3942)
commit 755b3b4 HBASE-26585 Add SFT configuration to META table descriptor when creating META #3998)
commit 39c42c7 HBASE-26639 The implementation of TestMergesSplitsAddToTracker is pro… #4010)
commit 6e1f5b7 HBASE-26586 Should not rely on the global config when setting SFT implementation for a table while upgrading #4006)
commit f1dd865 HBASE-26654 ModifyTableDescriptorProcedure shoud load TableDescriptor… #4034)
commit 8fbc9a2 HBASE-26674 Should modify filesCompacting under storeWriteLock #4040)
commit 5aa0fd2 HBASE-26675 Data race on Compactor.writer #4035)
commit 3021c58 HBASE-26700 The way we bypass broken track file is not enough in Stor… #4055)
commit a8b68c9 HBASE-26690 Modify FSTableDescriptors to not rely on renaming when wr… #4054)
commit dffeb8e HBASE-26587 Introduce a new Admin API to change SFT implementation (#… #4080)
commit b265fe5 HBASE-26673 Implement a shell command for change SFT implementation #4113)
commit 4cdb380 HBASE-26640 Reimplement master local region initialization to better … #4111)
commit 77bb153 HBASE-26707: Reduce number of renames during bulkload (#4066) #4122)
commit a4b192e HBASE-26611 Changing SFT implementation on disabled table is dangerous #4082)
commit d3629bb HBASE-26837 Set SFT config when creating TableDescriptor in TestClone… #4226)
commit 541d748 HBASE-26881 Backport HBASE-25368 to branch-2 (#4267)

Fixups for precommit error prone, checkstyle, and javadoc warnings after applying cherry picks.

Signed-off-by: Josh Elser <elserj@apache.org>
Reviewed-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
@Apache9
HBASE-26386 Refactor StoreFileTracker implementations to expose the s…
119b37e 
…et method (apache#3774)

Change-Id: I81358ccea535cf5d31e3b8d6a5529ef1e37956bd
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wchevreuil wchevreuil wchevreuil approved these changes

Assignees

@Apache9 Apache9

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Apache9 @Apache-HBase @wchevreuil