Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-26549 hbaseprotoc plugin should initialize maven #3927

Merged
merged 1 commit into from
Dec 14, 2021
Merged

HBASE-26549 hbaseprotoc plugin should initialize maven #3927

merged 1 commit into from
Dec 14, 2021

Conversation

ndimiduk
Copy link
Member

@ndimiduk ndimiduk commented Dec 9, 2021

Trying this. There's currently no way to test a change to the personality file from a pre-commit
check, so this must be committed to master or a feature branch in order to see its impact.

@ndimiduk
HBASE-26549 hbaseprotoc plugin should initialize maven
1bda583 
Trying this. There's currently no way to test a change to the personality file from a pre-commit
check, so this must be committed to master or a feature branch in order to see its impact.
@ndimiduk ndimiduk requested review from busbey and Apache9 December 9, 2021 00:19
@Apache-HBase
Copy link

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3927/1/console in case of problems.

2 similar comments
@Apache-HBase
Copy link

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3927/1/console in case of problems.

@Apache-HBase
Copy link

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3927/1/console in case of problems.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 27s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 20s Maven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗 mvndep 0m 7s Maven dependency ordering for patch
_ Other Tests _
1m 52s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3927/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #3927
Optional Tests
uname Linux a975d4638264 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / ca3ba49
Max. process+thread count 50 (vs. ulimit of 30000)
modules C: U:
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3927/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 27s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗 mvndep 0m 7s Maven dependency ordering for patch
_ Other Tests _
1m 54s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3927/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3927
Optional Tests
uname Linux 1b7aa5cb3dc9 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / ca3ba49
Max. process+thread count 54 (vs. ulimit of 30000)
modules C: U:
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3927/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 2m 59s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 shelldocs 0m 1s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗 mvndep 0m 6s Maven dependency ordering for patch
+1 💚 shellcheck 0m 2s There were no new shellcheck issues.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
_ Other Tests _
+0 🆗 asflicense 0m 0s ASF License check generated no output?
4m 34s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3927/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3927
Optional Tests dupname asflicense shellcheck shelldocs
uname Linux 9f534728defd 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / ca3ba49
Max. process+thread count 46 (vs. ulimit of 30000)
modules C: U:
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3927/1/console
versions git=2.17.1 maven=3.6.3 shellcheck=0.4.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ndimiduk
Copy link
Member Author

ndimiduk commented Dec 9, 2021

Oh. Maybe the above "patch to testing environment detected" means I can try this on a PR. Pushing this commit onto #3924

@ndimiduk ndimiduk mentioned this pull request Dec 9, 2021
Merged
@Apache9 Apache9 merged commit 96c971f into apache:master Dec 14, 2021
Apache9 pushed a commit that referenced this pull request Dec 14, 2021
@ndimiduk @Apache9
HBASE-26549 hbaseprotoc plugin should initialize maven (#3927)
348877d 
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Apache9 pushed a commit that referenced this pull request Dec 14, 2021
@ndimiduk @Apache9
HBASE-26549 hbaseprotoc plugin should initialize maven (#3927)
44f3008 
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Apache9 pushed a commit that referenced this pull request Dec 14, 2021
@ndimiduk @Apache9
HBASE-26549 hbaseprotoc plugin should initialize maven (#3927)
79b2a4d 
Signed-off-by: Duo Zhang <zhangduo@apache.org>
@ndimiduk
Copy link
Member Author

Thanks @Apache9 !

@ndimiduk ndimiduk deleted the 26549-hbaseprotoc-plugin-initialize-maven branch December 14, 2021 17:20
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
@ndimiduk @petersomogyi
HBASE-26549 hbaseprotoc plugin should initialize maven (apache#3927)
7e7f22f 
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 348877d)
Change-Id: Iba0dd6b31aba13eb26985d3ba9363203ab25f54c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Apache9 Apache9 Apache9 approved these changes

@busbey busbey Awaiting requested review from busbey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndimiduk @Apache-HBase @Apache9