Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-26555 Fix findbugs/spotbugs findings #3937

Open
wants to merge 1 commit into
base: branch-2
Choose a base branch
from
Open

HBASE-26555 Fix findbugs/spotbugs findings #3937

wants to merge 1 commit into from
+254 −218

Conversation

apurtell
Copy link
Contributor

Commits in the PR branch break down changes per module.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 44s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 23s Maven dependency ordering for branch
+1 💚 mvninstall 5m 3s branch-2 passed
+1 💚 compile 12m 13s branch-2 passed
+1 💚 checkstyle 5m 33s branch-2 passed
+1 💚 spotbugs 10m 37s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 4m 33s the patch passed
+1 💚 compile 11m 55s the patch passed
+1 💚 javac 0m 52s hbase-common in the patch passed.
+1 💚 javac 0m 23s hbase-metrics in the patch passed.
+1 💚 javac 1m 13s hbase-client generated 0 new + 157 unchanged - 1 fixed = 157 total (was 158)
+1 💚 javac 0m 29s hbase-zookeeper in the patch passed.
+1 💚 javac 0m 26s hbase-replication in the patch passed.
+1 💚 javac 0m 34s hbase-http in the patch passed.
+1 💚 javac 0m 30s hbase-asyncfs in the patch passed.
+1 💚 javac 0m 35s hbase-procedure in the patch passed.
+1 💚 javac 3m 30s hbase-server in the patch passed.
-0 ⚠️ javac 0m 51s hbase-mapreduce generated 1 new + 197 unchanged - 1 fixed = 198 total (was 198)
+1 💚 javac 0m 58s hbase-rsgroup generated 0 new + 190 unchanged - 1 fixed = 190 total (was 191)
-0 ⚠️ javac 0m 43s hbase-it generated 3 new + 100 unchanged - 3 fixed = 103 total (was 103)
-0 ⚠️ javac 0m 51s hbase-rest generated 1 new + 184 unchanged - 4 fixed = 185 total (was 188)
+1 💚 checkstyle 0m 25s The patch passed checkstyle in hbase-common
+1 💚 checkstyle 0m 11s The patch passed checkstyle in hbase-metrics
+1 💚 checkstyle 0m 37s The patch passed checkstyle in hbase-client
+1 💚 checkstyle 0m 15s The patch passed checkstyle in hbase-zookeeper
+1 💚 checkstyle 0m 13s The patch passed checkstyle in hbase-replication
+1 💚 checkstyle 0m 14s The patch passed checkstyle in hbase-http
+1 💚 checkstyle 0m 14s The patch passed checkstyle in hbase-asyncfs
-0 ⚠️ checkstyle 0m 15s hbase-procedure: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-0 ⚠️ checkstyle 1m 32s hbase-server: The patch generated 2 new + 763 unchanged - 10 fixed = 765 total (was 773)
+1 💚 checkstyle 0m 20s hbase-mapreduce: The patch generated 0 new + 86 unchanged - 1 fixed = 86 total (was 87)
+1 💚 checkstyle 0m 13s The patch passed checkstyle in hbase-rsgroup
+1 💚 checkstyle 0m 20s The patch passed checkstyle in hbase-it
+1 💚 checkstyle 0m 16s The patch passed checkstyle in hbase-rest
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 15m 25s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotbugs 12m 43s the patch passed
_ Other Tests _
+1 💚 asflicense 2m 29s The patch does not generate ASF License warnings.
101m 0s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3937
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname Linux 16412fdc97c3 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / bf6f946
Default Java AdoptOpenJDK-1.8.0_282-b08
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-mapreduce.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-it.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-rest.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-procedure.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count 87 (vs. ulimit of 12500)
modules C: hbase-common hbase-metrics hbase-client hbase-zookeeper hbase-replication hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-rsgroup hbase-it hbase-rest U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/1/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 36s Docker mode activated.
-0 ⚠️ yetus 0m 7s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 mvninstall 4m 54s branch-2 passed
+1 💚 compile 6m 29s branch-2 passed
+1 💚 shadedjars 7m 49s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 4m 53s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 22s Maven dependency ordering for patch
+1 💚 mvninstall 4m 29s the patch passed
+1 💚 compile 6m 32s the patch passed
+1 💚 javac 6m 32s the patch passed
+1 💚 shadedjars 7m 44s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 5m 9s the patch passed
_ Other Tests _
+1 💚 unit 1m 56s hbase-common in the patch passed.
+1 💚 unit 0m 22s hbase-metrics in the patch passed.
+1 💚 unit 2m 52s hbase-client in the patch passed.
+1 💚 unit 0m 44s hbase-zookeeper in the patch passed.
+1 💚 unit 0m 28s hbase-replication in the patch passed.
+1 💚 unit 0m 45s hbase-http in the patch passed.
+1 💚 unit 1m 25s hbase-asyncfs in the patch passed.
+1 💚 unit 1m 38s hbase-procedure in the patch passed.
-1 ❌ unit 136m 9s hbase-server in the patch failed.
+1 💚 unit 11m 46s hbase-mapreduce in the patch passed.
+1 💚 unit 3m 49s hbase-rsgroup in the patch passed.
+1 💚 unit 1m 14s hbase-it in the patch passed.
+1 💚 unit 3m 12s hbase-rest in the patch passed.
220m 38s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3937
Optional Tests javac javadoc unit shadedjars compile
uname Linux 5d38b58e3ea6 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / bf6f946
Default Java AdoptOpenJDK-11.0.10+9
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/1/testReport/
Max. process+thread count 3718 (vs. ulimit of 12500)
modules C: hbase-common hbase-metrics hbase-client hbase-zookeeper hbase-replication hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-rsgroup hbase-it hbase-rest U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 19s Docker mode activated.
-0 ⚠️ yetus 0m 7s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 mvninstall 4m 17s branch-2 passed
+1 💚 compile 5m 24s branch-2 passed
+1 💚 shadedjars 7m 10s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 4m 16s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 4m 5s the patch passed
+1 💚 compile 5m 23s the patch passed
+1 💚 javac 5m 23s the patch passed
+1 💚 shadedjars 7m 6s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 4m 5s the patch passed
_ Other Tests _
+1 💚 unit 1m 36s hbase-common in the patch passed.
+1 💚 unit 0m 19s hbase-metrics in the patch passed.
+1 💚 unit 2m 50s hbase-client in the patch passed.
+1 💚 unit 0m 46s hbase-zookeeper in the patch passed.
+1 💚 unit 0m 36s hbase-replication in the patch passed.
+1 💚 unit 1m 11s hbase-http in the patch passed.
+1 💚 unit 2m 19s hbase-asyncfs in the patch passed.
+1 💚 unit 2m 2s hbase-procedure in the patch passed.
-1 ❌ unit 219m 51s hbase-server in the patch failed.
+1 💚 unit 16m 12s hbase-mapreduce in the patch passed.
+1 💚 unit 4m 33s hbase-rsgroup in the patch passed.
+1 💚 unit 1m 11s hbase-it in the patch passed.
+1 💚 unit 5m 17s hbase-rest in the patch passed.
306m 44s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #3937
Optional Tests javac javadoc unit shadedjars compile
uname Linux 6797908d5380 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / bf6f946
Default Java AdoptOpenJDK-1.8.0_282-b08
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/1/testReport/
Max. process+thread count 2984 (vs. ulimit of 12500)
modules C: hbase-common hbase-metrics hbase-client hbase-zookeeper hbase-replication hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-rsgroup hbase-it hbase-rest U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@apurtell
Copy link
Contributor Author

Fix LoadTestKVGenerator related failures.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 2m 26s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 2s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
+1 💚 mvninstall 4m 38s branch-2 passed
+1 💚 compile 12m 14s branch-2 passed
+1 💚 checkstyle 4m 55s branch-2 passed
+1 💚 spotbugs 11m 15s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 4m 19s the patch passed
+1 💚 compile 12m 18s the patch passed
+1 💚 javac 0m 52s hbase-common in the patch passed.
+1 💚 javac 0m 22s hbase-metrics in the patch passed.
+1 💚 javac 1m 12s hbase-client generated 0 new + 157 unchanged - 1 fixed = 157 total (was 158)
+1 💚 javac 0m 31s hbase-zookeeper in the patch passed.
+1 💚 javac 0m 26s hbase-replication in the patch passed.
+1 💚 javac 0m 32s hbase-http in the patch passed.
+1 💚 javac 0m 30s hbase-asyncfs in the patch passed.
+1 💚 javac 0m 33s hbase-procedure in the patch passed.
+1 💚 javac 3m 41s hbase-server in the patch passed.
-0 ⚠️ javac 0m 55s hbase-mapreduce generated 1 new + 197 unchanged - 1 fixed = 198 total (was 198)
+1 💚 javac 1m 4s hbase-rsgroup generated 0 new + 190 unchanged - 1 fixed = 190 total (was 191)
-0 ⚠️ javac 0m 44s hbase-it generated 3 new + 100 unchanged - 3 fixed = 103 total (was 103)
-0 ⚠️ javac 0m 56s hbase-rest generated 1 new + 184 unchanged - 4 fixed = 185 total (was 188)
+1 💚 checkstyle 0m 27s The patch passed checkstyle in hbase-common
+1 💚 checkstyle 0m 12s The patch passed checkstyle in hbase-metrics
+1 💚 checkstyle 0m 37s The patch passed checkstyle in hbase-client
+1 💚 checkstyle 0m 13s The patch passed checkstyle in hbase-zookeeper
+1 💚 checkstyle 0m 13s The patch passed checkstyle in hbase-replication
+1 💚 checkstyle 0m 13s The patch passed checkstyle in hbase-http
+1 💚 checkstyle 0m 12s The patch passed checkstyle in hbase-asyncfs
-0 ⚠️ checkstyle 0m 15s hbase-procedure: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-0 ⚠️ checkstyle 1m 32s hbase-server: The patch generated 2 new + 763 unchanged - 10 fixed = 765 total (was 773)
+1 💚 checkstyle 0m 22s hbase-mapreduce: The patch generated 0 new + 86 unchanged - 1 fixed = 86 total (was 87)
+1 💚 checkstyle 0m 15s The patch passed checkstyle in hbase-rsgroup
+1 💚 checkstyle 0m 18s The patch passed checkstyle in hbase-it
+1 💚 checkstyle 0m 17s The patch passed checkstyle in hbase-rest
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 14m 53s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotbugs 14m 9s the patch passed
_ Other Tests _
+1 💚 asflicense 2m 32s The patch does not generate ASF License warnings.
102m 41s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3937
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname Linux 2a25e9c8f626 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / bf6f946
Default Java AdoptOpenJDK-1.8.0_282-b08
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/2/artifact/yetus-general-check/output/diff-compile-javac-hbase-mapreduce.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/2/artifact/yetus-general-check/output/diff-compile-javac-hbase-it.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/2/artifact/yetus-general-check/output/diff-compile-javac-hbase-rest.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-procedure.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count 86 (vs. ulimit of 12500)
modules C: hbase-common hbase-metrics hbase-client hbase-zookeeper hbase-replication hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-rsgroup hbase-it hbase-rest U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/2/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 31s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for branch
+1 💚 mvninstall 3m 44s branch-2 passed
+1 💚 compile 5m 36s branch-2 passed
+1 💚 shadedjars 6m 34s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 4m 26s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for patch
+1 💚 mvninstall 3m 31s the patch passed
+1 💚 compile 5m 36s the patch passed
+1 💚 javac 5m 36s the patch passed
+1 💚 shadedjars 6m 31s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 4m 25s the patch passed
_ Other Tests _
+1 💚 unit 1m 35s hbase-common in the patch passed.
+1 💚 unit 0m 21s hbase-metrics in the patch passed.
+1 💚 unit 2m 49s hbase-client in the patch passed.
+1 💚 unit 0m 46s hbase-zookeeper in the patch passed.
+1 💚 unit 0m 26s hbase-replication in the patch passed.
+1 💚 unit 0m 52s hbase-http in the patch passed.
+1 💚 unit 1m 44s hbase-asyncfs in the patch passed.
+1 💚 unit 1m 48s hbase-procedure in the patch passed.
+1 💚 unit 145m 39s hbase-server in the patch passed.
+1 💚 unit 11m 38s hbase-mapreduce in the patch passed.
+1 💚 unit 3m 24s hbase-rsgroup in the patch passed.
+1 💚 unit 1m 17s hbase-it in the patch passed.
+1 💚 unit 4m 8s hbase-rest in the patch passed.
223m 0s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #3937
Optional Tests javac javadoc unit shadedjars compile
uname Linux cfc03fbefea5 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / bf6f946
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/2/testReport/
Max. process+thread count 3997 (vs. ulimit of 12500)
modules C: hbase-common hbase-metrics hbase-client hbase-zookeeper hbase-replication hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-rsgroup hbase-it hbase-rest U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 30s Docker mode activated.
-0 ⚠️ yetus 0m 8s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for branch
+1 💚 mvninstall 4m 44s branch-2 passed
+1 💚 compile 6m 25s branch-2 passed
+1 💚 shadedjars 7m 23s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 5m 9s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 21s Maven dependency ordering for patch
+1 💚 mvninstall 4m 25s the patch passed
+1 💚 compile 6m 32s the patch passed
+1 💚 javac 6m 32s the patch passed
+1 💚 shadedjars 7m 14s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 4m 56s the patch passed
_ Other Tests _
+1 💚 unit 1m 49s hbase-common in the patch passed.
+1 💚 unit 0m 25s hbase-metrics in the patch passed.
+1 💚 unit 3m 0s hbase-client in the patch passed.
+1 💚 unit 0m 45s hbase-zookeeper in the patch passed.
+1 💚 unit 0m 41s hbase-replication in the patch passed.
+1 💚 unit 0m 47s hbase-http in the patch passed.
+1 💚 unit 1m 35s hbase-asyncfs in the patch passed.
+1 💚 unit 1m 36s hbase-procedure in the patch passed.
+1 💚 unit 160m 43s hbase-server in the patch passed.
+1 💚 unit 13m 56s hbase-mapreduce in the patch passed.
+1 💚 unit 4m 36s hbase-rsgroup in the patch passed.
+1 💚 unit 1m 18s hbase-it in the patch passed.
+1 💚 unit 3m 28s hbase-rest in the patch passed.
248m 41s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3937
Optional Tests javac javadoc unit shadedjars compile
uname Linux 40850b82a80f 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / bf6f946
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/2/testReport/
Max. process+thread count 4472 (vs. ulimit of 12500)
modules C: hbase-common hbase-metrics hbase-client hbase-zookeeper hbase-replication hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-rsgroup hbase-it hbase-rest U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

sunhelly
sunhelly reviewed Dec 13, 2021
View reviewed changes
Copy link
Contributor

@sunhelly sunhelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Please fix the check style issues.

@apurtell
Copy link
Contributor Author

apurtell commented Dec 15, 2021 •
edited
Loading

I am going to split the Random changes into a separate JIRA and PR because that part has taken on a life of its own.

Edit: It is HBASE-26582

@apurtell apurtell force-pushed the HBASE-26555-branch-2 branch from 2cf6ebc to 0b49f88 Compare December 15, 2021 18:21
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 8m 33s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for branch
+1 💚 mvninstall 4m 9s branch-2 passed
+1 💚 compile 9m 44s branch-2 passed
+1 💚 checkstyle 3m 46s branch-2 passed
+1 💚 spotbugs 8m 23s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
-1 ❌ mvninstall 3m 33s root in the patch failed.
-1 ❌ compile 0m 34s hbase-it in the patch failed.
+1 💚 javac 0m 49s hbase-common in the patch passed.
+1 💚 javac 1m 6s hbase-client generated 0 new + 158 unchanged - 1 fixed = 158 total (was 159)
+1 💚 javac 0m 32s hbase-http in the patch passed.
+1 💚 javac 0m 31s hbase-procedure in the patch passed.
+1 💚 javac 3m 12s hbase-server in the patch passed.
-0 ⚠️ javac 0m 51s hbase-mapreduce generated 1 new + 197 unchanged - 1 fixed = 198 total (was 198)
+1 💚 javac 0m 56s hbase-rsgroup in the patch passed.
-0 ⚠️ javac 0m 34s hbase-it in the patch failed.
-0 ⚠️ javac 0m 51s hbase-rest generated 1 new + 184 unchanged - 4 fixed = 185 total (was 188)
+1 💚 checkstyle 0m 25s The patch passed checkstyle in hbase-common
+1 💚 checkstyle 0m 38s hbase-client: The patch generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4)
+1 💚 checkstyle 0m 15s The patch passed checkstyle in hbase-http
-0 ⚠️ checkstyle 0m 15s hbase-procedure: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚 checkstyle 1m 18s The patch passed checkstyle in hbase-server
+1 💚 checkstyle 0m 18s The patch passed checkstyle in hbase-mapreduce
+1 💚 checkstyle 0m 15s The patch passed checkstyle in hbase-rsgroup
+1 💚 checkstyle 0m 18s The patch passed checkstyle in hbase-it
+1 💚 checkstyle 0m 16s The patch passed checkstyle in hbase-rest
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
-1 ❌ hadoopcheck 3m 30s The patch causes 24 errors with Hadoop v3.1.2.
-1 ❌ hadoopcheck 7m 29s The patch causes 24 errors with Hadoop v3.2.1.
-1 ❌ spotbugs 0m 31s hbase-it in the patch failed.
_ Other Tests _
+1 💚 asflicense 1m 51s The patch does not generate ASF License warnings.
77m 30s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3937
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname Linux 7e006f948c4d 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / c7a8e42
Default Java AdoptOpenJDK-1.8.0_282-b08
mvninstall https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/artifact/yetus-general-check/output/patch-compile-hbase-it.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/artifact/yetus-general-check/output/diff-compile-javac-hbase-mapreduce.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/artifact/yetus-general-check/output/patch-compile-hbase-it.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/artifact/yetus-general-check/output/diff-compile-javac-hbase-rest.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-procedure.txt
hadoopcheck https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/artifact/yetus-general-check/output/patch-javac-3.1.2.txt
hadoopcheck https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/artifact/yetus-general-check/output/patch-javac-3.2.1.txt
spotbugs https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/artifact/yetus-general-check/output/patch-spotbugs-hbase-it.txt
Max. process+thread count 96 (vs. ulimit of 12500)
modules C: hbase-common hbase-client hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-rsgroup hbase-it hbase-rest U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 9m 34s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 mvninstall 4m 3s branch-2 passed
+1 💚 compile 4m 32s branch-2 passed
+1 💚 shadedjars 6m 42s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 23s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for patch
-1 ❌ mvninstall 3m 31s root in the patch failed.
-1 ❌ compile 0m 26s hbase-it in the patch failed.
-0 ⚠️ javac 0m 26s hbase-it in the patch failed.
+1 💚 shadedjars 6m 52s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 23s the patch passed
_ Other Tests _
+1 💚 unit 1m 38s hbase-common in the patch passed.
+1 💚 unit 2m 38s hbase-client in the patch passed.
+1 💚 unit 1m 6s hbase-http in the patch passed.
+1 💚 unit 1m 45s hbase-procedure in the patch passed.
+1 💚 unit 154m 1s hbase-server in the patch passed.
+1 💚 unit 13m 28s hbase-mapreduce in the patch passed.
+1 💚 unit 4m 42s hbase-rsgroup in the patch passed.
-1 ❌ unit 0m 46s hbase-it in the patch failed.
+1 💚 unit 4m 26s hbase-rest in the patch passed.
235m 45s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #3937
Optional Tests javac javadoc unit shadedjars compile
uname Linux 6daacbf06b36 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / c7a8e42
Default Java AdoptOpenJDK-1.8.0_282-b08
mvninstall https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/artifact/yetus-jdk8-hadoop2-check/output/patch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-it.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-it.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-it.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/testReport/
Max. process+thread count 3718 (vs. ulimit of 12500)
modules C: hbase-common hbase-client hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-rsgroup hbase-it hbase-rest U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 31s Docker mode activated.
-0 ⚠️ yetus 0m 8s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 42s Maven dependency ordering for branch
+1 💚 mvninstall 5m 35s branch-2 passed
+1 💚 compile 5m 13s branch-2 passed
+1 💚 shadedjars 8m 16s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 36s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
-1 ❌ mvninstall 4m 44s root in the patch failed.
-1 ❌ compile 0m 35s hbase-it in the patch failed.
-0 ⚠️ javac 0m 35s hbase-it in the patch failed.
+1 💚 shadedjars 8m 30s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 4m 2s the patch passed
_ Other Tests _
+1 💚 unit 2m 10s hbase-common in the patch passed.
+1 💚 unit 3m 7s hbase-client in the patch passed.
+1 💚 unit 0m 56s hbase-http in the patch passed.
+1 💚 unit 2m 8s hbase-procedure in the patch passed.
+1 💚 unit 209m 41s hbase-server in the patch passed.
+1 💚 unit 15m 5s hbase-mapreduce in the patch passed.
+1 💚 unit 4m 20s hbase-rsgroup in the patch passed.
-1 ❌ unit 0m 43s hbase-it in the patch failed.
+1 💚 unit 4m 23s hbase-rest in the patch passed.
294m 38s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3937
Optional Tests javac javadoc unit shadedjars compile
uname Linux 45c35bea82e8 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / c7a8e42
Default Java AdoptOpenJDK-11.0.10+9
mvninstall https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-it.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-it.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-it.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/testReport/
Max. process+thread count 3080 (vs. ulimit of 12500)
modules C: hbase-common hbase-client hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-rsgroup hbase-it hbase-rest U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

joshelser
joshelser approved these changes Jan 4, 2022
View reviewed changes
Copy link
Member

@joshelser joshelser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshelser
Copy link
Member

Oh bother, now I see #3936 has the same changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunhelly sunhelly sunhelly left review comments

@joshelser joshelser joshelser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@apurtell @Apache-HBase @joshelser @sunhelly