HBASE-26474 Implement connection-level attributes #3952

ndimiduk · 2021-12-15T23:05:45Z

Add support for db.system, db.connection_string, db.user.

As per https://github.com/open-telemetry/opentelemetry-specification/blob/3e380e249f60c3a5f68746f5e84d10195ba41a79/specification/trace/semantic_conventions/database.md

hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRegionLocator.java

Apache9 · 2021-12-17T02:14:45Z

hbase-client/src/main/java/org/apache/hadoop/hbase/client/trace/TableOperationSpanBuilder.java

+
+  @Override
+  @SuppressWarnings("unchecked")
+  public B self() {


Why we need to have so complicated class hierarchy? A class has a generic type parameter which is just itself?

I don't like it either. Java really sucks for inheritance with the builder pattern. I could try to rebuild it using mix-ins, but I think that will be equally complex.

I've pushed a change that replaces build inheritance with a mix-in style of builder. I don't really like it any better, let me know what you think.

hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncTableTracing.java

hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRegionLocator.java

hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncRegionLocatorTracing.java

Apache9

Overall LGTM.

Just a minor question on the naming, not a veto. I'm not sure if there are other meanings for a connection string so you choose to use something like a hostname. Just go with your opinion.

Apache9 · 2021-12-23T00:21:18Z

hbase-server/src/main/java/org/apache/hadoop/hbase/client/ShortCircuitConnectionRegistry.java

@@ -68,6 +68,11 @@ public ShortCircuitConnectionRegistry(ConnectionRegistryEndpoint endpoint) {
    return future;
  }

+  @Override
+  public String getConnectionString() {
+    return "localhost";


Maybe just call it short-circuit? I do not think localhost is accurate enough, it may implies that we are connecting to a regsitry through network but on the same machine? For short-circuit we know that we are using the ShortCircuitConnectionRegistry.

This is a good point; localhost does have a specific meaning. Let me consider it, perhaps I can propose a better name. "short-circuit" isn't too bad.

Apache-HBase · 2021-12-23T00:46:20Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 20s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 28s	master passed
+1 💚	compile	5m 5s	master passed
+1 💚	checkstyle	2m 1s	master passed
+1 💚	spotbugs	3m 56s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 15s	the patch passed
+1 💚	compile	5m 7s	the patch passed
+1 💚	javac	5m 7s	the patch passed
+1 💚	checkstyle	2m 5s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	21m 40s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	4m 31s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 35s	The patch does not generate ASF License warnings.
		64m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3952/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3952
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux b116f0d0b1fd 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f16b7b1`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	85 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3952/4/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-12-23T02:50:20Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 9s	master passed
+1 💚	compile	1m 55s	master passed
+1 💚	shadedjars	8m 23s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 27s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 53s	the patch passed
+1 💚	compile	1m 55s	the patch passed
+1 💚	javac	1m 55s	the patch passed
+1 💚	shadedjars	8m 15s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 27s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 43s	hbase-common in the patch passed.
+1 💚	unit	1m 21s	hbase-client in the patch passed.
-1 ❌	unit	150m 29s	hbase-server in the patch failed.
		188m 56s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3952/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3952
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 366e8bf224c9 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f16b7b1`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3952/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3952/4/testReport/
Max. process+thread count	3908 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3952/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-12-23T03:49:19Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 4s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 14s	master passed
+1 💚	compile	2m 18s	master passed
+1 💚	shadedjars	9m 8s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 33s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 3s	the patch passed
+1 💚	compile	2m 17s	the patch passed
+1 💚	javac	2m 17s	the patch passed
+1 💚	shadedjars	9m 4s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 32s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 43s	hbase-common in the patch passed.
+1 💚	unit	1m 42s	hbase-client in the patch passed.
+1 💚	unit	203m 37s	hbase-server in the patch passed.
		247m 56s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3952/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3952
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux affd4cd8d81e 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f16b7b1`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3952/4/testReport/
Max. process+thread count	2746 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3952/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Add support for `db.system`, `db.connection_string`, `db.user`.

* address checkstyle complaints * remove member variable `user` from TestAsyncTableTracing

* replace inheritance in *SpanBuilders with a mix-in approach

Apache-HBase · 2022-01-05T18:42:10Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 20s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 35s	master passed
+1 💚	compile	5m 9s	master passed
+1 💚	checkstyle	2m 4s	master passed
+1 💚	spotbugs	4m 2s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 15s	the patch passed
+1 💚	compile	5m 7s	the patch passed
+1 💚	javac	5m 7s	the patch passed
+1 💚	checkstyle	2m 1s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	21m 50s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	4m 36s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 35s	The patch does not generate ASF License warnings.
		65m 23s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3952/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3952
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 134e29479239 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `baeb51f`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3952/5/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-01-05T20:44:52Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 4s	master passed
+1 💚	compile	1m 56s	master passed
+1 💚	shadedjars	8m 22s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 26s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 53s	the patch passed
+1 💚	compile	1m 53s	the patch passed
+1 💚	javac	1m 53s	the patch passed
+1 💚	shadedjars	8m 22s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 25s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 42s	hbase-common in the patch passed.
+1 💚	unit	1m 22s	hbase-client in the patch passed.
+1 💚	unit	150m 10s	hbase-server in the patch passed.
		188m 3s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3952/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3952
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux cf60ce1249b8 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `baeb51f`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3952/5/testReport/
Max. process+thread count	3954 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3952/5/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-01-05T21:50:51Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 1s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 21s	master passed
+1 💚	compile	2m 17s	master passed
+1 💚	shadedjars	9m 19s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 34s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 6s	the patch passed
+1 💚	compile	2m 16s	the patch passed
+1 💚	javac	2m 16s	the patch passed
+1 💚	shadedjars	9m 18s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 31s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 16s	hbase-common in the patch passed.
+1 💚	unit	1m 47s	hbase-client in the patch passed.
-1 ❌	unit	209m 35s	hbase-server in the patch failed.
		254m 2s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3952/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3952
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux ecc40f0727d4 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `baeb51f`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3952/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3952/5/testReport/
Max. process+thread count	2762 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3952/5/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

ndimiduk · 2022-01-05T23:32:26Z

Thank you, @Apache9 !

Add support for `db.system`, `db.connection_string`, `db.user`. Signed-off-by: Duo Zhang <zhangduo@apache.org>

ndimiduk requested review from taklwu and Apache9 December 15, 2021 23:05

This comment has been minimized.

Sign in to view

Apache9 reviewed Dec 17, 2021

View reviewed changes

ndimiduk force-pushed the 26474-tracing-connection-level-attributes branch from 6df2a9d to 7df1343 Compare December 17, 2021 20:28

This comment has been minimized.

Sign in to view

ndimiduk requested a review from Apache9 December 20, 2021 17:56

Apache9 reviewed Dec 21, 2021

View reviewed changes

hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRegionLocator.java Outdated Show resolved Hide resolved

hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncRegionLocatorTracing.java Show resolved Hide resolved

ndimiduk force-pushed the 26474-tracing-connection-level-attributes branch from 3dc359f to c39630d Compare December 22, 2021 23:40

Apache9 approved these changes Dec 23, 2021

View reviewed changes

ndimiduk added 5 commits January 5, 2022 09:17

HBASE-26474 Implement connection-level attributes

e3c0158

Add support for `db.system`, `db.connection_string`, `db.user`.

PR Feedback

262f85f

* address checkstyle complaints * remove member variable `user` from TestAsyncTableTracing

PR Feedback

e906647

* replace inheritance in *SpanBuilders with a mix-in approach

PR Feedback

ea144c4

PR Feedback

acfac73

ndimiduk force-pushed the 26474-tracing-connection-level-attributes branch from c39630d to acfac73 Compare January 5, 2022 17:35

ndimiduk merged commit 5cb7ed8 into apache:master Jan 5, 2022

ndimiduk deleted the 26474-tracing-connection-level-attributes branch January 5, 2022 23:32

ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Jan 6, 2022

HBASE-26474 Implement connection-level attributes (apache#3952)

486eb4d

Add support for `db.system`, `db.connection_string`, `db.user`. Signed-off-by: Duo Zhang <zhangduo@apache.org>

ndimiduk mentioned this pull request Jan 6, 2022

Backport "HBASE-26474 Implement connection-level attributes" to branch-2 #4014

Merged

ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Jan 12, 2022

HBASE-26474 Implement connection-level attributes (apache#3952)

706be8a

Add support for `db.system`, `db.connection_string`, `db.user`. Signed-off-by: Duo Zhang <zhangduo@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-26474 Implement connection-level attributes #3952

HBASE-26474 Implement connection-level attributes #3952

ndimiduk commented Dec 15, 2021

This comment has been minimized.

This comment has been minimized.

Apache9 Dec 17, 2021

ndimiduk Dec 17, 2021

ndimiduk Dec 17, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Apache9 left a comment

Apache9 Dec 23, 2021

ndimiduk Dec 23, 2021

Apache-HBase commented Dec 23, 2021

Apache-HBase commented Dec 23, 2021

Apache-HBase commented Dec 23, 2021

Apache-HBase commented Jan 5, 2022

Apache-HBase commented Jan 5, 2022

Apache-HBase commented Jan 5, 2022

ndimiduk commented Jan 5, 2022

HBASE-26474 Implement connection-level attributes #3952

HBASE-26474 Implement connection-level attributes #3952

Conversation

ndimiduk commented Dec 15, 2021

This comment has been minimized.

This comment has been minimized.

Apache9 Dec 17, 2021

Choose a reason for hiding this comment

ndimiduk Dec 17, 2021

Choose a reason for hiding this comment

ndimiduk Dec 17, 2021

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Apache9 left a comment

Choose a reason for hiding this comment

Apache9 Dec 23, 2021

Choose a reason for hiding this comment

ndimiduk Dec 23, 2021

Choose a reason for hiding this comment

Apache-HBase commented Dec 23, 2021

Apache-HBase commented Dec 23, 2021

Apache-HBase commented Dec 23, 2021

Apache-HBase commented Jan 5, 2022

Apache-HBase commented Jan 5, 2022

Apache-HBase commented Jan 5, 2022

ndimiduk commented Jan 5, 2022