-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-26552 Introduce retry to logroller to avoid abort #4038
Conversation
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
I think we already have retries when creating the writer? See FanOutOneBlockAsyncDFSOutputHelper.createOutput. |
Sorry for the late reply, @Apache9 . |
OK, I got your point. But two levels of retry will greatly increase the duration of retries... If this is the case, maybe we should move the retry to the upper layer only? Not sure if this will work, but for me, introducing another retry layer will introduce another problem while solving a problem... |
Thanks @Apache9 , I'll try the retry on the upper layer and test if it works. |
🎊 +1 overall
This message was automatically generated. |
6f7fef6
to
fc69bc4
Compare
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
fc69bc4
to
2874ee9
Compare
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractWALRoller.java
Outdated
Show resolved
Hide resolved
2874ee9
to
84667f0
Compare
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
No description provided.