Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-26784 Addendum: Close scanner request should properly inherit original timeout and priority #4183

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

bbeaudreault
Copy link
Contributor

Fixes a bug in the original implementation in #4163, wherein we attempted to inherit the original controller priority/timeout but accidentally was using the same HBaseRpcController for both reading and writing the fields.

Improves tests to ensure that we are properly inheriting these fields.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 29s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚 mvninstall 3m 0s branch-2 passed
+1 💚 compile 0m 22s branch-2 passed
+1 💚 shadedjars 3m 31s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 22s branch-2 passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 47s the patch passed
+1 💚 compile 0m 21s the patch passed
+1 💚 javac 0m 21s the patch passed
+1 💚 shadedjars 3m 29s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 19s the patch passed
_ Other Tests _
+1 💚 unit 3m 24s hbase-client in the patch passed.
19m 13s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4183/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #4183
Optional Tests javac javadoc unit shadedjars compile
uname Linux 1f89d90ca5eb 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 5bae04e
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4183/1/testReport/
Max. process+thread count 157 (vs. ulimit of 12500)
modules C: hbase-client U: hbase-client
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4183/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@bbeaudreault bbeaudreault force-pushed the HBASE-26784-2-addendum branch from 53402aa to aa6f13e Compare March 8, 2022 15:46
@bbeaudreault
Copy link
Contributor Author

bbeaudreault commented Mar 8, 2022

Build failed due to "no space left on device". Force pushed to re-run build, hopefully I'll get a different host.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 28s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚 mvninstall 2m 39s branch-2 passed
+1 💚 compile 0m 22s branch-2 passed
+1 💚 shadedjars 3m 29s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 19s branch-2 passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 49s the patch passed
+1 💚 compile 0m 21s the patch passed
+1 💚 javac 0m 21s the patch passed
+1 💚 shadedjars 3m 29s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 19s the patch passed
_ Other Tests _
+1 💚 unit 3m 27s hbase-client in the patch passed.
18m 54s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4183/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #4183
Optional Tests javac javadoc unit shadedjars compile
uname Linux a230ca7c0e87 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 5bae04e
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4183/2/testReport/
Max. process+thread count 157 (vs. ulimit of 12500)
modules C: hbase-client U: hbase-client
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4183/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@apurtell apurtell merged commit 98836fb into apache:branch-2 Mar 8, 2022
asfgit pushed a commit that referenced this pull request Mar 8, 2022
…riginal timeout and priority (#4183)

Signed-off-by: Andrew Purtell <apurtell@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants