HBASE-26840 Fix NPE in the retry of logroller #4224

sunhelly · 2022-03-15T02:46:09Z

No description provided.

Apache-HBase · 2022-03-15T03:05:02Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --quick-hadoopcheck --exclude-tests-url --asf-nightlies-general-check-base --build-thread --surefire-first-part-fork-count --surefire-second-part-fork-count
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	6m 25s	master passed
+1 💚	compile	0m 43s	master passed
+1 💚	checkstyle	0m 40s	master passed
+1 💚	spotbugs	1m 31s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 41s	the patch passed
+1 💚	compile	0m 37s	the patch passed
+1 💚	javac	0m 37s	the patch passed
+1 💚	checkstyle	0m 36s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	spotbugs	1m 33s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 9s	The patch does not generate ASF License warnings.
		14m 34s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4224/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4224
Optional Tests	dupname asflicense javac spotbugs checkstyle compile
uname	Linux 17279bdbadcc 5.4.0-1043-aws #45~18.04.1-Ubuntu SMP Fri Apr 9 23:32:25 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f640b7f`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	57 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4224/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-15T05:26:43Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 2s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck --skip-errorprone --exclude-tests-url --build-thread --surefire-first-part-fork-count --surefire-second-part-fork-count
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 9s	master passed
+1 💚	compile	0m 38s	master passed
+1 💚	javadoc	0m 26s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 42s	the patch passed
+1 💚	compile	0m 39s	the patch passed
+1 💚	javac	0m 39s	the patch passed
+1 💚	javadoc	0m 24s	the patch passed
		_ Other Tests _
-1 ❌	unit	146m 50s	hbase-server in the patch failed.
		156m 17s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4224/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4224
Optional Tests	javac javadoc unit compile
uname	Linux 48b52a624e9e 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f640b7f`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4224/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4224/1/testReport/
Max. process+thread count	2214 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4224/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-15T06:07:29Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 9s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck --skip-errorprone --exclude-tests-url --build-thread --surefire-first-part-fork-count --surefire-second-part-fork-count
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	6m 55s	master passed
+1 💚	compile	1m 12s	master passed
+1 💚	javadoc	0m 41s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	1m 20s	the patch passed
+1 💚	compile	1m 13s	the patch passed
+1 💚	javac	1m 13s	the patch passed
+1 💚	javadoc	0m 39s	the patch passed
		_ Other Tests _
+1 💚	unit	182m 35s	hbase-server in the patch passed.
		196m 58s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4224/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4224
Optional Tests	javac javadoc unit compile
uname	Linux 890a9a086d1d 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f640b7f`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4224/1/testReport/
Max. process+thread count	1866 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4224/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

virajjasani · 2022-03-15T07:49:26Z

hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractWALRoller.java

@@ -223,8 +223,7 @@ public void run() {
              if (waitingTime < rollWaitTimeout && nAttempts < maxRollRetry) {
                nAttempts++;
                LOG.warn("Retry to roll log, nAttempts={}, waiting time={}ms, sleeping 1s to retry,"
-                    + " last excepiton= {}", nAttempts, waitingTime,
-                  ioe.getCause().getClass().getSimpleName());
+                    + " last excepiton= {}", nAttempts, waitingTime, ioe);


nit: no need to add {} after last excepiton, keeping ioe as the last arg will print the whole Exception stacktrace.

Thanks, I'll remove it.

Apache-HBase · 2022-03-15T10:22:31Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --quick-hadoopcheck --exclude-tests-url --asf-nightlies-general-check-base --build-thread --surefire-first-part-fork-count --surefire-second-part-fork-count
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 59s	master passed
+1 💚	compile	0m 42s	master passed
+1 💚	checkstyle	0m 37s	master passed
+1 💚	spotbugs	1m 23s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 43s	the patch passed
+1 💚	compile	0m 40s	the patch passed
+1 💚	javac	0m 40s	the patch passed
+1 💚	checkstyle	0m 36s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	spotbugs	1m 33s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 6s	The patch does not generate ASF License warnings.
		12m 3s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4224/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4224
Optional Tests	dupname asflicense javac spotbugs checkstyle compile
uname	Linux e41e66db8413 5.4.0-1043-aws #45~18.04.1-Ubuntu SMP Fri Apr 9 23:32:25 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `cc2c220`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	57 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4224/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-15T12:53:59Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 2s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck --skip-errorprone --exclude-tests-url --build-thread --surefire-first-part-fork-count --surefire-second-part-fork-count
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 41s	master passed
+1 💚	compile	0m 39s	master passed
+1 💚	javadoc	0m 23s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 41s	the patch passed
+1 💚	compile	0m 39s	the patch passed
+1 💚	javac	0m 39s	the patch passed
+1 💚	javadoc	0m 24s	the patch passed
		_ Other Tests _
-1 ❌	unit	155m 9s	hbase-server in the patch failed.
		163m 44s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4224/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4224
Optional Tests	javac javadoc unit compile
uname	Linux 2074fca0b561 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `cc2c220`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4224/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4224/2/testReport/
Max. process+thread count	3052 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4224/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-15T13:27:49Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 6s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck --skip-errorprone --exclude-tests-url --build-thread --surefire-first-part-fork-count --surefire-second-part-fork-count
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	6m 59s	master passed
+1 💚	compile	1m 19s	master passed
+1 💚	javadoc	0m 41s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	1m 17s	the patch passed
+1 💚	compile	1m 12s	the patch passed
+1 💚	javac	1m 12s	the patch passed
+1 💚	javadoc	0m 39s	the patch passed
		_ Other Tests _
-1 ❌	unit	182m 48s	hbase-server in the patch failed.
		197m 16s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4224/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4224
Optional Tests	javac javadoc unit compile
uname	Linux 424b376e4fbd 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `cc2c220`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4224/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4224/2/testReport/
Max. process+thread count	1823 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4224/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Signed-off-by: Duo Zhang <zhangduo@apache.org>

Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit 31cb0b8) Change-Id: I42bb559ba29417f43d17e1db893141656d87b806

HBASE-26840 Fix NPE in the retry of logroller

e0247b0

virajjasani previously approved these changes Mar 15, 2022

View reviewed changes

virajjasani reviewed Mar 15, 2022

View reviewed changes

remove {} for exception stacktrace

443891e

Apache9 approved these changes Mar 15, 2022

View reviewed changes

sunhelly merged commit fb09cb9 into apache:master Mar 15, 2022

asfgit pushed a commit that referenced this pull request Mar 15, 2022

HBASE-26840 Fix NPE in the retry of logroller (#4224)

31cb0b8

Signed-off-by: Duo Zhang <zhangduo@apache.org>

asfgit pushed a commit that referenced this pull request Mar 15, 2022

HBASE-26840 Fix NPE in the retry of logroller (#4224)

46af73b

Signed-off-by: Duo Zhang <zhangduo@apache.org>

asfgit pushed a commit that referenced this pull request Mar 15, 2022

HBASE-26840 Fix NPE in the retry of logroller (#4224)

8349965

Signed-off-by: Duo Zhang <zhangduo@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-26840 Fix NPE in the retry of logroller #4224

HBASE-26840 Fix NPE in the retry of logroller #4224

sunhelly commented Mar 15, 2022

Apache-HBase commented Mar 15, 2022

Apache-HBase commented Mar 15, 2022

Apache-HBase commented Mar 15, 2022

virajjasani Mar 15, 2022

sunhelly Mar 15, 2022

Apache-HBase commented Mar 15, 2022

Apache-HBase commented Mar 15, 2022

Apache-HBase commented Mar 15, 2022

HBASE-26840 Fix NPE in the retry of logroller #4224

HBASE-26840 Fix NPE in the retry of logroller #4224

Conversation

sunhelly commented Mar 15, 2022

Apache-HBase commented Mar 15, 2022

Apache-HBase commented Mar 15, 2022

Apache-HBase commented Mar 15, 2022

virajjasani Mar 15, 2022

Choose a reason for hiding this comment

sunhelly Mar 15, 2022

Choose a reason for hiding this comment

Apache-HBase commented Mar 15, 2022

Apache-HBase commented Mar 15, 2022

Apache-HBase commented Mar 15, 2022