Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-26912 Bump checkstyle from 8.28 to 8.29 #4293

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 28, 2022

Bumps checkstyle from 8.28 to 8.29.

Release notes

Sourced from checkstyle's releases.

checkstyle-8.29

https://checkstyle.org/releasenotes.html#Release_8.29

Commits
  • 8933d03 [maven-release-plugin] prepare release checkstyle-8.29
  • bd45909 Issue #7487: refactor code to use DetailAST.hasChildren()
  • 317e51f Issue #7487: add method hasChildren() to DetailAST
  • 89b4dcd Issue #3238: Java 8 Grammar: annotations on arrays and varargs
  • 252cd89 dependency: bump junit-pioneer from 0.5.1 to 0.5.2
  • 2ee2615 dependency: bump junit.version from 5.5.2 to 5.6.0
  • 4ed7cb8 minor: add space before xml comment end '-->' to ease reading and make links ...
  • c46a16d Issue #7468: disable 'external-parameter-entities' feature by default
  • dfed794 minor: add missing test case to SuperCloneCheckTest
  • 24e7bdf dependency: bump antlr4.version from 4.7.2 to 4.8-1
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 8.28 to 8.29.
- [Release notes](https://github.com/checkstyle/checkstyle/releases)
- [Commits](checkstyle/checkstyle@checkstyle-8.28...checkstyle-8.29)

---
updated-dependencies:
- dependency-name: com.puppycrawl.tools:checkstyle
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Mar 28, 2022
@apurtell apurtell requested review from apurtell and Apache9 March 28, 2022 22:10
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 12s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 4m 23s master passed
+1 💚 compile 7m 18s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 27s the patch passed
+1 💚 compile 7m 30s the patch passed
+1 💚 javac 7m 30s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 2s The patch has no ill-formed XML file.
+1 💚 hadoopcheck 14m 17s Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
_ Other Tests _
+1 💚 asflicense 0m 14s The patch does not generate ASF License warnings.
43m 9s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4293/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #4293
Optional Tests dupname asflicense javac hadoopcheck xml compile
uname Linux f31f86de476e 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 19da537
Default Java AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count 138 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4293/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 10s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 2m 26s master passed
+1 💚 compile 1m 35s master passed
+1 💚 shadedjars 3m 40s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 26s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 12s the patch passed
+1 💚 compile 1m 34s the patch passed
+1 💚 javac 1m 34s the patch passed
+1 💚 shadedjars 3m 39s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 26s the patch passed
_ Other Tests _
+1 💚 unit 346m 29s root in the patch passed.
367m 51s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4293/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #4293
Optional Tests javac javadoc unit shadedjars compile
uname Linux 4e99971d50c3 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 19da537
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4293/1/testReport/
Max. process+thread count 4438 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4293/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 58s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 6m 44s master passed
+1 💚 compile 4m 35s master passed
+1 💚 shadedjars 8m 21s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 5m 53s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 6m 43s the patch passed
+1 💚 compile 5m 1s the patch passed
+1 💚 javac 5m 1s the patch passed
+1 💚 shadedjars 7m 57s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 5m 17s the patch passed
_ Other Tests _
-1 ❌ unit 361m 10s root in the patch failed.
416m 46s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4293/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #4293
Optional Tests javac javadoc unit shadedjars compile
uname Linux 6bd7eab2ca49 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 19da537
Default Java AdoptOpenJDK-11.0.10+9
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4293/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4293/1/testReport/
Max. process+thread count 2459 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4293/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9
Copy link
Contributor

Apache9 commented Mar 29, 2022

Good.

So do we need to file an jira manually for this?

@apurtell apurtell changed the title Bump checkstyle from 8.28 to 8.29 HBASE-26912 Bump checkstyle from 8.28 to 8.29 Mar 31, 2022
@apurtell
Copy link
Contributor

I thought we could try dependabot's automatic pull requests but yes it is an unfortunate wrinkle we need to also file a JIRA manually and update the PR with the JIRA ID.

@apurtell apurtell merged commit 866198a into master Mar 31, 2022
@apurtell apurtell deleted the dependabot/maven/com.puppycrawl.tools-checkstyle-8.29 branch March 31, 2022 21:18
asfgit pushed a commit that referenced this pull request Mar 31, 2022
asfgit pushed a commit that referenced this pull request Mar 31, 2022
Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 8.28 to 8.29.

updated-dependencies:
- dependency-name: com.puppycrawl.tools:checkstyle

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
asfgit pushed a commit that referenced this pull request Mar 31, 2022
Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 8.28 to 8.29.

updated-dependencies:
- dependency-name: com.puppycrawl.tools:checkstyle

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
asfgit pushed a commit that referenced this pull request Mar 31, 2022
Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 8.28 to 8.29.

updated-dependencies:
- dependency-name: com.puppycrawl.tools:checkstyle

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
asfgit pushed a commit that referenced this pull request Mar 31, 2022
Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 8.28 to 8.29.

updated-dependencies:
- dependency-name: com.puppycrawl.tools:checkstyle

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 8.28 to 8.29.

updated-dependencies:
- dependency-name: com.puppycrawl.tools:checkstyle

Change-Id: Ia91b4af88fecafe20820608a3b20542d6026a32b
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants