-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-26929 Upgrade surefire plugin to 3.0.0-M6 #4319
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully this solves the surefire report corruption problem.
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
Ah, there is surefire.failIfNoSpecifiedTests option now so our "-Dtest=NoUnitTests" trick is broken. Let me check the personality script. |
(!) A patch to the testing environment has been detected. |
1 similar comment
(!) A patch to the testing environment has been detected. |
(!) A patch to the testing environment has been detected. |
(!) A patch to the testing environment has been detected. |
2 similar comments
(!) A patch to the testing environment has been detected. |
(!) A patch to the testing environment has been detected. |
🎊 +1 overall
This message was automatically generated. |
+1 on the -DskipTests |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
(!) A patch to the testing environment has been detected. |
2 similar comments
(!) A patch to the testing environment has been detected. |
(!) A patch to the testing environment has been detected. |
🎊 +1 overall
This message was automatically generated. |
@@ -500,7 +500,7 @@ function shadedjars_rebuild | |||
|
|||
local -a maven_args=('clean' 'verify' '-fae' '--batch-mode' | |||
'-pl' 'hbase-shaded/hbase-shaded-check-invariants' '-am' | |||
'-Dtest=NoUnitTests' '-DHBasePatchProcess' '-Prelease' | |||
'-DskipTests' '-DHBasePatchProcess' '-Prelease' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the NoUnitTests
is intentional in that it forces the test-compile
stage to happen even without running any tests. -DskipTests
will bypass the whole test
phase and so the unit test code is never compiled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, -DskipTests will execute the test-compile stage.
https://maven.apache.org/surefire/maven-surefire-plugin/examples/skipping-tests.html
If you absolutely must, you can also use the maven.test.skip property to skip compiling the tests. maven.test.skip is honored by Surefire, Failsafe and the Compiler Plugin.
The '-DskipTests' is only honored by surefire plugin so it can not skip a stage which is mainly controlled by other plugins...
@@ -842,7 +842,7 @@ | |||
<findbugs-annotations.version>1.3.9-1</findbugs-annotations.version> | |||
<spotbugs.version>4.2.2</spotbugs.version> | |||
<spotbugs.maven.version>4.2.0</spotbugs.maven.version> | |||
<surefire.version>3.0.0-M4</surefire.version> | |||
<surefire.version>3.0.0-M6</surefire.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woo! 🥳
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
Signed-off-by: Peter Somogyi <psomogyi@apache.org> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> (cherry picked from commit c791c81)
Signed-off-by: Peter Somogyi <psomogyi@apache.org> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> (cherry picked from commit c791c81)
Signed-off-by: Peter Somogyi <psomogyi@apache.org> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> (cherry picked from commit c791c81)
Upgrade maven-surefire-plugin to 3.0.0-M6 which should have fixed SUREFIRE-1821