Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-26880 Misspelling commands in hbase shell will crash the shell #4325

Merged
merged 2 commits into from
Apr 11, 2022
Merged

HBASE-26880 Misspelling commands in hbase shell will crash the shell #4325

merged 2 commits into from
Apr 11, 2022

Conversation

petersomogyi
Copy link
Contributor

No description provided.

@petersomogyi petersomogyi requested review from busbey and apurtell April 6, 2022 12:48
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 2s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 2m 30s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 11s the patch passed
-0 ⚠️ rubocop 0m 2s The patch generated 8 new + 37 unchanged - 5 fixed = 45 total (was 42)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
_ Other Tests _
+1 💚 asflicense 0m 11s The patch does not generate ASF License warnings.
8m 17s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4325/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #4325
Optional Tests dupname asflicense javac rubocop
uname Linux a5618a1e35dc 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / e68c61d
Default Java AdoptOpenJDK-1.8.0_282-b08
rubocop https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4325/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count 64 (vs. ulimit of 30000)
modules C: hbase-shell U: hbase-shell
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4325/1/console
versions git=2.17.1 maven=3.6.3 rubocop=0.80.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 7m 35s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 3m 33s master passed
+1 💚 javadoc 0m 14s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 34s the patch passed
+1 💚 javadoc 0m 13s the patch passed
_ Other Tests _
+1 💚 unit 8m 20s hbase-shell in the patch passed.
24m 38s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4325/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #4325
Optional Tests javac javadoc unit
uname Linux 3625c3d50c5a 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / e68c61d
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4325/1/testReport/
Max. process+thread count 1497 (vs. ulimit of 30000)
modules C: hbase-shell U: hbase-shell
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4325/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 49s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 4m 39s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 4s the patch passed
-0 ⚠️ rubocop 0m 13s The patch generated 9 new + 43 unchanged - 7 fixed = 52 total (was 50)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
_ Other Tests _
+1 💚 asflicense 0m 9s The patch does not generate ASF License warnings.
8m 57s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4325/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #4325
Optional Tests dupname asflicense javac rubocop
uname Linux fc87e89e4135 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / c791c81
Default Java AdoptOpenJDK-1.8.0_282-b08
rubocop https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4325/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count 65 (vs. ulimit of 30000)
modules C: hbase-shell U: hbase-shell
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4325/2/console
versions git=2.17.1 maven=3.6.3 rubocop=0.80.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 56s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 2m 36s master passed
+1 💚 javadoc 0m 10s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 25s the patch passed
+1 💚 javadoc 0m 8s the patch passed
_ Other Tests _
+1 💚 unit 7m 46s hbase-shell in the patch passed.
14m 47s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4325/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #4325
Optional Tests javac javadoc unit
uname Linux c5f1d24ec1f6 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / c791c81
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4325/2/testReport/
Max. process+thread count 1413 (vs. ulimit of 30000)
modules C: hbase-shell U: hbase-shell
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4325/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 20s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 2m 25s master passed
+1 💚 javadoc 0m 11s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 14s the patch passed
+1 💚 javadoc 0m 10s the patch passed
_ Other Tests _
+1 💚 unit 8m 50s hbase-shell in the patch passed.
14m 55s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4325/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #4325
Optional Tests javac javadoc unit
uname Linux 213f07e83745 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / c791c81
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4325/2/testReport/
Max. process+thread count 1356 (vs. ulimit of 30000)
modules C: hbase-shell U: hbase-shell
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4325/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@apurtell
Copy link
Contributor

apurtell commented Apr 8, 2022

@busbey any concerns here?

@busbey
Copy link
Contributor

busbey commented Apr 8, 2022

I raised my one proactive concern on the jira. if Peter says he's covered it then I'm good.

@petersomogyi
Copy link
Contributor Author

I raised my one proactive concern on the jira. if Peter says he's covered it then I'm good.

Yes, my second commit fixed that issue.

@petersomogyi petersomogyi merged commit 1d8a5bf into apache:master Apr 11, 2022
petersomogyi added a commit that referenced this pull request Apr 11, 2022
@petersomogyi
HBASE-26880 Misspelling commands in hbase shell will crash the shell (#…
d001fb0 
…4325)

Signed-off-by: Andrew Purtell <apurtell@apache.org>
petersomogyi added a commit that referenced this pull request Apr 11, 2022
@petersomogyi
HBASE-26880 Misspelling commands in hbase shell will crash the shell (#…
b63225d 
…4325)

Signed-off-by: Andrew Purtell <apurtell@apache.org>
petersomogyi added a commit that referenced this pull request Apr 11, 2022
@petersomogyi
HBASE-26880 Misspelling commands in hbase shell will crash the shell (#…
5e6042b 
…4325)

Signed-off-by: Andrew Purtell <apurtell@apache.org>
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
@petersomogyi
HBASE-26880 Misspelling commands in hbase shell will crash the shell (a…
859a1d8 
…pache#4325)

Signed-off-by: Andrew Purtell <apurtell@apache.org>
(cherry picked from commit b63225d)
Change-Id: Iab67deaa1e4e5cca6568eef975b2800762bf2403
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apurtell apurtell apurtell approved these changes

@busbey busbey Awaiting requested review from busbey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@petersomogyi @Apache-HBase @apurtell @busbey