-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-26892 Add spotless:check in our pre commit general check #4393
Conversation
The result can be seen here: |
(!) A patch to the testing environment has been detected. |
2 similar comments
(!) A patch to the testing environment has been detected. |
(!) A patch to the testing environment has been detected. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing to change, otherwise, great!
(!) A patch to the testing environment has been detected. |
2 similar comments
(!) A patch to the testing environment has been detected. |
(!) A patch to the testing environment has been detected. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
(!) A patch to the testing environment has been detected. |
2 similar comments
(!) A patch to the testing environment has been detected. |
(!) A patch to the testing environment has been detected. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
Ah, seems we still needs more to go... We haven't exclude the generated files when running spotless... Let me check it tomorrow... |
(!) A patch to the testing environment has been detected. |
1 similar comment
(!) A patch to the testing environment has been detected. |
(!) A patch to the testing environment has been detected. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> (cherry picked from commit 386869a)
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> (cherry picked from commit 386869a)
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> (cherry picked from commit 386869a)
No description provided.