HBASE-26963 ReplicationSource#removePeer hangs if we try to remove bad peer. #4413

shahrs87 · 2022-05-06T16:32:04Z

No description provided.

…d peer.

Apache-HBase · 2022-05-06T17:13:49Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 57s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+1 💚	mvninstall	3m 20s	branch-2 passed
+1 💚	compile	2m 17s	branch-2 passed
-0 ⚠️	checkstyle	0m 6s	The patch fails to run checkstyle in hbase-server
-1 ❌	spotless	0m 39s	branch has 24 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	1m 15s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 1s	the patch passed
+1 💚	compile	2m 12s	the patch passed
+1 💚	javac	2m 12s	the patch passed
+1 💚	checkstyle	0m 29s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	8m 2s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
-1 ❌	spotless	0m 33s	patch has 65 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	1m 19s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 10s	The patch does not generate ASF License warnings.
		28m 33s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4413/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4413
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 65c7c27bad7c 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `91eab0b`
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4413/1/artifact/yetus-general-check/output/buildtool-branch-checkstyle-hbase-server.txt
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4413/1/artifact/yetus-general-check/output/branch-spotless.txt
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4413/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	60 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4413/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-06T20:01:12Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 41s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 💚	mvninstall	3m 47s	branch-2 passed
+1 💚	compile	0m 35s	branch-2 passed
+1 💚	shadedjars	3m 53s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 24s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 5s	the patch passed
+1 💚	compile	0m 34s	the patch passed
+1 💚	javac	0m 34s	the patch passed
+1 💚	shadedjars	3m 52s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 21s	the patch passed
		_ Other Tests _
+1 💚	unit	178m 16s	hbase-server in the patch passed.
		195m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4413/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#4413
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 96110dc7da99 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `91eab0b`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4413/1/testReport/
Max. process+thread count	2694 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4413/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-06T20:17:07Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 5s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 💚	mvninstall	2m 48s	branch-2 passed
+1 💚	compile	0m 46s	branch-2 passed
+1 💚	shadedjars	3m 51s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 28s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 32s	the patch passed
+1 💚	compile	0m 47s	the patch passed
+1 💚	javac	0m 47s	the patch passed
+1 💚	shadedjars	3m 48s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	the patch passed
		_ Other Tests _
+1 💚	unit	193m 26s	hbase-server in the patch passed.
		211m 56s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4413/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4413
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 7267dcc78f98 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `91eab0b`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4413/1/testReport/
Max. process+thread count	2376 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4413/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

shahrs87 · 2022-05-06T20:36:39Z

branch-2 PR is also ready for review and merge. @Apache9 @apurtell

Apache-HBase · 2022-05-06T20:48:35Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 49s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+1 💚	mvninstall	3m 43s	branch-2 passed
+1 💚	compile	2m 17s	branch-2 passed
+1 💚	checkstyle	0m 31s	branch-2 passed
-1 ❌	spotless	0m 39s	branch has 24 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	1m 19s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 6s	the patch passed
+1 💚	compile	2m 14s	the patch passed
+1 💚	javac	2m 14s	the patch passed
+1 💚	checkstyle	0m 28s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	8m 4s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotless	0m 38s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 19s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 9s	The patch does not generate ASF License warnings.
		29m 38s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4413/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4413
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 4b692fb6110c 5.4.0-1043-aws #45~18.04.1-Ubuntu SMP Fri Apr 9 23:32:25 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `91eab0b`
Default Java	AdoptOpenJDK-1.8.0_282-b08
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4413/2/artifact/yetus-general-check/output/branch-spotless.txt
Max. process+thread count	65 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4413/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

shahrs87 · 2022-05-06T21:06:43Z

Looks like there are 2 spotless checks happening, one for the branch and other for the patch.
The branch one is failing but the patch one succeeded. So there is nothing for me to do ?

Apache-HBase · 2022-05-06T23:33:04Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 46s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 💚	mvninstall	2m 7s	branch-2 passed
+1 💚	compile	0m 34s	branch-2 passed
+1 💚	shadedjars	3m 51s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 20s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 3s	the patch passed
+1 💚	compile	0m 35s	the patch passed
+1 💚	javac	0m 35s	the patch passed
+1 💚	shadedjars	3m 53s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 22s	the patch passed
		_ Other Tests _
+1 💚	unit	178m 15s	hbase-server in the patch passed.
		194m 14s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4413/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#4413
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux e65448cdda35 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `91eab0b`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4413/2/testReport/
Max. process+thread count	2363 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4413/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-06T23:55:16Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 21s	Docker mode activated.
-0 ⚠️	yetus	0m 7s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 💚	mvninstall	2m 41s	branch-2 passed
+1 💚	compile	0m 48s	branch-2 passed
+1 💚	shadedjars	3m 55s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 28s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 34s	the patch passed
+1 💚	compile	0m 49s	the patch passed
+1 💚	javac	0m 49s	the patch passed
+1 💚	shadedjars	3m 50s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	the patch passed
		_ Other Tests _
+1 💚	unit	197m 37s	hbase-server in the patch passed.
		216m 27s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4413/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4413
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux bb1db8c4f040 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `91eab0b`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4413/2/testReport/
Max. process+thread count	2543 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4413/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

apurtell

lgtm, same as other PR except for the minor test differences

…d peer. (#4413) Signed-off-by: Andrew Purtell <apurtell@apache.org> Conflicts: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java

…d peer. (apache#4413) Signed-off-by: Andrew Purtell <apurtell@apache.org> Conflicts: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java (cherry picked from commit daaf5ad) Change-Id: I9da537c53fc041cc80b3ea18f32bb73114a6e92c

HBASE-26963 ReplicationSource#removePeer hangs if we try to remove ba…

6db32c9

…d peer.

spotcheck apply

518d3e4

apurtell approved these changes May 7, 2022

View reviewed changes

apurtell merged commit f5a0806 into apache:branch-2 May 7, 2022

2005hithlj mentioned this pull request May 9, 2022

HBASE-26977 Fix branch-2 spotless check error #4412

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-26963 ReplicationSource#removePeer hangs if we try to remove bad peer. #4413

HBASE-26963 ReplicationSource#removePeer hangs if we try to remove bad peer. #4413

shahrs87 commented May 6, 2022

Apache-HBase commented May 6, 2022

Apache-HBase commented May 6, 2022

Apache-HBase commented May 6, 2022

shahrs87 commented May 6, 2022

Apache-HBase commented May 6, 2022

shahrs87 commented May 6, 2022

Apache-HBase commented May 6, 2022

Apache-HBase commented May 6, 2022

apurtell left a comment

HBASE-26963 ReplicationSource#removePeer hangs if we try to remove bad peer. #4413

HBASE-26963 ReplicationSource#removePeer hangs if we try to remove bad peer. #4413

Conversation

shahrs87 commented May 6, 2022

Apache-HBase commented May 6, 2022

Apache-HBase commented May 6, 2022

Apache-HBase commented May 6, 2022

shahrs87 commented May 6, 2022

Apache-HBase commented May 6, 2022

shahrs87 commented May 6, 2022

Apache-HBase commented May 6, 2022

Apache-HBase commented May 6, 2022

apurtell left a comment

Choose a reason for hiding this comment