HBASE-27020 Fix spotless warn for master branch #4417

tomscut · 2022-05-10T07:28:41Z

Fix spotless warn for master branch. We can see the spotless warn at https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4416/1/artifact/yetus-general-check/output/branch-spotless.txt. There are some compile tasks that fail because of this.

Apache-HBase · 2022-05-10T07:51:45Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 44s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
-1 ❌	mvninstall	0m 12s	root in master failed.
-1 ❌	compile	0m 59s	hbase-server in master failed.
-0 ⚠️	checkstyle	0m 3s	The patch fails to run checkstyle in hbase-server
-1 ❌	spotless	0m 35s	branch has 66 errors when running spotless:check, run spotless:apply to fix.
-1 ❌	spotbugs	0m 5s	hbase-server in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 0s	the patch passed
+1 💚	compile	2m 12s	the patch passed
-0 ⚠️	javac	2m 12s	hbase-server generated 193 new + 0 unchanged - 0 fixed = 193 total (was 0)
-0 ⚠️	checkstyle	0m 32s	hbase-server: The patch generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
-1 ❌	hadoopcheck	9m 27s	The patch causes 23 errors with Hadoop v3.3.1.
+1 💚	spotless	0m 38s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 29s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		21m 27s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4417
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 585a54ef664e 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f6e9d3e`
Default Java	AdoptOpenJDK-1.8.0_282-b08
mvninstall	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/1/artifact/yetus-general-check/output/branch-mvninstall-root.txt
compile	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/1/artifact/yetus-general-check/output/branch-compile-hbase-server.txt
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/1/artifact/yetus-general-check/output/buildtool-branch-checkstyle-hbase-server.txt
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/1/artifact/yetus-general-check/output/branch-spotless.txt
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/1/artifact/yetus-general-check/output/branch-spotbugs-hbase-server.txt
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
hadoopcheck	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/1/artifact/yetus-general-check/output/patch-javac-3.3.1.txt
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

tomscut · 2022-05-10T08:26:48Z

After mvn spotless:apply, I run mvn spotless:check locally, and build success. But spotless check failed here. I feel a little confused.

Apache-HBase · 2022-05-10T10:48:18Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 51s	master passed
+1 💚	compile	0m 45s	master passed
+1 💚	shadedjars	3m 43s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 28s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 33s	the patch passed
+1 💚	compile	0m 46s	the patch passed
+1 💚	javac	0m 46s	the patch passed
+1 💚	shadedjars	3m 41s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 27s	the patch passed
		_ Other Tests _
+1 💚	unit	180m 41s	hbase-server in the patch passed.
		198m 7s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4417
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 6f638ceee80e 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f6e9d3e`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/1/testReport/
Max. process+thread count	2668 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-10T10:58:34Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 10s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 25s	master passed
+1 💚	compile	0m 39s	master passed
+1 💚	shadedjars	3m 40s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 13s	the patch passed
+1 💚	compile	0m 38s	the patch passed
+1 💚	javac	0m 38s	the patch passed
+1 💚	shadedjars	3m 40s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 24s	the patch passed
		_ Other Tests _
+1 💚	unit	191m 23s	hbase-server in the patch passed.
		208m 19s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4417
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 0593d77d1d3d 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f6e9d3e`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/1/testReport/
Max. process+thread count	2727 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-10T11:30:21Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 42s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 7s	master passed
+1 💚	compile	2m 10s	master passed
+1 💚	checkstyle	0m 27s	master passed
-1 ❌	spotless	0m 32s	branch has 66 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	1m 11s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 4s	the patch passed
+1 💚	compile	2m 11s	the patch passed
+1 💚	javac	2m 11s	the patch passed
-0 ⚠️	checkstyle	0m 27s	hbase-server: The patch generated 1 new + 4 unchanged - 1 fixed = 5 total (was 5)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 38s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotless	0m 38s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 18s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 7s	The patch does not generate ASF License warnings.
		30m 34s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4417
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 246fe2bb533e 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f6e9d3e`
Default Java	AdoptOpenJDK-1.8.0_282-b08
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/2/artifact/yetus-general-check/output/branch-spotless.txt
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-10T14:18:10Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 52s	master passed
+1 💚	compile	0m 46s	master passed
+1 💚	shadedjars	3m 42s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 28s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 29s	the patch passed
+1 💚	compile	0m 47s	the patch passed
+1 💚	javac	0m 47s	the patch passed
+1 💚	shadedjars	3m 39s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	the patch passed
		_ Other Tests _
+1 💚	unit	180m 3s	hbase-server in the patch passed.
		198m 4s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4417
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 3feacd434f12 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f6e9d3e`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/2/testReport/
Max. process+thread count	2775 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-10T14:26:26Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 11s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 7s	master passed
+1 💚	compile	0m 38s	master passed
+1 💚	shadedjars	3m 40s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 23s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 12s	the patch passed
+1 💚	compile	0m 39s	the patch passed
+1 💚	javac	0m 39s	the patch passed
+1 💚	shadedjars	3m 39s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 23s	the patch passed
		_ Other Tests _
+1 💚	unit	190m 28s	hbase-server in the patch passed.
		206m 38s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4417
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 6e60011df830 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f6e9d3e`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/2/testReport/
Max. process+thread count	2465 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

shahrs87

+1 ltgm

Apache-HBase · 2022-05-10T15:43:25Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 57s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 9s	master passed
+1 💚	compile	2m 49s	master passed
+1 💚	checkstyle	0m 34s	master passed
-1 ❌	spotless	0m 41s	branch has 66 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	1m 34s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 5s	the patch passed
+1 💚	compile	2m 46s	the patch passed
+1 💚	javac	2m 46s	the patch passed
+1 💚	checkstyle	0m 32s	hbase-server: The patch generated 0 new + 0 unchanged - 5 fixed = 0 total (was 5)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	16m 45s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
-1 ❌	spotless	0m 46s	patch has 38 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	1m 48s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 10s	The patch does not generate ASF License warnings.
		43m 7s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4417
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 9ce9c995d5bc 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f6e9d3e`
Default Java	AdoptOpenJDK-1.8.0_282-b08
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/3/artifact/yetus-general-check/output/branch-spotless.txt
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/3/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/3/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-10T18:17:24Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 37s	master passed
+1 💚	compile	0m 45s	master passed
+1 💚	shadedjars	3m 38s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 37s	the patch passed
+1 💚	compile	0m 46s	the patch passed
+1 💚	javac	0m 46s	the patch passed
+1 💚	shadedjars	3m 40s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	the patch passed
		_ Other Tests _
+1 💚	unit	180m 6s	hbase-server in the patch passed.
		196m 52s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4417
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 43933c798f42 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f6e9d3e`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/3/testReport/
Max. process+thread count	2739 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-10T18:35:10Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 52s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 19s	master passed
+1 💚	compile	0m 48s	master passed
+1 💚	shadedjars	4m 25s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 29s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 0s	the patch passed
+1 💚	compile	0m 49s	the patch passed
+1 💚	javac	0m 49s	the patch passed
+1 💚	shadedjars	4m 19s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	the patch passed
		_ Other Tests _
+1 💚	unit	193m 27s	hbase-server in the patch passed.
		214m 15s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4417
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 62e470a09c2b 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f6e9d3e`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/3/testReport/
Max. process+thread count	2511 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

tomscut · 2022-05-10T23:55:02Z

Thanks @shahrs87 for your review.

tomscut · 2022-05-11T02:01:28Z

Hi @Apache9 @apurtell
I found some spotless warn on another PR at https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4416/1/artifact/yetus-general-check/output/branch-spotless.txt.

So I repaired them by running "mvn spotless:apply". Then I executed "mvn spotless:check" locally, and the build succeeded. But there are some checkstyle errors https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt. Then I fix the checkstyle errors. The spotless warn came again.

There seems to be some conflict between the default spotless format and hbase checkstyle in indentation checking. I don't know if there have been similar cases before.

Apache9 · 2022-05-11T02:40:58Z

Please just run spotless:apply to fix the spotless errors? Will check the checkstyle configurations later to align them.

Thanks.

tomscut · 2022-05-11T04:14:28Z

Thanks @Apache9 for your review and suggestion.

I ran mvn spotless:apply and mvn spotless:check, build success locally.

Apache-HBase · 2022-05-11T04:46:24Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 45s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 18s	master passed
+1 💚	compile	2m 8s	master passed
+1 💚	checkstyle	0m 27s	master passed
-1 ❌	spotless	0m 36s	branch has 66 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	1m 18s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 3s	the patch passed
+1 💚	compile	2m 13s	the patch passed
+1 💚	javac	2m 13s	the patch passed
-0 ⚠️	checkstyle	0m 28s	hbase-server: The patch generated 1 new + 4 unchanged - 1 fixed = 5 total (was 5)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 49s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotless	0m 38s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 18s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 8s	The patch does not generate ASF License warnings.
		31m 8s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4417
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 044b85019a33 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f6e9d3e`
Default Java	AdoptOpenJDK-1.8.0_282-b08
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/4/artifact/yetus-general-check/output/branch-spotless.txt
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/4/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

taklwu · 2022-05-11T06:22:24Z

so, it's very strange to me as well in #4414.

I'm looking for the right instructions to run mvn spotless:apply for my change on top of master branch, but I cannot find a clean one, are we hitting some problem about this mvn clean spotless:check when running precommit ?

tomscut · 2022-05-11T06:48:55Z

Thanks @Apache9 .

Apache-HBase · 2022-05-11T07:32:25Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 29s	master passed
+1 💚	compile	0m 47s	master passed
+1 💚	shadedjars	3m 41s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 35s	the patch passed
+1 💚	compile	0m 46s	the patch passed
+1 💚	javac	0m 46s	the patch passed
+1 💚	shadedjars	3m 39s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	the patch passed
		_ Other Tests _
+1 💚	unit	180m 43s	hbase-server in the patch passed.
		197m 17s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4417
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 532651aa27d3 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f6e9d3e`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/4/testReport/
Max. process+thread count	2703 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-11T07:41:57Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 14s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 26s	master passed
+1 💚	compile	0m 39s	master passed
+1 💚	shadedjars	3m 42s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 17s	the patch passed
+1 💚	compile	0m 39s	the patch passed
+1 💚	javac	0m 39s	the patch passed
+1 💚	shadedjars	3m 41s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 24s	the patch passed
		_ Other Tests _
+1 💚	unit	189m 52s	hbase-server in the patch passed.
		206m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4417
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux af2afeb5b9c8 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f6e9d3e`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/4/testReport/
Max. process+thread count	2589 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4417/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

HBASE-27020 Fix spotless warn for master branch

ac3771e

empty commit

c73550d

fix checkstyle

27adc8b

shahrs87 approved these changes May 10, 2022

View reviewed changes

Apache9 approved these changes May 11, 2022

View reviewed changes

ran spotless:apply and spotless:check

de8926d

Apache9 merged commit a712f9f into apache:master May 11, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-27020 Fix spotless warn for master branch #4417

HBASE-27020 Fix spotless warn for master branch #4417

tomscut commented May 10, 2022 •

edited

Loading

Apache-HBase commented May 10, 2022

tomscut commented May 10, 2022 •

edited

Loading

Apache-HBase commented May 10, 2022

Apache-HBase commented May 10, 2022

Apache-HBase commented May 10, 2022

Apache-HBase commented May 10, 2022

Apache-HBase commented May 10, 2022

shahrs87 left a comment

Apache-HBase commented May 10, 2022

Apache-HBase commented May 10, 2022

Apache-HBase commented May 10, 2022

tomscut commented May 10, 2022

tomscut commented May 11, 2022

Apache9 commented May 11, 2022

tomscut commented May 11, 2022

Apache-HBase commented May 11, 2022

taklwu commented May 11, 2022

tomscut commented May 11, 2022

Apache-HBase commented May 11, 2022

Apache-HBase commented May 11, 2022

HBASE-27020 Fix spotless warn for master branch #4417

HBASE-27020 Fix spotless warn for master branch #4417

Conversation

tomscut commented May 10, 2022 • edited Loading

Apache-HBase commented May 10, 2022

tomscut commented May 10, 2022 • edited Loading

Apache-HBase commented May 10, 2022

Apache-HBase commented May 10, 2022

Apache-HBase commented May 10, 2022

Apache-HBase commented May 10, 2022

Apache-HBase commented May 10, 2022

shahrs87 left a comment

Choose a reason for hiding this comment

Apache-HBase commented May 10, 2022

Apache-HBase commented May 10, 2022

Apache-HBase commented May 10, 2022

tomscut commented May 10, 2022

tomscut commented May 11, 2022

Apache9 commented May 11, 2022

tomscut commented May 11, 2022

Apache-HBase commented May 11, 2022

taklwu commented May 11, 2022

tomscut commented May 11, 2022

Apache-HBase commented May 11, 2022

Apache-HBase commented May 11, 2022

tomscut commented May 10, 2022 •

edited

Loading

tomscut commented May 10, 2022 •

edited

Loading