HBASE-27065 Build against Hadoop 3.3.3 #4467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building against Hadoop 3.3.3 and any future version of Hadoop incorporating reload4j the new Enforcer rule we have active in branch-2.5 and up to exclude other logging frameworks besides log4j2 will trigger. We need to add exclusions to prevent that from happening so the build will succeed. Also exclude leveldbjni-all to avoid a LICENSE file generation error.
jojochuang
reviewed
May 26, 2022
|
I'm not sure why leveldb-jni is an issue now either @jojochuang . Perhaps there was a version increment, and anyway there is an architectural difference. On x86_64 the groupId is fusesource. On aarch64 it is openlabtesting. The license metadata in the POMs of these different arch-specific releases could vary. My build and test hosts are aarch64 so I may be one of the first to notice. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
busbey
approved these changes
May 27, 2022
trying to init minidfscluster with: java.lang.NoClassDefFoundError: io/netty/handler/codec/http/HttpRequest at java.lang.Class.getDeclaredMethods0(Native Method) at java.lang.Class.privateGetDeclaredMethods(Class.java:2701) at java.lang.Class.getDeclaredMethod(Class.java:2128) at org.apache.hadoop.hdfs.server.datanode.web.DatanodeHttpServer.getFilterHandlers(DatanodeHttpServer.java:279) at org.apache.hadoop.hdfs.server.datanode.web.DatanodeHttpServer.<init>(DatanodeHttpServer.java:149) at org.apache.hadoop.hdfs.server.datanode.DataNode.startInfoServer(DataNode.java:977) at org.apache.hadoop.hdfs.server.datanode.DataNode.startDataNode(DataNode.java:1412) at org.apache.hadoop.hdfs.server.datanode.DataNode.<init>(DataNode.java:507) at org.apache.hadoop.hdfs.server.datanode.DataNode.makeInstance(DataNode.java:2828) at org.apache.hadoop.hdfs.server.datanode.DataNode.instantiateDataNode(DataNode.java:2734) at org.apache.hadoop.hdfs.MiniDFSCluster.startDataNodes(MiniDFSCluster.java:1755) at org.apache.hadoop.hdfs.MiniDFSCluster.initMiniDFSCluster(MiniDFSCluster.java:969) at org.apache.hadoop.hdfs.MiniDFSCluster.<init>(MiniDFSCluster.java:864)
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
wenwj0
pushed a commit
to wenwj0/hbase
that referenced
this pull request
Jun 14, 2022
When building against Hadoop 3.3.3 and any future version of Hadoop incorporating reload4j the new Enforcer rule we have active in branch-2.5 and up to exclude other logging frameworks besides log4j2 will trigger. We need to add exclusions to prevent that from happening so the build will succeed. Also exclude leveldbjni-all to avoid a LICENSE file generation error. Add netty-all to hadoop-hdfs test context... to fix tests failing trying to init minidfscluster. Co-authored-by: stack <stack@apache.org> Signed-off-by: Sean Busbey <busbey@apache.org>
wenwj0
added a commit
to wenwj0/hbase
that referenced
this pull request
Jun 14, 2022
This reverts commit 9936c39.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building against Hadoop 3.3.3 and any future version of Hadoop incorporating reload4j the new Enforcer rule we have active in branch-2.5 and up to exclude other logging frameworks besides log4j2 will trigger. We need to add exclusions to prevent that from happening so the build will succeed.
Also exclude leveldbjni-all to avoid a LICENSE file generation error. hadoop-hdfs and hadoop-mapreduce are messy and export this among findbugs and other clutter. Anyway, better to exclude something we do not require than add an unnecessary supplemental model.