HBASE-26854 Shell startup logs a bunch of noise #4469

apurtell · 2022-05-27T00:12:32Z

Simple changes to jar-bootstrap.rb are required after switching the logger to Log4J v2.

Refer to https://stackoverflow.com/questions/23434252/programmatically-change-log-level-in-log4j2

apurtell · 2022-05-27T00:14:01Z

Manually verified. Just the native code loader warning from Hadoop, as expected.

apurtell@buildbox:~/tmp/hbase-3.0.0-alpha-3-SNAPSHOT$ ./bin/hbase shell 
2022-05-26T17:11:34,453 WARN  [main] util.NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
HBase Shell
Use "help" to get list of supported commands.
Use "exit" to quit this interactive shell.
For Reference, please visit: http://hbase.apache.org/book.html#shell
Version 3.0.0-alpha-3-SNAPSHOT, r79b3588d86a7c0f7b6131936ee85b2259aa337ef, Thu May 26 17:09:08 PDT 2022
Took 0.0009 seconds                                                                                                                                                                           
hbase:001:0>

E.g. typically the native code loader will complain when the shell is launched without libhadoop in java.library.path.

apurtell · 2022-05-27T00:23:09Z

While we are at it, we can trivially silence WARN level logging or lower from Hadoop libraries too, unless debug mode is enabled with -d, per usual.

apurtell@buildbox:~/tmp/hbase-3.0.0-alpha-3-SNAPSHOT$ ./bin/hbase shell 
HBase Shell
Use "help" to get list of supported commands.
Use "exit" to quit this interactive shell.
For Reference, please visit: http://hbase.apache.org/book.html#shell
Version 3.0.0-alpha-3-SNAPSHOT, r644756d2cfdc025e44b59390a77b67baa18fa6ff, Thu May 26 17:19:57 PDT 2022
Took 0.0008 seconds                                                                                                                                                                           
hbase:001:0>

Apache-HBase · 2022-05-27T00:34:45Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 19s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 53s	master passed
+1 💚	spotless	0m 46s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 30s	the patch passed
-0 ⚠️	rubocop	0m 3s	The patch generated 1 new + 7 unchanged - 1 fixed = 8 total (was 8)
+1 💚	whitespace	0m 1s	The patch has no whitespace issues.
+1 💚	spotless	0m 46s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	0m 8s	The patch does not generate ASF License warnings.
		9m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4469/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4469
Optional Tests	dupname asflicense javac spotless rubocop
uname	Linux 5db9f3f31e48 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `fdf054d`
Default Java	AdoptOpenJDK-1.8.0_282-b08
rubocop	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4469/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4469/1/console
versions	git=2.17.1 maven=3.6.3 rubocop=0.80.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-27T00:41:54Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 42s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 10s	master passed
+1 💚	javadoc	0m 11s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 38s	the patch passed
+1 💚	javadoc	0m 8s	the patch passed
		_ Other Tests _
+1 💚	unit	7m 31s	hbase-shell in the patch passed.
		16m 26s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4469/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4469
Optional Tests	javac javadoc unit
uname	Linux 72c8c39e5c78 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `fdf054d`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4469/1/testReport/
Max. process+thread count	1555 (vs. ulimit of 30000)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4469/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-27T00:45:53Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 51s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 45s	master passed
-0 ⚠️	javadoc	0m 20s	hbase-shell in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 3s	the patch passed
+1 💚	javadoc	0m 14s	the patch passed
		_ Other Tests _
+1 💚	unit	8m 46s	hbase-shell in the patch passed.
		20m 21s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4469/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4469
Optional Tests	javac javadoc unit
uname	Linux b8e8c88dd690 5.4.0-1043-aws #45~18.04.1-Ubuntu SMP Fri Apr 9 23:32:25 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `fdf054d`
Default Java	AdoptOpenJDK-1.8.0_282-b08
javadoc	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4469/1/artifact/yetus-jdk8-hadoop3-check/output/branch-javadoc-hbase-shell.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4469/1/testReport/
Max. process+thread count	1495 (vs. ulimit of 30000)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4469/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

busbey

looks like an unfortunate gap in our bans on incorrect APIs.

Thanks for the catch and fix

apurtell · 2022-05-27T20:48:15Z

Thanks, will apply back to branch-2.5. Thanks for the review @busbey

apurtell · 2022-05-27T20:48:34Z

Thanks for the review @virajjasani

Upon startup the shell logs a bunch of noise, mainly from zookeeper. Also hide WARN level logging from the Hadoop libraries Signed-off-by: Sean Busbey <busbey@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org>

This reverts commit de9776d.

Upon startup the shell logs a bunch of noise, mainly from zookeeper. Also hide WARN level logging from the Hadoop libraries Signed-off-by: Sean Busbey <busbey@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org> (cherry picked from commit 20895c7)

HBASE-26854 Shell startup logs a bunch of noise

79b3588

apurtell requested review from busbey, ndimiduk and virajjasani May 27, 2022 00:12

Also hide WARN level logging from the Hadoop libraries

644756d

E.g. typically the native code loader will complain when the shell is launched without libhadoop in java.library.path.

apurtell requested a review from Apache9 May 27, 2022 00:25

virajjasani approved these changes May 27, 2022

View reviewed changes

busbey approved these changes May 27, 2022

View reviewed changes

apurtell merged commit 9fcaf85 into apache:master May 27, 2022

apurtell deleted the HBASE-26854 branch May 27, 2022 21:00

wenwj0 added a commit to wenwj0/hbase that referenced this pull request Jun 14, 2022

Revert "HBASE-26854 Shell startup logs a bunch of noise (apache#4469)"

92b193f

This reverts commit de9776d.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-26854 Shell startup logs a bunch of noise #4469

HBASE-26854 Shell startup logs a bunch of noise #4469

apurtell commented May 27, 2022 •

edited

Loading

apurtell commented May 27, 2022

apurtell commented May 27, 2022 •

edited

Loading

Apache-HBase commented May 27, 2022

Apache-HBase commented May 27, 2022

Apache-HBase commented May 27, 2022

busbey left a comment

apurtell commented May 27, 2022

apurtell commented May 27, 2022

HBASE-26854 Shell startup logs a bunch of noise #4469

HBASE-26854 Shell startup logs a bunch of noise #4469

Conversation

apurtell commented May 27, 2022 • edited Loading

apurtell commented May 27, 2022

apurtell commented May 27, 2022 • edited Loading

Apache-HBase commented May 27, 2022

Apache-HBase commented May 27, 2022

Apache-HBase commented May 27, 2022

busbey left a comment

Choose a reason for hiding this comment

apurtell commented May 27, 2022

apurtell commented May 27, 2022

apurtell commented May 27, 2022 •

edited

Loading

apurtell commented May 27, 2022 •

edited

Loading