Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport "HBASE-26366 Provide meaningful parent spans to ZK interactions" to branch-2 #4487

Merged
merged 3 commits into from
Jun 10, 2022
Merged

Backport "HBASE-26366 Provide meaningful parent spans to ZK interactions" to branch-2 #4487

merged 3 commits into from
Jun 10, 2022

Conversation

ndimiduk
Copy link
Member

@ndimiduk ndimiduk commented Jun 3, 2022

A backport of #4459 to branch-2.

@ndimiduk ndimiduk added the backport This PR is a back port of some issue or issues already committed to master label Jun 3, 2022
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@ndimiduk ndimiduk force-pushed the 26366-meaningful-parents-zk-spans-branch-2 branch from 81d5468 to e76f01d Compare June 6, 2022 09:11
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
ndimiduk added 3 commits June 9, 2022 14:36
@ndimiduk
HBASE-26366 Provide meaningful parent spans to ZK interactions
3b03d88 
Signed-off-by: Andrew Purtell <apurtell@apache.org>
@ndimiduk
additional changes for branch-2
dbbfdf9
@ndimiduk
PR feedback, also...
050427b 
- decouple spawned thread spans from parent thread spans, just in case
- ensure all manually-managed spans have a status set
- rename/move test to better match its scope
@ndimiduk ndimiduk force-pushed the 26366-meaningful-parents-zk-spans-branch-2 branch from e76f01d to 050427b Compare June 9, 2022 13:04
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 33s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
+1 💚 mvninstall 3m 31s branch-2 passed
+1 💚 compile 4m 28s branch-2 passed
+1 💚 checkstyle 1m 25s branch-2 passed
+1 💚 spotless 0m 49s branch has no errors when running spotless:check.
+1 💚 spotbugs 3m 13s branch-2 passed
-0 ⚠️ patch 0m 44s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 9s Maven dependency ordering for patch
+1 💚 mvninstall 3m 28s the patch passed
+1 💚 compile 4m 17s the patch passed
-0 ⚠️ javac 2m 34s hbase-server generated 1 new + 192 unchanged - 1 fixed = 193 total (was 193)
-0 ⚠️ checkstyle 0m 34s hbase-server: The patch generated 1 new + 14 unchanged - 1 fixed = 15 total (was 15)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 10m 44s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotless 0m 46s patch has no errors when running spotless:check.
+1 💚 spotbugs 3m 47s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 28s The patch does not generate ASF License warnings.
46m 20s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4487/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #4487
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux e68b9595254d 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / b3c9ef3
Default Java AdoptOpenJDK-1.8.0_282-b08
javac https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4487/3/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
checkstyle https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4487/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count 69 (vs. ulimit of 12500)
modules C: hbase-common hbase-client hbase-zookeeper hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4487/3/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 59s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 44s Maven dependency ordering for branch
+1 💚 mvninstall 3m 20s branch-2 passed
+1 💚 compile 1m 33s branch-2 passed
+1 💚 shadedjars 5m 3s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 9s branch-2 passed
-0 ⚠️ patch 6m 38s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 3m 5s the patch passed
+1 💚 compile 1m 29s the patch passed
+1 💚 javac 1m 29s the patch passed
+1 💚 shadedjars 4m 50s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 8s the patch passed
_ Other Tests _
+1 💚 unit 1m 35s hbase-common in the patch passed.
+1 💚 unit 2m 54s hbase-client in the patch passed.
+1 💚 unit 0m 37s hbase-zookeeper in the patch passed.
+1 💚 unit 206m 44s hbase-server in the patch passed.
237m 56s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4487/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #4487
Optional Tests javac javadoc unit shadedjars compile
uname Linux 9b17373570b5 5.4.0-1068-aws #72~18.04.1-Ubuntu SMP Thu Mar 3 08:49:49 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / b3c9ef3
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4487/3/testReport/
Max. process+thread count 2314 (vs. ulimit of 12500)
modules C: hbase-common hbase-client hbase-zookeeper hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4487/3/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 23s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for branch
+1 💚 mvninstall 3m 12s branch-2 passed
+1 💚 compile 1m 43s branch-2 passed
+1 💚 shadedjars 4m 22s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 17s branch-2 passed
-0 ⚠️ patch 6m 13s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 22s Maven dependency ordering for patch
+1 💚 mvninstall 3m 9s the patch passed
+1 💚 compile 1m 43s the patch passed
+1 💚 javac 1m 43s the patch passed
+1 💚 shadedjars 4m 22s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 15s the patch passed
_ Other Tests _
+1 💚 unit 1m 59s hbase-common in the patch passed.
+1 💚 unit 2m 44s hbase-client in the patch passed.
+1 💚 unit 0m 42s hbase-zookeeper in the patch passed.
+1 💚 unit 229m 48s hbase-server in the patch passed.
261m 20s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4487/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #4487
Optional Tests javac javadoc unit shadedjars compile
uname Linux 72d6ffce8f64 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / b3c9ef3
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4487/3/testReport/
Max. process+thread count 2434 (vs. ulimit of 12500)
modules C: hbase-common hbase-client hbase-zookeeper hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4487/3/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ndimiduk ndimiduk merged commit 9b8bb58 into apache:branch-2 Jun 10, 2022
@ndimiduk ndimiduk deleted the 26366-meaningful-parents-zk-spans-branch-2 branch June 10, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport This PR is a back port of some issue or issues already committed to master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndimiduk @Apache-HBase