HBASE-27086 Fix graceful_stop cannot take previous balancer status by incompatibility of hbase shell prompt #4490
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… incompatibility of hbase shell prompt
bitterfox
commented
Jun 6, 2022
| @@ -203,7 +203,10 @@ def debug? | |||
|
|
|||
| IRB.conf[:IRB_NAME] = 'hbase' | |||
| IRB.conf[:AP_NAME] = 'hbase' | |||
| IRB.conf[:PROMPT_MODE] = :CUSTOM | |||
| if IRB.conf[:PROMPT_MODE] != :NULL | |||
There was a problem hiding this comment.
I'm not sure which is preferred. The behavior in this patch is similar to hbase 1.x hbase shell
if IRB.conf[:PROMPT_MODE] != :NULL: no prompt for pipe or non interaction
$ echo "balance_switch false" | bin/hbase shell
HBase Shell
Use "help" to get list of supported commands.
Use "exit" to quit this interactive shell.
For Reference, please visit: http://hbase.apache.org/book.html#shell
Version 3.0.0-alpha-3-SNAPSHOT, ra712f9fa34ed3ace5ae6bf539c227a110b259a2c, Mon Jun 6 13:59:23 JST 2022
Took 0.0020 seconds
balance_switch false
Previous balancer state : false
Took 0.9183 seconds
false
$ echo "balance_switch false" | bin/hbase shell -n
balance_switch false
Previous balancer state : false
Took 0.9745 seconds
false
if interactive: no prompt non interaction only (similar behavior as hbase 2.4.9)
$ echo "balance_switch false" | bin/hbase shell
HBase Shell
Use "help" to get list of supported commands.
Use "exit" to quit this interactive shell.
For Reference, please visit: http://hbase.apache.org/book.html#shell
Version 3.0.0-alpha-3-SNAPSHOT, ra712f9fa34ed3ace5ae6bf539c227a110b259a2c, Mon Jun 6 13:59:23 JST 2022
Took 0.0023 seconds
hbase:001:0> balance_switch false
Previous balancer state : false
Took 1.0975 seconds
=> false
hbase:002:0>
$ echo "balance_switch false" | bin/hbase shell -n
balance_switch false
Previous balancer state : false
Took 0.9643 seconds
false
Let me know which behavior is preferred
There was a problem hiding this comment.
I'd say skip the prompt only in non-interactive mode. The general position since the introduction of the non-interactive flag is that it ought to be used for any scripted integration.
There was a problem hiding this comment.
Thank you for the suggestion. I see. I updated it to use interactive for condition. we can switch prompt by -n option in any case we want to do so.
bitterfox
commented
Jun 6, 2022
| @@ -115,7 +115,7 @@ if [ "$nob" == "true" ]; then | |||
| HBASE_BALANCER_STATE=false | |||
| else | |||
| log "Disabling load balancer" | |||
| HBASE_BALANCER_STATE=$(echo 'balance_switch false' | "$bin"/hbase --config "${HBASE_CONF_DIR}" shell -n | tail -1) | |||
| HBASE_BALANCER_STATE=$(echo 'balance_switch false' | "$bin"/hbase --config "${HBASE_CONF_DIR}" shell -n | tail -2 | head -1) | |||
There was a problem hiding this comment.
No idea, but empty line is added to the end of output of hbase shell. we need to take the 2nd line from the last
$ echo "balance_switch false" | bin/hbase shell -n | tail -1
$ echo "balance_switch false" | bin/hbase shell -n | tail -2 | head -1
false
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/HBASE-27086
There're 2 issues
hbase shellshows prompt always even throughecho "balance_switch false" | hbase shell -n(noninteractive mode or piped)tail -1retrieve the empty line. needtail -2 | head -1to retrieve true/false for previous balancer statusNeed this patch in branch-2.4, 2.5, 2, 3, master