Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-27152 Under compaction mark may leak #4568

Merged
merged 1 commit into from
Jul 20, 2022
Merged

HBASE-27152 Under compaction mark may leak #4568

merged 1 commit into from
Jul 20, 2022

Conversation

sunhelly
Copy link
Contributor

No description provided.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 36s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 3m 55s master passed
+1 💚 compile 2m 15s master passed
+1 💚 checkstyle 0m 28s master passed
+1 💚 spotless 0m 42s branch has no errors when running spotless:check.
+1 💚 spotbugs 1m 14s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 1s the patch passed
+1 💚 compile 2m 11s the patch passed
+1 💚 javac 2m 11s the patch passed
+1 💚 checkstyle 0m 27s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 12m 2s Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚 spotless 0m 38s patch has no errors when running spotless:check.
+1 💚 spotbugs 1m 17s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 9s The patch does not generate ASF License warnings.
32m 50s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4568/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #4568
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux 42d23444df16 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 9bae50f
Default Java AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count 64 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4568/1/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9
Apache9 reviewed Jun 23, 2022
View reviewed changes
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java Show resolved Hide resolved
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java Outdated
+ "store size is {}",
getStoreNameForUnderCompaction(store), priority, underCompactionStores.size());
}
} catch (Throwable t) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When will we get exceptions here? And better just catch the exception types which could be thrown in the above code block?

Copy link
Contributor Author

@sunhelly sunhelly Jun 23, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it will only throw NPE when pool.execute(null), which will never happen here. I'll just remove the try/catch here. Thanks.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 37s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 2m 6s master passed
+1 💚 compile 2m 12s master passed
+1 💚 checkstyle 0m 27s master passed
+1 💚 spotless 0m 39s branch has no errors when running spotless:check.
+1 💚 spotbugs 1m 11s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 12s the patch passed
+1 💚 compile 2m 15s the patch passed
+1 💚 javac 2m 15s the patch passed
+1 💚 checkstyle 0m 27s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 11m 33s Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚 spotless 0m 39s patch has no errors when running spotless:check.
+1 💚 spotbugs 1m 19s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 7s The patch does not generate ASF License warnings.
30m 52s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4568/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #4568
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux a90847b39be6 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / e84cd3d
Default Java AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count 60 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4568/2/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9 Apache9 merged commit da27a67 into apache:master Jul 20, 2022
Apache9 pushed a commit that referenced this pull request Jul 20, 2022
@sunhelly @Apache9
HBASE-27152 Under compaction mark may leak (#4568)
3ebb436 
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit da27a67)
Apache9 pushed a commit that referenced this pull request Jul 20, 2022
@sunhelly @Apache9
HBASE-27152 Under compaction mark may leak (#4568)
5c5ceb1 
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit da27a67)
Apache9 added a commit that referenced this pull request Jul 21, 2022
@Apache9
Revert "HBASE-27152 Under compaction mark may leak (#4568)"
75a05b5 
This reverts commit da27a67.
Apache9 added a commit that referenced this pull request Jul 21, 2022
@Apache9
Revert "HBASE-27152 Under compaction mark may leak (#4568)"
468715b 
This reverts commit 5c5ceb1.
Apache9 added a commit that referenced this pull request Jul 21, 2022
@Apache9
Revert "HBASE-27152 Under compaction mark may leak (#4568)"
cf4da36 
This reverts commit 3ebb436.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Apache9 Apache9 Apache9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sunhelly @Apache-HBase @Apache9