HBASE-27201 Clean up error-prone findings in hbase-backup #4622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
reviewed
Jul 16, 2022
| @@ -1639,7 +1642,7 @@ public String[] getListOfBackupIdsFromDeleteOperation() throws IOException { | |||
| if (val.length == 0) { | |||
| return null; | |||
| } | |||
| return new String(val).split(","); | |||
| return new String(val, StandardCharsets.UTF_8).split(","); | |||
There was a problem hiding this comment.
I think this will introduce another error prone warning? Use guava's Splitter.on
| @@ -1720,7 +1723,7 @@ public String[] getListOfBackupIdsFromMergeOperation() throws IOException { | |||
| if (val.length == 0) { | |||
| return null; | |||
| } | |||
| return new String(val).split(","); | |||
| return new String(val, StandardCharsets.UTF_8).split(","); | |||
There was a problem hiding this comment.
It does not produce a warning, because stringsplitter warnings are suppressed.
| @@ -1736,11 +1739,13 @@ static Scan createScanForOrigBulkLoadedFiles(TableName table) { | |||
| return scan; | |||
| } | |||
|
|
|||
| @SuppressWarnings("StringSplitter") | |||
There was a problem hiding this comment.
Since we have shaded guava, I think it is OK for use to make use of guava's Splitter.
There was a problem hiding this comment.
There's nothing wrong with string.split in these applications and when I used Splitter it caused more trouble than it was worth.
| static String getTableNameFromOrigBulkLoadRow(String rowStr) { | ||
| String[] parts = rowStr.split(BLK_LD_DELIM); | ||
| return parts[1]; | ||
| } | ||
|
|
||
| @SuppressWarnings("StringSplitter") |
| @@ -275,12 +276,12 @@ public static List<String> getWALFilesOlderThan(final Configuration c, | |||
| return logFiles; | |||
| } | |||
|
|
|||
| @SuppressWarnings("StringSplitter") | |||
| @@ -593,6 +594,7 @@ public int compare(BackupInfo o1, BackupInfo o2) { | |||
| return ts1 < ts2 ? 1 : -1; | |||
| } | |||
|
|
|||
| @SuppressWarnings("StringSplitter") | |||
| @@ -731,6 +733,7 @@ public static BulkLoadHFiles createLoader(Configuration config) { | |||
| return BulkLoadHFiles.create(conf); | |||
| } | |||
|
|
|||
| @SuppressWarnings("StringSplitter") | |||
|
@Apache9 It is fine to handle the string split warnings some other way, but I thought I would take this approach. I had a bit of trouble actually using Splitter. I'm sure I could figure it out but there are other things that seem more important. string#split works in these cases and is good enough IMHO. Is this ok? Or, we could just leave these in place and also not add the |
|
Lets apply the new spotless rule for the automated fix for many of the javadoc issues, and then come back to this PR. |
Usually there is no harm to use String.split, as long as it has been like this for a long time in our code base, so I'm OK with leaving it as is or adding a SuppressWarnings. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.