HBASE-27234 Clean up error-prone warnings in hbase-examples #4647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
reviewed
Jul 25, 2022
| return null; | ||
| } | ||
| if (!buf.hasArray()) { | ||
| buf = ByteBuffer.wrap(buf.array(), buf.arrayOffset(), buf.remaining()); |
There was a problem hiding this comment.
I mean here, if the buf is not array backed, we should create a byte array, copy the content to it and then call toString(byte[])?
Here we test !buf.hasArray(), but then we still call buf.array()...
There was a problem hiding this comment.
No. Added this support here in hbase-common.
There was a problem hiding this comment.
This is the code in hbase-common. I mean here we should copy the content out to a byte array and then call the toString method which accepts byte array.
If buf.hasArray() returns false, then how could we call buf.array() to get its non-existent backing array?
hbase-examples/src/main/java/org/apache/hadoop/hbase/coprocessor/example/RowCountEndpoint.java
Outdated
Show resolved
Hide resolved
|
Rebase. Address review feedback. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
Rebase. More review feedback. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
virajjasani
approved these changes
Jul 28, 2022
Apache9
reviewed
Jul 28, 2022
| * @return UTF8 decoded string value | ||
| */ | ||
| public static String utf8(final ByteBuffer buf) { | ||
| return buf.toString(); |
There was a problem hiding this comment.
I do not think this is what we want? We should copy the content a byte array and then call the above utf8 method?
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
Let me also commit this after addressing the utf8 method problem... |
Apache9
pushed a commit
that referenced
this pull request
Aug 20, 2022
Close #4647 Co-authored-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org> (cherry picked from commit 35fb37c) Conflicts: hbase-examples/src/main/java/org/apache/hadoop/hbase/coprocessor/example/BulkDeleteEndpoint.java hbase-examples/src/main/java/org/apache/hadoop/hbase/coprocessor/example/RowCountEndpoint.java hbase-examples/src/test/java/org/apache/hadoop/hbase/security/provider/example/TestShadeSaslAuthenticationProvider.java
Apache9
pushed a commit
that referenced
this pull request
Aug 20, 2022
Close #4647 Co-authored-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org> (cherry picked from commit 35fb37c) Conflicts: hbase-examples/src/main/java/org/apache/hadoop/hbase/coprocessor/example/BulkDeleteEndpoint.java hbase-examples/src/main/java/org/apache/hadoop/hbase/coprocessor/example/RowCountEndpoint.java hbase-examples/src/test/java/org/apache/hadoop/hbase/security/provider/example/TestShadeSaslAuthenticationProvider.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.