Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-22803 Modify config value range to enable turning off of the hbck chore #466

Merged
merged 1 commit into from
Aug 9, 2019
Merged

HBASE-22803 Modify config value range to enable turning off of the hbck chore #466

merged 1 commit into from
Aug 9, 2019

Conversation

the-sakthi
Copy link
Member

No description provided.

infraio
infraio reviewed Aug 8, 2019
View reviewed changes
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HbckChore.java Outdated
@@ -98,29 +98,49 @@
private volatile long checkingStartTimestamp = 0;
private volatile long checkingEndTimestamp = 0;

private boolean stopped = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stopped ==> disabled?

infraio
infraio reviewed Aug 8, 2019
View reviewed changes
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HbckChore.java Outdated
int interval =
master.getConfiguration().getInt(HBCK_CHORE_INTERVAL, DEFAULT_HBCK_CHORE_INTERVAL);
if (interval <= 0) {
LOG.warn(HBCK_CHORE_INTERVAL + "is <=0 hence disabling hbck chore");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a whitespace before "is".

infraio
infraio reviewed Aug 8, 2019
View reviewed changes
Copy link
Contributor

@infraio infraio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a ut for this?

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 75 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 449 master passed
+1 compile 70 master passed
+1 checkstyle 97 master passed
+1 shadedjars 345 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 44 master passed
0 spotbugs 312 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 309 master passed
_ Patch Compile Tests _
+1 mvninstall 396 the patch passed
+1 compile 67 the patch passed
+1 javac 67 the patch passed
+1 checkstyle 94 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 340 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1193 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 40 the patch passed
+1 findbugs 307 the patch passed
_ Other Tests _
-1 unit 18277 hbase-server in the patch failed.
+1 asflicense 31 The patch does not generate ASF License warnings.
22597
Reason Tests
Failed junit tests hadoop.hbase.client.TestAsyncTableGetMultiThreaded
hadoop.hbase.client.TestSnapshotTemporaryDirectory
hadoop.hbase.client.TestCloneSnapshotFromClientNormal
hadoop.hbase.client.TestFromClientSide
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-466/1/artifact/out/Dockerfile
GITHUB PR #466
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux aafcab0cb35c 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-466/out/precommit/personality/provided.sh
git revision master / 547cec4
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-466/1/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-466/1/testReport/
Max. process+thread count 4622 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-466/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 66 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 352 master passed
+1 compile 57 master passed
+1 checkstyle 90 master passed
+1 shadedjars 295 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 37 master passed
0 spotbugs 266 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 264 master passed
_ Patch Compile Tests _
+1 mvninstall 327 the patch passed
+1 compile 57 the patch passed
+1 javac 57 the patch passed
+1 checkstyle 87 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 297 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1020 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 34 the patch passed
+1 findbugs 273 the patch passed
_ Other Tests _
+1 unit 13401 hbase-server in the patch passed.
+1 asflicense 29 The patch does not generate ASF License warnings.
17099
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-466/3/artifact/out/Dockerfile
GITHUB PR #466
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux b690cd16ef2b 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-466/out/precommit/personality/provided.sh
git revision master / 9250977
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-466/3/testReport/
Max. process+thread count 4892 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-466/3/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 140 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 363 master passed
+1 compile 57 master passed
+1 checkstyle 83 master passed
+1 shadedjars 313 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 36 master passed
0 spotbugs 262 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 259 master passed
_ Patch Compile Tests _
+1 mvninstall 393 the patch passed
+1 compile 58 the patch passed
+1 javac 58 the patch passed
+1 checkstyle 80 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 321 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1112 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 35 the patch passed
+1 findbugs 289 the patch passed
_ Other Tests _
-1 unit 18344 hbase-server in the patch failed.
+1 asflicense 37 The patch does not generate ASF License warnings.
22342
Reason Tests
Failed junit tests hadoop.hbase.replication.TestReplicationSmallTestsSync
hadoop.hbase.tool.TestBulkLoadHFiles
hadoop.hbase.replication.TestReplicationDisableInactivePeer
hadoop.hbase.client.TestFromClientSide
hadoop.hbase.replication.TestReplicationSmallTests
hadoop.hbase.tool.TestSecureBulkLoadHFiles
hadoop.hbase.master.TestAssignmentManagerMetrics
hadoop.hbase.namespace.TestNamespaceAuditor
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-466/2/artifact/out/Dockerfile
GITHUB PR #466
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 46369aa56fb5 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-466/out/precommit/personality/provided.sh
git revision master / 9250977
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-466/2/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-466/2/testReport/
Max. process+thread count 4936 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-466/2/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@the-sakthi the-sakthi force-pushed the HBASE-22803 branch 2 times, most recently from c8eb0fd to 1c383e4 Compare August 8, 2019 18:02
@the-sakthi
Copy link
Member Author

the-sakthi commented Aug 8, 2019 •
edited
Loading

Thanks for your suggestions @infraio , have updated the changes.

@the-sakthi the-sakthi self-assigned this Aug 8, 2019
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 75 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1 mvninstall 363 master passed
+1 compile 60 master passed
+1 checkstyle 91 master passed
+1 shadedjars 305 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 40 master passed
0 spotbugs 273 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 270 master passed
_ Patch Compile Tests _
+1 mvninstall 326 the patch passed
+1 compile 56 the patch passed
+1 javac 56 the patch passed
+1 checkstyle 90 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 295 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1022 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 35 the patch passed
+1 findbugs 266 the patch passed
_ Other Tests _
-1 unit 13701 hbase-server in the patch failed.
+1 asflicense 26 The patch does not generate ASF License warnings.
17439
Subsystem Report/Notes
Docker Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-466/4/artifact/out/Dockerfile
GITHUB PR #466
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux f7a93e6c26e0 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-466/out/precommit/personality/provided.sh
git revision master / 9250977
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-466/4/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-466/4/testReport/
Max. process+thread count 4932 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-466/4/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@the-sakthi
Copy link
Member Author

Thanks for the review @infraio

@the-sakthi the-sakthi merged commit eb92b25 into apache:master Aug 9, 2019
@the-sakthi the-sakthi deleted the HBASE-22803 branch August 9, 2019 00:33
the-sakthi added a commit that referenced this pull request Aug 9, 2019
@the-sakthi
HBASE-22803 Modify config value range to enable turning off of the hb…
65d6390 
…ck chore (#466)

Signed-off-by: Guanghao Zhang <zghao@apache.org>
the-sakthi added a commit that referenced this pull request Aug 9, 2019
@the-sakthi
HBASE-22803 Modify config value range to enable turning off of the hb…
126eff5 
…ck chore (#466)

Signed-off-by: Guanghao Zhang <zghao@apache.org>
the-sakthi added a commit that referenced this pull request Aug 9, 2019
@the-sakthi
HBASE-22803 Modify config value range to enable turning off of the hb…
2a707ad 
…ck chore (#466)

Signed-off-by: Guanghao Zhang <zghao@apache.org>
the-sakthi added a commit that referenced this pull request Aug 9, 2019
@the-sakthi
HBASE-22803 Modify config value range to enable turning off of the hb…
66197dd 
…ck chore (#466)

Signed-off-by: Guanghao Zhang <zghao@apache.org>
chenxu14 pushed a commit to chenxu14/hbase that referenced this pull request Aug 12, 2019
@the-sakthi @chenxu14
HBASE-22803 Modify config value range to enable turning off of the hb…
a3bb400 
…ck chore (apache#466)

Signed-off-by: Guanghao Zhang <zghao@apache.org>
infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
@the-sakthi
HBASE-22803 Modify config value range to enable turning off of the hb…
f288af5 
…ck chore (apache#466)

Signed-off-by: Guanghao Zhang <zghao@apache.org>
symat pushed a commit to symat/hbase that referenced this pull request Feb 17, 2021
@the-sakthi
HBASE-22803 Modify config value range to enable turning off of the hb…
56b8d46 
…ck chore (apache#466)

Signed-off-by: Guanghao Zhang <zghao@apache.org>
(cherry picked from commit 66197dd)

Change-Id: I92c3c2733f7874724fd0f9745fd759bc7e443486
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infraio infraio infraio approved these changes

Assignees

@the-sakthi the-sakthi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@the-sakthi @Apache-HBase @infraio