-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-22838 : assembly plugin should use posix #480
Conversation
🎊 +1 overall
This message was automatically generated. |
@@ -76,7 +76,7 @@ | |||
<finalName>hbase-${project.version}</finalName> | |||
<skipAssembly>false</skipAssembly> | |||
<appendAssemblyId>true</appendAssemblyId> | |||
<tarLongFileMode>gnu</tarLongFileMode> | |||
<tarLongFileMode>posix</tarLongFileMode> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have any requirement about the mvn version ? If not too new mvn version, I think it's OK (+1). (Sorry, I'm not quite familiar with this option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After reading the parent mvn issue, +1.
Oh, if you make the change, does assembly still work? |
@openinx this works for assembly plugin >= 2.5.0: MASSEMBLY-728 However, this works for master and branch-2, but not branch-1. |
OK, +1. |
Signed-off-by: huzheng <openinx@gmail.com>
Signed-off-by: huzheng <openinx@gmail.com>
Signed-off-by: huzheng <openinx@gmail.com>
Signed-off-by: huzheng <openinx@gmail.com>
Signed-off-by: huzheng <openinx@gmail.com>
Signed-off-by: huzheng <openinx@gmail.com> (cherry picked from commit b4f18e0) Change-Id: Id6ae6efd61bdcfe34b578619a99e18f65f152299
tarball build with assembly:single command fails with user id(mac) or group id(ubuntu) too big error:
To avoid this error and to get better features for tarball build, we should upgrade tarLongFileMode from gnu to posix: MPOM-132