Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-22838 : assembly plugin should use posix #480

Merged
merged 1 commit into from
Aug 13, 2019

Conversation

virajjasani
Copy link
Contributor

@virajjasani virajjasani commented Aug 12, 2019

tarball build with assembly:single command fails with user id(mac) or group id(ubuntu) too big error:

$ mvn clean install package assembly:single -DskipTests
....
....
....
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:3.0.0:single (default-cli) on project hbase-assembly: Execution default-cli of goal org.apache.maven.plugins:maven-assembly-plugin:3.0.0:single failed: user id 'xxxxxxxx' is too big ( > 2097151 ). -> [Help 1]

[ERROR]

[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.

[ERROR] Re-run Maven using the -X switch to enable full debug logging.

[ERROR]

[ERROR] For more information about the errors and possible solutions, please read the following articles:

[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException

[ERROR]

[ERROR] After correcting the problems, you can resume the build with the command

[ERROR]   mvn <goals> -rf :hbase-assembly

To avoid this error and to get better features for tarball build, we should upgrade tarLongFileMode from gnu to posix: MPOM-132

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 132 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 455 master passed
+1 compile 32 master passed
+1 shadedjars 345 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 17 master passed
_ Patch Compile Tests _
+1 mvninstall 415 the patch passed
+1 compile 31 the patch passed
+1 javac 31 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 xml 1 The patch has no ill-formed XML file.
+1 shadedjars 336 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1306 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 14 the patch passed
_ Other Tests _
+1 unit 30 hbase-assembly in the patch passed.
+1 asflicense 14 The patch does not generate ASF License warnings.
3682
Subsystem Report/Notes
Docker Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-480/1/artifact/out/Dockerfile
GITHUB PR #480
Optional Tests dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile
uname Linux bf068eeddaf4 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-480/out/precommit/personality/provided.sh
git revision master / 009851d
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-480/1/testReport/
Max. process+thread count 86 (vs. ulimit of 10000)
modules C: hbase-assembly U: hbase-assembly
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-480/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z)
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@@ -76,7 +76,7 @@
<finalName>hbase-${project.version}</finalName>
<skipAssembly>false</skipAssembly>
<appendAssemblyId>true</appendAssemblyId>
<tarLongFileMode>gnu</tarLongFileMode>
<tarLongFileMode>posix</tarLongFileMode>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have any requirement about the mvn version ? If not too new mvn version, I think it's OK (+1). (Sorry, I'm not quite familiar with this option.

Copy link
Contributor

@saintstack saintstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reading the parent mvn issue, +1.

@saintstack
Copy link
Contributor

Oh, if you make the change, does assembly still work?

@virajjasani
Copy link
Contributor Author

@openinx this works for assembly plugin >= 2.5.0: MASSEMBLY-728
@saintstack yes assembly works, verified with assembly:single command, generated tarball, extracted it and started HMaster, shell, rest etc from it

However, this works for master and branch-2, but not branch-1.

@openinx
Copy link
Member

openinx commented Aug 13, 2019

OK, +1.

@openinx openinx merged commit 9d6a653 into apache:master Aug 13, 2019
asfgit pushed a commit that referenced this pull request Aug 13, 2019
Signed-off-by: huzheng <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Aug 13, 2019
Signed-off-by: huzheng <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Aug 13, 2019
Signed-off-by: huzheng <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Aug 14, 2019
Signed-off-by: huzheng <openinx@gmail.com>
infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
Signed-off-by: huzheng <openinx@gmail.com>
symat pushed a commit to symat/hbase that referenced this pull request Feb 17, 2021
Signed-off-by: huzheng <openinx@gmail.com>
(cherry picked from commit b4f18e0)

Change-Id: Id6ae6efd61bdcfe34b578619a99e18f65f152299
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants