Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-27799: RpcThrottlingException wait interval message is misleading between 0-1s #5192

Merged
merged 11 commits into from
May 4, 2023
Merged

HBASE-27799: RpcThrottlingException wait interval message is misleading between 0-1s #5192

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
94fe90a
HBASE-27799: fix misleading RpcThrottlingException message
Apr 19, 2023
fec0eda
add TestRpcThrottlingException
Apr 19, 2023
ca23322
include ms on all RpcThrottlingException messages
Apr 20, 2023
e87b3ed
javac: include fail to enforce exception expectations
Apr 21, 2023
2c3ac82
fix timeFromString
Apr 26, 2023
8de4a19
support legacy timeFromString
Apr 26, 2023
ded03ee
unify timeFromString and DRY
Apr 26, 2023
b25ded1
match 1 pattern
Apr 26, 2023
dfa5f5e
only 1 pattern
Apr 26, 2023
c5d1e49
pr feedback: better tests, cleaner copy
May 2, 2023
cdeb4a7
more test cases
May 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion hbase-client/src/main/java/org/apache/hadoop/hbase/quotas/RpcThrottlingException.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,19 @@ public static void throwWriteCapacityUnitExceeded(final long waitInterval)

private static void throwThrottlingException(final Type type, final long waitInterval)
throws RpcThrottlingException {
String msg = MSG_TYPE[type.ordinal()] + MSG_WAIT + StringUtils.formatTime(waitInterval);
String msg = MSG_TYPE[type.ordinal()] + MSG_WAIT + stringFromMillis(waitInterval);
throw new RpcThrottlingException(type, waitInterval, msg);
}

private static String stringFromMillis(long millis) {
if (millis >= 1000) {
return StringUtils.formatTime(millis);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I realize this will continue to be misleading for values greater than 1s. For example 1.9s is almost double what would be shown by formatTime. It matters less for values in the 10s of seconds or higher, but I think it will be very common to have values mostly in the single digit seconds.

We could copy the impl of formatTime here and add ms, or use the existing formatTime and append a ms part, or look for a different "humanize" method/library (as long as it's already a dep)

} else {
// StringUtils#formatTime doesn't support millis
return millis + "ms";
}
}

private static long timeFromString(String timeDiff) {
Pattern[] patterns = new Pattern[] { Pattern.compile("^(\\d+\\.\\d\\d)sec"),
Pattern.compile("^(\\d+)mins, (\\d+\\.\\d\\d)sec"),
Expand Down