HBASE-27683 Should support single call queue mode for RPC handlers wh… #5259

sunhelly · 2023-05-30T08:28:31Z

…ile separating by request type

Apache-HBase · 2023-05-30T09:11:42Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 43s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 45s	master passed
+1 💚	compile	2m 26s	master passed
+1 💚	checkstyle	0m 33s	master passed
+1 💚	spotless	0m 42s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 32s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 35s	the patch passed
+1 💚	compile	2m 25s	the patch passed
+1 💚	javac	2m 25s	the patch passed
+1 💚	checkstyle	0m 33s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	8m 59s	Patch does not cause any errors with Hadoop 3.2.4 3.3.5.
-1 ❌	spotless	0m 36s	patch has 26 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	1m 34s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 12s	The patch does not generate ASF License warnings.
		31m 19s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5259/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5259
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 0816dd0b89d9 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 08:53:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `79c985f`
Default Java	Eclipse Adoptium-11.0.17+8
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5259/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	83 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5259/1/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-05-30T12:37:55Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 28s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 29s	master passed
+1 💚	compile	0m 40s	master passed
+1 💚	shadedjars	4m 31s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 14s	the patch passed
+1 💚	compile	0m 40s	the patch passed
+1 💚	javac	0m 40s	the patch passed
+1 💚	shadedjars	4m 29s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 23s	the patch passed
		_ Other Tests _
+1 💚	unit	214m 40s	hbase-server in the patch passed.
		237m 26s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5259/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5259
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux cd3ea2e604fe 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 08:53:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `79c985f`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5259/1/testReport/
Max. process+thread count	4716 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5259/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-05-30T13:53:56Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 14s	master passed
+1 💚	compile	1m 8s	master passed
+1 💚	shadedjars	7m 3s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 35s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 39s	the patch passed
+1 💚	compile	1m 2s	the patch passed
+1 💚	javac	1m 2s	the patch passed
+1 💚	shadedjars	7m 4s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 30s	the patch passed
		_ Other Tests _
-1 ❌	unit	283m 8s	hbase-server in the patch failed.
		313m 9s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5259/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5259
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 90cd0367b0b8 5.4.0-1099-aws #107~18.04.1-Ubuntu SMP Fri Mar 17 16:49:05 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `79c985f`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5259/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5259/1/testReport/
Max. process+thread count	4642 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5259/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2023-05-31T13:42:21Z

hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RWQueueRpcExecutor.java

@@ -76,7 +76,9 @@ public RWQueueRpcExecutor(final String name, final int handlerCount, final int m
    numWriteQueues = calcNumWriters(this.numCallQueues, callqReadShare);
    writeHandlersCount = Math.max(numWriteQueues, calcNumWriters(handlerCount, callqReadShare));

-    int readQueues = calcNumReaders(this.numCallQueues, callqReadShare);
+    int readQueues = callqReadShare > 0 ?


What is the return value of calcNumReaders if callqReadShare is 0?

If callqReadShare==0, it will not be an instance of RWQueueRpcExecutor, then will not call calcNumReaders. But readQueues will be 0 under other circumstances by the origin design, when the numCallQueues=1 and numWriteQueues=1.

What do you mean by "will not call calcNumReaders"? Either in the old code or in your new code, we will always call the calcNumReaders method?

Thanks. I think when callqReadShare is 0, the RpcExecutor will be FastPathBalancedQueueRpcExecutor by default (see SimpleRpcScheduler line 88), not based on RWQueueRpcExecutor(which by default will create FastPathRWQueueRpcExecutor), and then there are not distinguished queues, all queues serve for read and write.

HBASE-27683 Should support single call queue mode for RPC handlers wh…

92b84dc

…ile separating by request type

Apache9 reviewed May 31, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-27683 Should support single call queue mode for RPC handlers wh… #5259

HBASE-27683 Should support single call queue mode for RPC handlers wh… #5259

sunhelly commented May 30, 2023

Apache-HBase commented May 30, 2023

Apache-HBase commented May 30, 2023

Apache-HBase commented May 30, 2023

Apache9 May 31, 2023

sunhelly Jun 1, 2023

Apache9 Jun 2, 2023

sunhelly Jun 7, 2023

HBASE-27683 Should support single call queue mode for RPC handlers wh… #5259

Are you sure you want to change the base?

HBASE-27683 Should support single call queue mode for RPC handlers wh… #5259

Conversation

sunhelly commented May 30, 2023

Apache-HBase commented May 30, 2023

Apache-HBase commented May 30, 2023

Apache-HBase commented May 30, 2023

Apache9 May 31, 2023

Choose a reason for hiding this comment

sunhelly Jun 1, 2023

Choose a reason for hiding this comment

Apache9 Jun 2, 2023

Choose a reason for hiding this comment

sunhelly Jun 7, 2023

Choose a reason for hiding this comment