HBASE-27553: add row param to mutation slow logs #5328

rmdmattingly · 2023-07-18T23:17:51Z

Per conversation in HBASE-27553, we could provide the related row in the params blob for mutation slow logs. This should be useful information for the debugger reading the logs.

cc @bbeaudreault @hgromer @saijmo @eab148 @bozzkar

Apache-HBase · 2023-07-18T23:25:56Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 0s	Docker mode activated.
-1 ❌	patch	0m 3s	#5328 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem	Report/Notes
GITHUB PR	#5328
JIRA Issue	HBASE-27553
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5328/1/console
versions	git=2.25.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-07-18T23:26:03Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 0s	Docker mode activated.
-1 ❌	patch	0m 2s	#5328 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem	Report/Notes
GITHUB PR	#5328
JIRA Issue	HBASE-27553
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5328/1/console
versions	git=2.17.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-07-18T23:26:09Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 0s	Docker mode activated.
-1 ❌	patch	0m 3s	#5328 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem	Report/Notes
GITHUB PR	#5328
JIRA Issue	HBASE-27553
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5328/1/console
versions	git=2.25.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-07-18T23:58:15Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 27s	master passed
+1 💚	compile	0m 19s	master passed
+1 💚	shadedjars	4m 28s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 16s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 18s	the patch passed
+1 💚	compile	0m 19s	the patch passed
+1 💚	javac	0m 19s	the patch passed
+1 💚	shadedjars	4m 27s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 15s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 17s	hbase-client in the patch passed.
		17m 51s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5328/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5328
JIRA Issue	HBASE-27553
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux cbc4d4aed3ed 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2c92e6f`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5328/2/testReport/
Max. process+thread count	291 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5328/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-07-19T00:08:01Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 14s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 54s	master passed
+1 💚	compile	0m 36s	master passed
+1 💚	checkstyle	0m 14s	master passed
+1 💚	spotless	0m 41s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 43s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 31s	the patch passed
+1 💚	compile	0m 35s	the patch passed
+1 💚	javac	0m 35s	the patch passed
+1 💚	checkstyle	0m 13s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	9m 30s	Patch does not cause any errors with Hadoop 3.2.4 3.3.5.
+1 💚	spotless	0m 38s	patch has no errors when running spotless:check.
+1 💚	spotbugs	0m 46s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 9s	The patch does not generate ASF License warnings.
		27m 42s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5328/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5328
JIRA Issue	HBASE-27553
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux a63dc3148548 5.4.0-1099-aws #107~18.04.1-Ubuntu SMP Fri Mar 17 16:49:05 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2c92e6f`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	76 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5328/2/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-07-19T00:08:35Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 47s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 21s	master passed
+1 💚	compile	0m 32s	master passed
+1 💚	shadedjars	7m 3s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 4s	the patch passed
+1 💚	compile	0m 24s	the patch passed
+1 💚	javac	0m 24s	the patch passed
+1 💚	shadedjars	6m 28s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 9s	hbase-client in the patch passed.
		28m 10s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5328/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5328
JIRA Issue	HBASE-27553
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux a06def50279e 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2c92e6f`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5328/2/testReport/
Max. process+thread count	299 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5328/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

bbeaudreault

Actually, would you mind adding a test? IIRC we don't have any tests for this, but it should be simple to add one for the changes here since it's a static method with easy inputs and outputs.

bbeaudreault

Thanks! LGTM

I'll merge once the pre-commit checks all come back.

Apache-HBase · 2023-07-19T19:27:57Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 14s	master passed
+1 💚	compile	0m 18s	master passed
+1 💚	shadedjars	4m 29s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 15s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 17s	the patch passed
+1 💚	compile	0m 18s	the patch passed
+1 💚	javac	0m 18s	the patch passed
+1 💚	shadedjars	4m 36s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 15s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 16s	hbase-client in the patch passed.
		17m 21s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5328/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5328
JIRA Issue	HBASE-27553
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux c320491c92e2 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2c92e6f`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5328/3/testReport/
Max. process+thread count	285 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5328/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-07-19T19:29:36Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 37s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 55s	master passed
+1 💚	compile	0m 20s	master passed
+1 💚	shadedjars	4m 42s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 19s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 46s	the patch passed
+1 💚	compile	0m 20s	the patch passed
+1 💚	javac	0m 20s	the patch passed
+1 💚	shadedjars	4m 37s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 16s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 30s	hbase-client in the patch passed.
		19m 17s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5328/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5328
JIRA Issue	HBASE-27553
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 58e66a2f7ce4 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2c92e6f`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5328/3/testReport/
Max. process+thread count	298 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5328/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-07-19T19:35:36Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 36s	master passed
+1 💚	compile	0m 35s	master passed
+1 💚	checkstyle	0m 14s	master passed
+1 💚	spotless	0m 39s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 37s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 29s	the patch passed
+1 💚	compile	0m 35s	the patch passed
+1 💚	javac	0m 35s	the patch passed
+1 💚	checkstyle	0m 14s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	9m 25s	Patch does not cause any errors with Hadoop 3.2.4 3.3.5.
+1 💚	spotless	0m 38s	patch has no errors when running spotless:check.
+1 💚	spotbugs	0m 47s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 7s	The patch does not generate ASF License warnings.
		25m 7s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5328/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5328
JIRA Issue	HBASE-27553
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 850a482d635a 5.4.0-1099-aws #107~18.04.1-Ubuntu SMP Fri Mar 17 16:49:05 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2c92e6f`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	81 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5328/3/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>

Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org> (cherry picked from commit 49c1749) Change-Id: Ia36e59bf4f9035dadb0cc2efe21cd7717893e634

add row to mutate slow logs

7cb82cb

rmdmattingly force-pushed the HBASE-27553 branch from 8e1f5c1 to 7cb82cb Compare July 18, 2023 23:35

bbeaudreault approved these changes Jul 19, 2023

View reviewed changes

bbeaudreault requested changes Jul 19, 2023

View reviewed changes

add tests

1282ac3

rmdmattingly requested a review from bbeaudreault July 19, 2023 19:12

bbeaudreault approved these changes Jul 19, 2023

View reviewed changes

Apache9 approved these changes Jul 20, 2023

View reviewed changes

bbeaudreault merged commit aec9db4 into apache:master Jul 24, 2023

bbeaudreault deleted the HBASE-27553 branch July 24, 2023 11:58

bbeaudreault pushed a commit that referenced this pull request Jul 24, 2023

HBASE-27553 Add row param to mutation slow logs (#5328)

1f3af7e

Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>

bbeaudreault pushed a commit that referenced this pull request Jul 24, 2023

HBASE-27553 Add row param to mutation slow logs (#5328)

cfa3f13

Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>

bbeaudreault pushed a commit that referenced this pull request Jul 24, 2023

HBASE-27553 Add row param to mutation slow logs (#5328)

49c1749

Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>

bbeaudreault pushed a commit that referenced this pull request Jul 24, 2023

HBASE-27553 Add row param to mutation slow logs (#5328)

ac02aa0

Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>

bbeaudreault pushed a commit to HubSpot/hbase that referenced this pull request Jul 24, 2023

HBASE-27553 Add row param to mutation slow logs (apache#5328)

18f1b81

Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-27553: add row param to mutation slow logs #5328

HBASE-27553: add row param to mutation slow logs #5328

rmdmattingly commented Jul 18, 2023

Apache-HBase commented Jul 18, 2023

Apache-HBase commented Jul 18, 2023

Apache-HBase commented Jul 18, 2023

Apache-HBase commented Jul 18, 2023

Apache-HBase commented Jul 19, 2023

Apache-HBase commented Jul 19, 2023

bbeaudreault left a comment

bbeaudreault left a comment •

edited

Loading

Apache-HBase commented Jul 19, 2023

Apache-HBase commented Jul 19, 2023

Apache-HBase commented Jul 19, 2023

HBASE-27553: add row param to mutation slow logs #5328

HBASE-27553: add row param to mutation slow logs #5328

Conversation

rmdmattingly commented Jul 18, 2023

Apache-HBase commented Jul 18, 2023

Apache-HBase commented Jul 18, 2023

Apache-HBase commented Jul 18, 2023

Apache-HBase commented Jul 18, 2023

Apache-HBase commented Jul 19, 2023

Apache-HBase commented Jul 19, 2023

bbeaudreault left a comment

Choose a reason for hiding this comment

bbeaudreault left a comment • edited Loading

Choose a reason for hiding this comment

Apache-HBase commented Jul 19, 2023

Apache-HBase commented Jul 19, 2023

Apache-HBase commented Jul 19, 2023

bbeaudreault left a comment •

edited

Loading