-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-27896 Disable hdfs readahead for pread reads #5336
Conversation
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
re-trigger pre-commit check |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1.
But I couldn't find the discussion thread mentioned in the ticket, is it aligned among users or members?
Thanks @Reidddddd! Here's the list thread: https://lists.apache.org/thread/pokw1bwtr26hdbmlmx4tx1g1fczqrtxt. I'll add it to the ticket as well. |
The spotless failure was more of a failure in the mvn process. I don't see any actual formatting issues in the log, and spotless previously succeeded. Going to merge. |
Signed-off-by: Reid Chan <reidchan@apache.org>
Signed-off-by: Reid Chan <reidchan@apache.org>
…pache#5336) Signed-off-by: Reid Chan <reidchan@apache.org>
I left the option in place, but just changed the default. If desired, I could just remove the option as well. I can't think of a case where it would be good to enable, am just trying to preserve compatibility if anyone has set it.