-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-28244 ProcedureTestingUtility.restart is broken sometimes after… #5563
Conversation
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
The failure for TestRollbackSCP is because there are races between rollbacking a OpenRegionProcedure and reportRegionStateTransition. When rollbacking, we will set the state to rolledback, for recording metrics, and then we will just delete the procedure, but at the same time, a reportRegionStateTransition call is arrived and then persist the rolledback state to procedure store... Need to find out a way to deal with this... |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
@@ -89,7 +98,7 @@ public static void suspendIfNecessary(Procedure<?> proc, | |||
} catch (IOException ioe) { | |||
LOG.error("Error while acquiring execution lock for procedure {}" | |||
+ " when trying to wake it up, aborting...", proc, ioe); | |||
env.getMasterServices().abort("Can not acquire procedure execution lock", e); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, we didn't realize that this exception was written incorrectly before.
…BASE-28199 (#5563) Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit 29bfc61)
… HBASE-28199 (apache#5563) Signed-off-by: Duo Zhang <zhangduo@apache.org>
… HBASE-28199